Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3739707rdg; Wed, 18 Oct 2023 04:59:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG3niZhDitsnJJlgSkc01g6orWfIeJsR06tPLWH5RbhJypNsXbg6LOeZlHDDfRWb6SbsM14 X-Received: by 2002:a17:902:e802:b0:1c5:ecfc:2650 with SMTP id u2-20020a170902e80200b001c5ecfc2650mr7209568plg.14.1697630346894; Wed, 18 Oct 2023 04:59:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697630346; cv=none; d=google.com; s=arc-20160816; b=Qom91rlwwXV+ueFE6uXaaLFv3RyXzc+wDk6FlY/HSlX8JSNc0Uwd8ZRtZV1Zo1MQ8Y OxFI9W9keSx2S7hYOuvXqJTJo5ledoRbUZlks8wq2wnSj5mJwI+Olpwjdai9M8/Fc38W J0sBGGaY1AwoDxxoO/r4ZiWeR7+vyXIG3rHusnNXY9TJVQvAsCaV0h0drBcV1d7amboq 2yfwKbx+MSqk/tRuopPJs31MwW7RPonivlW9U6BdK4K+1zA+9UeE2LAvUamapnEbU4za 4k3llOIMpzHHJBQzeACOZBKZYaHEtnFani/I+dL2rxxA/feJw2zUVSKJiTFEY7JD5pQK rbRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature:dkim-signature; bh=q0AxnT/F0IBxB0Yp/bqQFQxMBbuxuwHiKBnaRRpMhzs=; fh=U5SkAGn1qfNByPwg14tOLIRF4CpLMn60cHINjkyz8JQ=; b=PDkgrlsqS0b3MKJ+fFSTqihw6xpIbDmOTTAyNKk9wiLsb6Q0IsxjL+6KUhM7uhiRUh 1NY2htpPB13zIdrbzYpozg71qt/6U5RE2jBoK2qkOPBiWIL8nE3aORrbjWdfmo8XOud9 L2LCQQpl5H+mnKLv8EiHS80pscgglWpYEi716eWxETp8FPVvvHvogCQijDRwaCahhEZg C0iHGkmiBKwDYSbExoMLm+MrxfXpR6sJ5u0JW5EaW31dtacp0QF32Y2vlK029qlo0n5Z Z92JD5Juc+FOUFPTzJA/DtnAQgure6UKF+7ubtcWAGN4aNPOjM3zoiWzEzwACEoMWjiX USRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=n2ogvZRq; dkim=neutral (no key) header.i=@suse.cz header.b=RbSbc1AF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id v191-20020a6389c8000000b005aa0af5b62esi1885227pgd.511.2023.10.18.04.59.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 04:59:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=n2ogvZRq; dkim=neutral (no key) header.i=@suse.cz header.b=RbSbc1AF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id D209B80BE877; Wed, 18 Oct 2023 04:59:03 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230231AbjJRL6u (ORCPT + 99 others); Wed, 18 Oct 2023 07:58:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229846AbjJRL6s (ORCPT ); Wed, 18 Oct 2023 07:58:48 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 838ED95; Wed, 18 Oct 2023 04:58:46 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C254E1FD7D; Wed, 18 Oct 2023 11:58:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1697630324; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q0AxnT/F0IBxB0Yp/bqQFQxMBbuxuwHiKBnaRRpMhzs=; b=n2ogvZRqDt10sDpgbuyo+2O912xw95RC5jIJJZCF+VzsvjAxk6tvlSnjvyaZiOXSXw4BgI ZNd4geBmjtt4K0lgXUJYIxPmMGDrO9870aw5NC3EzvXyKpqwQ2qoUMScNR3QzaP1Vj2hn8 5dsS0sZMhpyALIP1uL3yEFP9yh6S8wU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1697630324; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q0AxnT/F0IBxB0Yp/bqQFQxMBbuxuwHiKBnaRRpMhzs=; b=RbSbc1AFDL8QHUW++GdtWM/1g0jAY6v9i7uHxVv5U5aHMkVdiIwmvYK2ko0KxSIg+wFows y4e5hJu0uBBDUVDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8FE9513915; Wed, 18 Oct 2023 11:58:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Au5uInTIL2WnAwAAMHmgww (envelope-from ); Wed, 18 Oct 2023 11:58:44 +0000 Message-ID: <951fb89d-f972-0d7f-c3a9-2ab8af8d7491@suse.cz> Date: Wed, 18 Oct 2023 13:58:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v3 3/5] mm: kmem: make memcg keep a reference to the original objcg Content-Language: en-US To: Roman Gushchin , Andrew Morton Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Johannes Weiner , Michal Hocko , shakeelb@google.com, Muchun Song , Dennis Zhou , David Rientjes , Naresh Kamboju References: <20231016221900.4031141-1-roman.gushchin@linux.dev> <20231016221900.4031141-4-roman.gushchin@linux.dev> From: Vlastimil Babka In-Reply-To: <20231016221900.4031141-4-roman.gushchin@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Authentication-Results: smtp-out2.suse.de; none X-Spam-Level: X-Spam-Score: -6.03 X-Spamd-Result: default: False [-6.03 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; BAYES_HAM(-1.93)[94.65%]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-3.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCPT_COUNT_SEVEN(0.00)[11]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 18 Oct 2023 04:59:04 -0700 (PDT) On 10/17/23 00:18, Roman Gushchin wrote: > Keep a reference to the original objcg object for the entire life > of a memcg structure. > > This allows to simplify the synchronization on the kernel memory > allocation paths: pinning a (live) memcg will also pin the > corresponding objcg. > > The memory overhead of this change is minimal because object cgroups > usually outlive their corresponding memory cgroups even without this > change, so it's only an additional pointer per memcg. > > Signed-off-by: Roman Gushchin (Cruise) > Tested-by: Naresh Kamboju > Acked-by: Shakeel Butt Reviewed-by: Vlastimil Babka