Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3751561rdg; Wed, 18 Oct 2023 05:16:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFf0UfClbE+MmvbVdXyLIIf5Bqp/lntg3QpWAhT0NswWg1IQVlKLelThERWXNAmPs8KSE0m X-Received: by 2002:a05:6a21:329a:b0:17a:eddb:acc2 with SMTP id yt26-20020a056a21329a00b0017aeddbacc2mr4704798pzb.46.1697631361019; Wed, 18 Oct 2023 05:16:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697631361; cv=none; d=google.com; s=arc-20160816; b=bV9y/SHv0DUcvSPiW5A6ZK7yAgf9rxzDt4mAL4gsFYWiNVnwnB1wA33YJYVwfu1Ccf mlJhCN9U/v7bf5cRcBML/3tjDZgh+pDJYFspUKvxO9l/jdNxbnCNgq61pMeaQOUMdnDG ZJV92VNPaxRWyjgD/Vwpr6MkTyyLxBl5fp7i4EigPrvGIMWdvbOJdiuZgUaFFz6rSc+w lR+KkJSfuRyaiZHJ9IvZctyGfxF/LXmxkA7BMdcrv1ZAuHBXV3Q3GYKFyyy7wEcaSCYY RIu1raIz0At2Iixo9ptmW5r0GlZSeTRFfpTCXUUT6BKbsfwuDdqibVhaA7fc3RF/fv3q LE2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=zumtdsyrV0KBvO2wFodhcV/rBtBqoWg9M0cTr5PzyXA=; fh=lt/3JhgyHZShh/QV+9OWxkA5ZsRkf8kDXNbHaSRjlsQ=; b=Z/wd7B5PMmoZICHmxfQfqcJjheN6SDfAqdhhba3VvYyJEH1nQTEJQxxtGNvz+kMxW5 2JihuPgT0XcXwpUUy0pP4bEDxz/CNo/trWO2Dkc9QNQK9O30W7pJHWodZd1n5gyVca4Z y/WhNNcmB3ZfKnsaFZYnygd+zRpnpoAinM3fP284DqnRlYnom5DBcMZlz5TjXRHeSGZ4 u+PHKq6L3+ZPUweEZF+CzcP+WXNZ+mRXf7iUEJ8WUjzQb7h29Z4JdhhUz9Bdqs61V7QD cbaK/W2czoGMSl9MDAeLDPDR6jL6zdnW5tl5smuyxDlnpG26voDillHDAskr3Vvc0bEs gAhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=g8VeTgBY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id z16-20020a656650000000b0058b8c72c5ddsi1902830pgv.607.2023.10.18.05.16.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 05:16:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=g8VeTgBY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 6EF8A805F406; Wed, 18 Oct 2023 05:15:57 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234927AbjJRMPn (ORCPT + 99 others); Wed, 18 Oct 2023 08:15:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231663AbjJRMPl (ORCPT ); Wed, 18 Oct 2023 08:15:41 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3791120 for ; Wed, 18 Oct 2023 05:15:37 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-53db3811d8fso14096196a12.1 for ; Wed, 18 Oct 2023 05:15:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697631336; x=1698236136; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=zumtdsyrV0KBvO2wFodhcV/rBtBqoWg9M0cTr5PzyXA=; b=g8VeTgBYJdDhTUTAA2UQc/ty0HYWrT7PQW6rk525d8f+6vFPhOrghEA8SbGyyS36NU dfGXpdrPtHJq6jzgQdlKYD396t4/V2JKaWYVq8Cy70msw6yAmequ70U/XZ0zvCbDoDxI PRzimICuyWwoRIh7i7QsYKPWbwI0XfPV8mtEKQKhbFRO2nimA7+txQqu3gQ+nJpfs468 iJEhpop7swr/cj+x4ar07CnvKceXVIz55hipsqFC503G2ItsA+bZ03hn5dmfETf7g7c5 JOTy1rDSqDT0HR85/GQteFrnW5UJuEYBVC4bU5Njl1QNohTDEC8J+5+BEVfhuNUidWoY dyjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697631336; x=1698236136; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zumtdsyrV0KBvO2wFodhcV/rBtBqoWg9M0cTr5PzyXA=; b=b2DzmoYah29wOt567ebkvQPDyoTo9P04uHMlXB+zRp/W7Kt8mtOwIP56VywQvy6cSy meC58ijOL/l5J9BXqcGEpJwyZfiV5sZ62+XptwvE80wHLSiixew1451RFFkoQXKKBDiw 0wbeTNqNfPTZs4N7dTp8k0VYtH4TLtJjRQguXyIegLS9+GiJboVoRI+ViN78nwcWC1hy iOBmNjyZp2P1MqmjUvPiKXAg/a6U5KhU7JBW9GYzaGQsAN8JyK6vdTM08AoMAEsiy63g 3jbJckCLgnHG/xzC6rlRVe1yKNiZNRZ0o2h3xLOQNIr7XJfw9tx7rq2ZG8EHgjnrtThE wuIw== X-Gm-Message-State: AOJu0YxbUSOdWnIylO0t2ik/9OTpKfStCDfzhks40aW5NXVWBC27aUfL XnFCEZYMGgRqbyxWI+3jBTo= X-Received: by 2002:a05:6402:1a52:b0:530:8fdb:39c8 with SMTP id bf18-20020a0564021a5200b005308fdb39c8mr4120870edb.15.1697631336270; Wed, 18 Oct 2023 05:15:36 -0700 (PDT) Received: from gmail.com (1F2EF7B2.nat.pool.telekom.hu. [31.46.247.178]) by smtp.gmail.com with ESMTPSA id cb12-20020a0564020b6c00b0053ebf32da31sm2728578edb.57.2023.10.18.05.15.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 05:15:35 -0700 (PDT) Sender: Ingo Molnar Date: Wed, 18 Oct 2023 14:15:33 +0200 From: Ingo Molnar To: Li kunyu Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sched: topology: =?utf-8?Q?Rem?= =?utf-8?B?b3ZlIHVubmVjZXNzYXJ5IOKAmDDigJk=?= values from nr_levels Message-ID: References: <20231017062006.10879-1-kunyu@nfschina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231017062006.10879-1-kunyu@nfschina.com> X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 18 Oct 2023 05:15:57 -0700 (PDT) * Li kunyu wrote: > nr_levels is assigned first, so it does not need to initialize the > assignment. In C there's no such thing as "initializing the assignment"... Please write sensible changelogs that demonstrate an understanding of these principles. Thanks, Ingo