Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3763693rdg; Wed, 18 Oct 2023 05:38:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGSIT0PX9b0QK0Y3Bf2k6hbwPgV7I/PdEJ0iuri6Qn4L5JkQ01f6UgahCAyqP2zl8W8VEhU X-Received: by 2002:a17:90b:1995:b0:27c:fc2a:a178 with SMTP id mv21-20020a17090b199500b0027cfc2aa178mr5037463pjb.9.1697632697201; Wed, 18 Oct 2023 05:38:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697632697; cv=none; d=google.com; s=arc-20160816; b=ij0bXdE5I6QSmY7Azm5cRCQZ2bJDsMxP6KOyBggrFUaUdBliaFLNWLgdrX3tmw6UsY sFDZ1ffAZ3LJ12/VwI+mkX8DVmAnf+mB5vsEyxGm9yozaXd5Y1Z5UEyZteYkz+8rPQGw 3OuTlyMhwWMx5cW+k2X8FzqBvWXyw/scTIMpn3ol5jD7YfURkXZOpjSSjjH6sVPPq8RV j07f42cGDpzztq5l4OYWp9Wz2mAuFZV//q6W5RKVGJ+eBYzgv3/MExdhslwTcJZsljZZ TjgPpi0v7L31g8ioxG+4YfynWKTQuFE9sL05VfUbuhHdMxEfhASO1ajHEmF6XV6YZ0B6 oKUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=3qQmGYMA/S/kWNsfETnUZllqVCQ7paKt7r6KbXhorwY=; fh=w6/sWp0ZoPoyXp6U25OSMXHc8JxvrETWaFFjQItGP/E=; b=HnhxIh3QpLTQ1dZy4/TilicickEJayJSpjMWB7/6r0PlUGneuqUaN2B2pEvDm5DdCg wehgqHTDwoB8ds8AawuIi9089LEwT2xZywlWq8uPpoYei9I2PqGN9ewV8SzImftWQ5oH RytKQ3hGW7UAIKzpJQtaTe48oYEJ0lQQN+bNv375AiTvOu1OL3kZZYKkVvMvGa//xd/R TiyKufUfRiza8ydfrz1ifJJlnPHSLpmXuZxveTjMcLu7kcBLDwqtth2mG+NbEOEGv3yl llVcJzZBirr94h1mqhdXsAY0c+8nYOdksS9VxhezqfFIqAYKEq1OoRYQx3SNgkBILEvt 8+rA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=IDeYgP2b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id nn10-20020a17090b38ca00b002777ce4c9e6si901223pjb.72.2023.10.18.05.38.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 05:38:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=IDeYgP2b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id D38EA801C023; Wed, 18 Oct 2023 05:38:14 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344066AbjJRMiH (ORCPT + 99 others); Wed, 18 Oct 2023 08:38:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231374AbjJRMiF (ORCPT ); Wed, 18 Oct 2023 08:38:05 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6D9B10E for ; Wed, 18 Oct 2023 05:38:03 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-9be3b66f254so719711566b.3 for ; Wed, 18 Oct 2023 05:38:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697632682; x=1698237482; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3qQmGYMA/S/kWNsfETnUZllqVCQ7paKt7r6KbXhorwY=; b=IDeYgP2bKLi5UkFUhINiGkW8/1DHaVmRTiTGfbQLclEWEbhp52Oil4froQIWvhdG3C 89U7m5AFjicW+P3Rx5zx68UkEfVkjo9wawI3piDhFSvimgslzydOotTe4fxg6junLDpG SVUutXdUA3aefCKdBytEY0BUStAERyOntlhjmdsffKvdDSZUG41EqEl3VLijZYghW4Er /3tpHVPhKOm2hRokdSDW9id1qCrZ/BTFOVEch7bkgzZirzdT1FpMMlmPiz6PsxyFLzwf d5slTF6ygeyh6tQCtE+g5qzXfxsWqsqQiMAHaPnY94g77/J8p4GXJ312ElZEdNASnan8 uLbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697632682; x=1698237482; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3qQmGYMA/S/kWNsfETnUZllqVCQ7paKt7r6KbXhorwY=; b=YjCtP1oiUEyCYijfeRva07515FodS/YjVSek+Jtt7843smBaqX8xPOZtNDR3Tty6tk 0xvWshXpQXmUqNx1HjrkDleAhUEN4u8XDjhGTEeuqtlCmAtcjp/QuQpCC87cfM99OL9/ mZSO6dKdqxWzhaRngZ+izPFIGFzc8PYNVFSAT/dKO5k1l5BGPui7n4SL9ne74/tOUfz4 7qfqDXH910unFFq0B1uyDUDvXhFkg8u02cNyujuaIuwWFWHCDa8USheCu8rYeZD2Z4v9 Uon8KdQO8VyNvWT6eqsfJEj8XXbTB/uy1PoeCv8vMWZhWiVyQBUgeft2xcZzPZHAwLl9 xb2A== X-Gm-Message-State: AOJu0Yzr6HUlKQxuAJ1q+yxt/17UYGdymvTsxEJD+5AgaxPWMtuyspGS 34InyttWz8vPUetMK5cR/zly7A== X-Received: by 2002:a17:907:a42:b0:9bd:f902:9a61 with SMTP id be2-20020a1709070a4200b009bdf9029a61mr4000821ejc.18.1697632682177; Wed, 18 Oct 2023 05:38:02 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.154]) by smtp.gmail.com with ESMTPSA id jz14-20020a17090775ee00b009b27d4153c0sm1620770ejc.178.2023.10.18.05.38.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Oct 2023 05:38:01 -0700 (PDT) Message-ID: <84f9f1c4-0627-4986-8160-b4ab99469b81@linaro.org> Date: Wed, 18 Oct 2023 14:38:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ASoC: codecs: wsa884x: allow sharing reset GPIO Content-Language: en-US To: Mark Brown Cc: Srinivas Kandagatla , Banajit Goswami , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <20231018100055.140847-1-krzysztof.kozlowski@linaro.org> <3aa9e3a7-9417-44b4-87d8-fcf1a8b46daf@sirena.org.uk> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <3aa9e3a7-9417-44b4-87d8-fcf1a8b46daf@sirena.org.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 18 Oct 2023 05:38:15 -0700 (PDT) On 18/10/2023 14:35, Mark Brown wrote: > On Wed, Oct 18, 2023 at 12:00:55PM +0200, Krzysztof Kozlowski wrote: >> On some boards with multiple WSA8840/WSA8845 speakers, the reset >> (shutdown) GPIO is shared between two speakers. Request it as >> GPIOD_FLAGS_BIT_NONEXCLUSIVE to allow such configurations. > >> wsa884x->sd_n = devm_gpiod_get_optional(dev, "powerdown", >> - GPIOD_OUT_HIGH); >> + GPIOD_FLAGS_BIT_NONEXCLUSIVE | GPIOD_OUT_HIGH); > > How do the speakers coordinate? They don't and that's the generic problem of many Linux drivers. Not only this one, but others as well. Device unbind (remove()) or runtime suspend of one speaker will affect other speaker. I don't think any other drivers solved this, because this is rather core's GPIO issue, thus I am not solving it here either. :( Best regards, Krzysztof