Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Wed, 18 Oct 2023 09:00:25 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Saeed Mahameed <saeed@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        linux-kernel@vger.kernel.org, Leon Romanovsky <leonro@nvidia.com>,
        Jiri Pirko <jiri@nvidia.com>,
        Saeed Mahameed <saeedm@nvidia.com>
Subject: Re: [PATCH 0/5] mlx5 ConnectX diagnostic misc driver
Message-ID: <20231018120025.GQ3952@nvidia.com>
References: <20231018081941.475277-1-saeed@kernel.org>
 <2023101858-underwire-donated-3ae9@gregkh>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2023101858-underwire-donated-3ae9@gregkh>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Psdtj9J9wTmHmnLRBBMnr3S91AaLdoF9kJrRHAozUBoZ3DKYfshaMvp+nZyw?=
 =?us-ascii?Q?emzxIuuI0+sWwa894qVJ2KGsGn4twYAbyBIQECSwOY1RoZl5sYoZ2VY6fQbH?=
 =?us-ascii?Q?rL/VcHIp147h0xPJFB4funxP6En+BcFeoJQP7CIRQ4aoiTj35hLdjzaR68Xp?=
 =?us-ascii?Q?frl+V23xGkmRmZZk6lF8NJoiNIebWsuVKGS2vLRJtA6FCmoB1j9kz0sG5y/V?=
 =?us-ascii?Q?CNfwYxIq2lNBAI0/hxGkA2dTvZ8ndncyzrt0BmJDT39bDovanHzdA42O4qfX?=
 =?us-ascii?Q?kUoBQMRoHf+bLJonRPPiDWA6lZjFRVupH4LrcP3xend6pH06EStd1LDTRxjI?=
 =?us-ascii?Q?kysXYIeFgumwusgmkA1tX8fxkHyJfIhoPaqss++u1lpEqzbzeHC6Oji49xb3?=
 =?us-ascii?Q?cvR3B19DhQRxgo275+fLou8jknLKW/5olAPeyKz4mKt2O79C2s8jFtzvsJiU?=
 =?us-ascii?Q?jsEcOXzAOtBAgF5IQ5l/1MzKn9zebwAuDqbGsKno7M2HQN3mmog9nkW7S+Ol?=
 =?us-ascii?Q?+Hb7k0WS13YtS8hKZXC8sCwU1xN+wgNfyYtTTRaKW7IrdkfDexqbUCs898CC?=
 =?us-ascii?Q?yccHNdRNHEyGqhyg0XsI0V+ClbCLwbSnhkkcs1VJl7kV+ARC/Oyaejf6vBLT?=
 =?us-ascii?Q?p5f6mrbsSobmBk8REk4UftQnBUg7aZb3Uxu237mLME/aYmYql5vmmesEtKfY?=
 =?us-ascii?Q?bRknybyjARBZ8ymQ2C+H/g+KUjWlhySb13PyhUV7RLONMUllQfWF1tgj23SN?=
 =?us-ascii?Q?JXL+FhQnRePKUzbh5A9ZyepWIMYB3wn72VLZ0qXz6Fi77Lqj3K3rYsVFZlpD?=
 =?us-ascii?Q?tHEe14M+PfUc8BNf93dsx4/w61tUy/N7hvwlhkq/knrL5JvaLBf7+o6ylAz3?=
 =?us-ascii?Q?T/JyZMVUP4jjX/3LJMvr0ikMj+tC2sbJw7aW3OPlzLYVBFQCBzRuhsiMSzjc?=
 =?us-ascii?Q?yjz8QaRrnCzNrQXlA4ryD+Haq2Rn/2kM4jN1izwphSxcbZnv6694gpcAXI9l?=
 =?us-ascii?Q?h5Or9UaER1cw8wCbx9RHqftmrIf9NJcE8CiiCFPSvCwQqJar4SS76jB31mtZ?=
 =?us-ascii?Q?79QgAyr4I+0h1KJhbwfLclKRQZcYm4ZCvRidyfQK8Kqkrl7PgaQBXMXTFdX5?=
 =?us-ascii?Q?sjmOO9KWXrSagEqgGrArLzicZAXOQl80lHBxKbYDuFtrPq9IX1GMMNi7ceqE?=
 =?us-ascii?Q?SwGg7bBC2zUMOrJOdspq7I3bPX2TZRc7lc7Hez/UaBa+tvAbDep9a18XcSvz?=
 =?us-ascii?Q?AQZV5bxp/hVqmCbMVIr5QWvW3TQ9vpvtZwS2vG3Jairjs6oM669Yx/C5otY4?=
 =?us-ascii?Q?6783WmbaR9uGpzOqHVHoQigrnDtnZ5B4Z2eJDgw41l8u0UC56Dkia0gi29lH?=
 =?us-ascii?Q?0ynkdhX17bI71oA1GViv1Ym3811Qrh8Ay1oiCvsGBZJtsRWpXydvhXnTWbs1?=
 =?us-ascii?Q?g44WbI7QgE99gouWJJPDwgJbDwIkbGKBXzfCiWNsJ11rMuzwCYwkxw9TWvOF?=
 =?us-ascii?Q?dXE6buktguBiMx46d8CouDA5qQPjOFMt4+o0ExJEf1IyBc7KO1FKXVkP1vzP?=
 =?us-ascii?Q?JbAGDco5qFUba+lH8HXl4/S5IImMtMGg+t/p6Xso?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d207c14f-8bfc-4365-8282-08dbcfd1d26a
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 12:00:28.9985
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OfHV8XuS/Fg70YbeQsPRJVSh+W+myxsOLQTLdF5GToXWIFgdeF+dfi6ON/mCAL9a
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6738
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 18 Oct 2023 05:39:59 -0700 (PDT)

On Wed, Oct 18, 2023 at 10:31:23AM +0200, Greg Kroah-Hartman wrote:
> On Wed, Oct 18, 2023 at 01:19:36AM -0700, Saeed Mahameed wrote:
> > Historically a userspace program was used that accessed the PCI register
> > and config space directly through /sys/bus/pci/.../XXX and could operate
> > these debugging interfaces in parallel with the running driver.
> > This approach is incompatible with secure boot and kernel lockdown so this
> > driver provides a secure and restricted interface to that.
> 
> Why not just write a UIO driver for this hardware then?

The old mechanism relied on direct config space and sometimes mmio
access to the PCI device. We did a security analysis and concluded
that approach could not provide the required security for what our
customers want from the secure boot and lockdown modes. We cannot
allow a lockdown userspace direct access to those device registers.

So, it was redesigned to be RPC driven instead of having direct HW
access. The RPCs allow the device to provide the required level of
security.

This new misc driver does not expose any HW registers or interrupts to
userspace, so it does not seem like a fit for UIO.

Jason