Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3771850rdg; Wed, 18 Oct 2023 05:53:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF2NRU4A/shA9XLuNqD4ZXmWnDMTkfe5YtxKMV7eLH+VSx6R4owTfGpWUltNnrIdn52Gsx8 X-Received: by 2002:a17:903:11cc:b0:1c9:e48c:7266 with SMTP id q12-20020a17090311cc00b001c9e48c7266mr6471581plh.57.1697633603409; Wed, 18 Oct 2023 05:53:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697633603; cv=none; d=google.com; s=arc-20160816; b=DwpmDmBagt0cG2YGn4p65EnqtsKLx1Xr1XC/Guhu7jVxFMsSJhT3WX/T0Csf8xRD07 BVzwKJHu9cCmZxlQekUaMu3gDsuB7a4ulYXUPiA2lKBn8WWNFF32Ny/Uc81YbQIEzMn9 rwn+/8UMZ+4BmDEDmyczudoA/7hQfIPrLKAN9zKHAzlr2vhWWJNswoB/F2EGNyr8QXls QkphfCyGULKkavUn8H/SAA/Bj+JYPy9AJM3tj0QJneQ+OVjaSqMEcv5DRKrlDTay5AaO cJCVMXfZzgR5eg+YTDgn6w/7KEQXdbC+uNNwmbCfpYXsWeFxhBnCk63ey1baa+DWhFDI MGOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=V4bV1pYZhN5D0dbLwFy/u3ve1RaIEgwcUfBCkqo2+yE=; fh=1iQk4GHn6YIIVplbdlRDhDLSiayvmkg4vOn9VfOKq5I=; b=inFBU9DsS6xR39RgWqm3lVlZXWcKXeK1Q+59Z1KNPjpdjB8GseUb3rc5SOARbp7b5d 1cv2jgvOH5hNeV/6KPhIZCXDigwK/lwXAh90PFoJr6K8/sa7XbU5DdqtZmQNi0wi0rWB Jr82WBCj3VjgGWlwAL9f2OwqgcWmc5DaUxkToUixPYg31EaLx007IzoH7RxSpEqtgLVT 5Kn9zDFdY5ZzWLcZYiSETcElppk6hgcXZZLIybq859wjWZc8S2YWo8vsnRu89vipiMFw utA6gQ73b4FJAOxY4cU1w6SB5AprRtlM7FEI6CTPHmorsaMdsWZQPYriAxw/BdMZhuc0 Ki4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=RDwVreNM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id 10-20020a170902c14a00b001c5ff477ebcsi278116plj.265.2023.10.18.05.53.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 05:53:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=RDwVreNM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id F422580D7548; Wed, 18 Oct 2023 05:53:20 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231124AbjJRMxO (ORCPT + 99 others); Wed, 18 Oct 2023 08:53:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230492AbjJRMxM (ORCPT ); Wed, 18 Oct 2023 08:53:12 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB258A3 for ; Wed, 18 Oct 2023 05:53:09 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1ca85ff26afso5598515ad.1 for ; Wed, 18 Oct 2023 05:53:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1697633589; x=1698238389; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=V4bV1pYZhN5D0dbLwFy/u3ve1RaIEgwcUfBCkqo2+yE=; b=RDwVreNMpjT2BzmCZS/supJ+Z14aNLOcz3x7dq+Dm9ZrX6p4lJOFnLU2Xbcu334/ZB sTpF4Ypq6yva4/WLspPPoyhseEYolAHNHHh026LyhssQovjzW8aeWmV+zhNQ2aAQJHwK zOq5IQuFiGSZxm7G6+5qW5Zggh0VPVQHBKm0o2+Tvtux3SObYibYWmtLFFVmrcegMT3r ZhkfQ1tDdULOZxTwc/9nDZ2u18FZcnFAQJYHpqVCdAIHGy7HLXDfNcgS20Nws6P4VU4Q kbpigX19nWYphmVducjum0e6OOLNo+KLlrH5FtTWoWw1/tXXuKeiFN9dM60v8g0hX3OY izjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697633589; x=1698238389; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=V4bV1pYZhN5D0dbLwFy/u3ve1RaIEgwcUfBCkqo2+yE=; b=SE1Krk6wibaxV0jwJpAvUDY6ar/XuUptI5MZXev+zyvkGDLp+uUnMULKE151DoFKxa bB5+hDFEpbTICk3W4LLsxbnkv5IBlBcXKm7J8GZcI8Le+ELx5VGvu3FLv0pg5weEUUdf PvbUm7DxOXig6GRuYEmZlijuKwI1+SP78HomcG+ZvQM0T+6g7K8y4sIVsOuCOEPPq3Vy /UhQWI54YjBKXmUEdz5dxbMm+RkD+EDya+txQsOb0dsMNdbLw8zMOT+vQpZdzH96jJA4 0KVAU9Mx0OUsjpcC7x3UYWUndmht0ibFKZjkbFWJRRUzggQsjxuBZcDAcUrH1NOA+nls SixQ== X-Gm-Message-State: AOJu0Yxem7U0/b0RmiJTGd9e4CEaIH5OaZFKYQ+ie6kWYHR+4jfq9IZb AwcxUoMh7FqZFif9/nYks0Jc4A== X-Received: by 2002:a17:902:f154:b0:1bf:349f:b85c with SMTP id d20-20020a170902f15400b001bf349fb85cmr5148024plb.1.1697633589226; Wed, 18 Oct 2023 05:53:09 -0700 (PDT) Received: from ?IPV6:2a01:e0a:999:a3a0:fde2:480:5b62:f2d2? ([2a01:e0a:999:a3a0:fde2:480:5b62:f2d2]) by smtp.gmail.com with ESMTPSA id p9-20020a170902bd0900b001b8b2b95068sm3437763pls.204.2023.10.18.05.53.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Oct 2023 05:53:08 -0700 (PDT) Message-ID: Date: Wed, 18 Oct 2023 14:52:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 05/19] riscv: add ISA extension parsing for vector crypto extensions To: Jerry Shih Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Palmer Dabbelt , Paul Walmsley , Rob Herring , Krzysztof Kozlowski , Albert Ou , Jonathan Corbet , Andrew Jones , Evan Green , Conor Dooley , Samuel Ortiz References: <20231017131456.2053396-1-cleger@rivosinc.com> <20231017131456.2053396-6-cleger@rivosinc.com> Content-Language: en-US From: =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 18 Oct 2023 05:53:21 -0700 (PDT) On 18/10/2023 03:45, Jerry Shih wrote: > On Oct 17, 2023, at 21:14, Clément Léger wrote: >> @@ -221,6 +261,22 @@ const struct riscv_isa_ext_data riscv_isa_ext[] = { >> __RISCV_ISA_EXT_DATA(zkt, RISCV_ISA_EXT_ZKT), >> __RISCV_ISA_EXT_DATA(zksed, RISCV_ISA_EXT_ZKSED), >> __RISCV_ISA_EXT_DATA(zksh, RISCV_ISA_EXT_ZKSH), >> + __RISCV_ISA_EXT_DATA(zvbb, RISCV_ISA_EXT_ZVBB), >> + __RISCV_ISA_EXT_DATA(zvbc, RISCV_ISA_EXT_ZVBC), >> + __RISCV_ISA_EXT_DATA(zvkb, RISCV_ISA_EXT_ZVKB), > > The `Zvkb` is the subset of `Zvbb`[1]. So, the `Zvkb` should be bundled with `Zvbb`. Hi Jerry, Thanks for catching this, I think some other extensions will fall in this category as well then (Zvknha/Zvknhb). I will verify that. Clément > > + __RISCV_ISA_EXT_DATA(zvbb, RISCV_ISA_EXT_ZVBB), > + __RISCV_ISA_EXT_DATA(zvbb, RISCV_ISA_EXT_ZVKB), > + __RISCV_ISA_EXT_DATA(zvkb, RISCV_ISA_EXT_ZVKB), > > or > > + __RISCV_ISA_EXT_BUNDLE(zvbb, riscv_zvbb_bundled_exts), > + __RISCV_ISA_EXT_DATA(zvkb, RISCV_ISA_EXT_ZVKB), > > [1] > https://github.com/riscv/riscv-crypto/blob/main/doc/vector/riscv-crypto-vector-zvkb.adoc > > -Jerry