Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Borislav Petkov <bp@alien8.de>
Cc:     LKML <linux-kernel@vger.kernel.org>, x86@kernel.org
Subject: Re: [patch V5 03/39] x86/boot/32: De-uglify the 2/3 level paging
 difference in mk_early_pgtbl_32()
In-Reply-To: <20231018100023.GAZS+st5ePdAQjnO4z@fat_crate.local>
References: <20231017200758.877560658@linutronix.de>
 <20231017211722.111059491@linutronix.de>
 <20231018100023.GAZS+st5ePdAQjnO4z@fat_crate.local>
Date:   Wed, 18 Oct 2023 15:20:10 +0200
Message-ID: <87mswg3w51.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Wed, Oct 18 2023 at 12:00, Borislav Petkov wrote:
> On Tue, Oct 17, 2023 at 11:23:26PM +0200, Thomas Gleixner wrote:
>> Move the ifdeffery out of the function and use proper typedefs to make it
>> work for both 2 and 3 level paging.
>> 
>> No functional change.
>> 
>> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>> ---
>> V5: New patch
>> ---
>>  arch/x86/kernel/head32.c |   38 +++++++++++++++++++++-----------------
>>  1 file changed, 21 insertions(+), 17 deletions(-)
>> 
>> --- a/arch/x86/kernel/head32.c
>> +++ b/arch/x86/kernel/head32.c
>> @@ -71,39 +71,43 @@ asmlinkage __visible void __init __noret
>>   */
>>  void __init mk_early_pgtbl_32(void);
>
> Lemme zap that forward declaration too - it looks redundant.

Up to the point where the compiler complains about a missing prototype
for a global visible function, which will bring it back faster than you
think. :)