Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3811323rdg; Wed, 18 Oct 2023 06:52:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGwD92C2GyVtmayslypRKqCo+4tWmYdVE4cyPKjlUFeaka75LDhLHCSTvnFOa6o3DBFOoZD X-Received: by 2002:a17:903:706:b0:1ca:57ff:9bfa with SMTP id kk6-20020a170903070600b001ca57ff9bfamr5094306plb.24.1697637158222; Wed, 18 Oct 2023 06:52:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697637158; cv=none; d=google.com; s=arc-20160816; b=HyA8o+/vJ+l6bVRAMk42ChydyJmekqHl4kWx6zmRq+W1RGtX4sp4FOmICfHdC27FTL PvicQCRFlI9TJgx6ftJU0Ph1EYcheKIVkDmAJDvifBhSyNeSxayVujigXaMNs2ec6mbE rOU1N/Zx+o9+2ZtMvPh7izHA34Yur8jCKzIPHl+z8KqmxBv5FU6duceLpsllpZ7X9/rA pFwKH/vFU4jUfOTj3Ze4EfJozEqnL/V6kbTJysVTyQrofBXihEJ5tTzM8xPBMKLBpuK7 9GWFa6tVkVVff1dUUfvCfkq9ijn2lv/Hmlnj7zpUVeXbdESS4QWU78MBtrWp9iSfOgRk 3e+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=FdEYSYjG4ZKvYIgWik6Qccu5qbaJWDMQPQmaZCqZ2qw=; fh=4q9CZrcR8TtLcnibTbNJO1De+d1/wONI6jmVc5t4Yxo=; b=CD+eEqbNxwjZ2ZElad8/furoz0I8JuMc5TQDQd5gKP2JIapTayHEDegQifI7IBecQQ R+HO6x1BtXaiEUyzTX/Z1XognAJHzejwCdNXwAKVDKFHKJ+AkQQ7/AJ6y8FsAU0UJwCr koQw93fH7bHIo0m0gyXVS2dfh5DUIZe1iUPdOCYWwD/DacXbvNBL/CZ+57lTvZ1NAX0U 0zLq81nJECgSX9rCiB7smGtZNnqUwtR//MdnM394nsx80qtf+KblIKDvI76t4N5ZcoC/ CDzetasRzU9LMLdxgW7XwGk0ApKH75hMy3DM9I4MDZ9zkla92Az2Ww5T3bD5PZ3i0opI xHlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SYGuBX65; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id k1-20020a170902c40100b001c43cd8b2d5si4577375plk.592.2023.10.18.06.52.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 06:52:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SYGuBX65; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 5E0588129E2F; Wed, 18 Oct 2023 06:52:37 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344736AbjJRNwf (ORCPT + 99 others); Wed, 18 Oct 2023 09:52:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231821AbjJRNwe (ORCPT ); Wed, 18 Oct 2023 09:52:34 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DDAA106 for ; Wed, 18 Oct 2023 06:52:33 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C148C433C8; Wed, 18 Oct 2023 13:52:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697637152; bh=K1Dhr3hZfDVKtLxR/ZTMbEg+7QkrSlzrgGTTVTTgxu8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SYGuBX65JLvJBpr6PoUDf/vrBelz9XtdvhtAQuC9ozyy4EobVjTTGfLCyklF7g6/r Pm9jNWxk2xpe6nQy6K9sh4fUiqVrf8x03esnGFS6i5bBKYJ/NKQQp0a6fxrW9YLngR 2bLCiHk7zCl3NuWfBEyXCNGp2cIWJYl8f3Umti3RVzfk1EDih8PiEfpUWFJ4jyDIDM aniznZKREE9mQqpXk4Kv2rDXyzmspKhcmLM6oOiMT0CEw4fgHwBtokHsx4YMeZAdDh riB7FfryMlC/QSBJV639ZkFJMNGN74o4ebqWGDQMwxbE6Wmqba0+jXM823rGfYPnun Whc+m+nZlxYLw== Date: Wed, 18 Oct 2023 15:52:28 +0200 From: Simon Horman To: Florian Fainelli Cc: netdev@vger.kernel.org, Justin Chen , Andrew Lunn , Broadcom internal kernel review list , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , open list Subject: Re: [PATCH net v2] net: phy: bcm7xxx: Add missing 16nm EPHY statistics Message-ID: <20231018135228.GP1940501@kernel.org> References: <20231017205119.416392-1-florian.fainelli@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231017205119.416392-1-florian.fainelli@broadcom.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 18 Oct 2023 06:52:37 -0700 (PDT) On Tue, Oct 17, 2023 at 01:51:19PM -0700, Florian Fainelli wrote: > The .probe() function would allocate the necessary space and ensure that > the library call sizes the nunber of statistics but the callbacks > necessary to fetch the name and values were not wired up. > > Reported-by: Justin Chen > Fixes: f68d08c437f9 ("net: phy: bcm7xxx: Add EPHY entry for 72165") > Reviewed-by: Andrew Lunn > Signed-off-by: Florian Fainelli Reviewed-by: Simon Horman