Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3816335rdg; Wed, 18 Oct 2023 07:01:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH1AnvNfKzFve+qjiksB6Xk/DMufIbUYLtRmS9GKLDxCoHhb5MFuYFZEpo74LdAQlJ+IPum X-Received: by 2002:a05:6a00:2d27:b0:6bd:f224:c79e with SMTP id fa39-20020a056a002d2700b006bdf224c79emr5974385pfb.11.1697637676897; Wed, 18 Oct 2023 07:01:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697637676; cv=none; d=google.com; s=arc-20160816; b=GYwDRTzTa7ERDxHYl8/+2hp8uCKwipWoVRl8/TSNajOdyJkJp2g/dcApQFkcIIX6KV i9AgsJrsWNxbWCcUaJPg2QcMuNtAsBReojr2iKzprUqyqHKT5/+KmCjKvoKeOa3uHXaB AwEtxxyKfD+zRpO0wH+NTQ9qf5B98I+TQsOSjrd4atUDgcA8m3r0ZFRPaNRKqwhV961y o7GuGM+cLEkV2g+G04EVoGPCRn5Hm+EHTqoqiYZ+gHncXFRVnmRlSLy3ucICtSsNxPcU e1D8g22KAnGM791X0QwIJDZ7vd1EQMrU/gnKIIccmL6t5X6X3efBsrEvaJkNn5GVceEZ YF+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=WSpW0doOcXn+5lTEk2bF0qorpVq0IOpiC8aimltnNyc=; fh=NmUDQO+CzZi6xhg3l1t4amXpOKzhqW7vJEMbk9HzHVc=; b=Sx9sjrOEuWQmXEGlZtztdXR0DOLJNpsG5cc8SbELwfqt8alo/BhSrl9E/ndBkL7b9G 1ncYMAV3PSq3XnQtTl1B8EyvJ5dCN9kM8fKQcUbNeEfFWN8RSyC371OQqVP0+W5c5erC s3l41ZSCWjucxYbJQ2EZEPlIJYpbkhnCHlQ+OArm3xnHCPSiNMDMUQWESk3xhMxg+5TX 9RuNnMwk9aX2LqtvofkBwTLQjuCzjvXJLxPdyX/YHY4zJyLuwDZC4zKb7qbygImfH9Yb 8oWxo8bp/0djcdKIc6tgNb1KuzCNYctr+tAXr8SY04SWu//l+l/Muag6fD4TJWS4UhGK JNjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ZdmVd3MD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id fc14-20020a056a002e0e00b006933e57dde4si4216781pfb.0.2023.10.18.07.01.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 07:01:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ZdmVd3MD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id B1C4A809C65D; Wed, 18 Oct 2023 07:01:10 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231849AbjJROAz (ORCPT + 99 others); Wed, 18 Oct 2023 10:00:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231822AbjJROAy (ORCPT ); Wed, 18 Oct 2023 10:00:54 -0400 Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDCCC106 for ; Wed, 18 Oct 2023 07:00:51 -0700 (PDT) Received: by mail-ot1-x32f.google.com with SMTP id 46e09a7af769-6c49f781855so4503927a34.3 for ; Wed, 18 Oct 2023 07:00:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697637651; x=1698242451; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WSpW0doOcXn+5lTEk2bF0qorpVq0IOpiC8aimltnNyc=; b=ZdmVd3MDe1hquHpYx8DRza3mYM5v0ZruXN7tnsaOiVvpivsUuOBO80fHp5lOKe9QM2 Q6BfTYENDRxvmswl4pjuUlRzS/jil+/Ad4aSerWuNTka/+5O+CYZQ++/S64F9XGmZUS7 Ku55RDrp9/LdeW1Tx/Tgjpf6m9vYSo4KoEZjiaKbx+SzJiIgBJgfPFRpUYaDtUQ0G5tJ uD+A+TrWfM2Xa3DHrElOBDj2fODQOUKTqPks+944v/0wdgLFRmonGPUchYYM+4yJ3vD8 aSTTU028SjpsiU79NmTumobxBLNZVgq6Id6UaqjHptKK567najqdjlyRqw6p8jIlbuAN 9d4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697637651; x=1698242451; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WSpW0doOcXn+5lTEk2bF0qorpVq0IOpiC8aimltnNyc=; b=gnkPff1qm28ET0Q3faTbI9bxlVxFRIqJMxRrlVGM/8kADKFAca2c39vFsx85uzGFdu Dbx8C88OkIrQWq7cHuZtQF1lcJQDsO7KjGHPij/O8hZu7moymTvbjefgAp+uYanccuP3 jY1v1tUrjHESX0QXH8fDHpFFFMiIsKwu9I6MyVkgO6jyWjBKuF25RcdvKmZ6FZpdrxhu +pl+SWEK/WO9ScoCD3PcjUBbEL5aM6EX9tvCyMMwiZuvh84T9+EystqtmnsrBwMQGsWY p+VTEqUZ5YzI2nbxyTCtORoBc1cAw25o8s3leec83/JaAYdTKyBiusuPCpUCzH0yLId6 UbeA== X-Gm-Message-State: AOJu0YxkYExaBIA8j6DTYDEQdQEjoQMiRNxuoF4vVU3W4rnU4XxbqiSM iuKsG28/iDoJGWEK/RSnECJgiPFMeCrEQT8sn7c= X-Received: by 2002:a05:6871:8784:b0:1e9:bd5c:ae40 with SMTP id td4-20020a056871878400b001e9bd5cae40mr5801664oab.38.1697637650989; Wed, 18 Oct 2023 07:00:50 -0700 (PDT) MIME-Version: 1.0 References: <20231018012232.23995-1-yang.lee@linux.alibaba.com> In-Reply-To: <20231018012232.23995-1-yang.lee@linux.alibaba.com> From: Alex Deucher Date: Wed, 18 Oct 2023 10:00:39 -0400 Message-ID: Subject: Re: [PATCH -next] drm/amd/display: Simplify bool conversion To: Yang Li Cc: alexander.deucher@amd.com, harry.wentland@amd.com, airlied@gmail.com, daniel@ffwll.ch, Abaci Robot , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 18 Oct 2023 07:01:11 -0700 (PDT) Applied. Thanks! On Tue, Oct 17, 2023 at 9:22=E2=80=AFPM Yang Li wrote: > > ./drivers/gpu/drm/amd/display/dc/dml2/display_mode_core.c:4802:84-89: WAR= NING: conversion to bool not needed here > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=3D6901 > Signed-off-by: Yang Li > --- > drivers/gpu/drm/amd/display/dc/dml2/display_mode_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dml2/display_mode_core.c b/dr= ivers/gpu/drm/amd/display/dc/dml2/display_mode_core.c > index 851db026f251..3296c078ff3e 100644 > --- a/drivers/gpu/drm/amd/display/dc/dml2/display_mode_core.c > +++ b/drivers/gpu/drm/amd/display/dc/dml2/display_mode_core.c > @@ -4799,7 +4799,7 @@ static void CalculateSurfaceSizeInMall( > if (UseMALLForStaticScreen[k] =3D=3D dml_use_mall_static_= screen_enable) > TotalSurfaceSizeInMALL =3D TotalSurfaceSizeInMALL= + SurfaceSizeInMALL[k]; > } > - *ExceededMALLSize =3D (TotalSurfaceSizeInMALL <=3D MALLAllocatedF= orDCN * 1024 * 1024 ? false : true); > + *ExceededMALLSize =3D (TotalSurfaceSizeInMALL > MALLAllocatedForD= CN * 1024 * 1024); > } // CalculateSurfaceSizeInMall > > static void CalculateDETBufferSize( > -- > 2.20.1.7.g153144c >