Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <1b03f355170333f20ee20e47c5f355dc73d3a91c.camel@linaro.org>
Subject: Re: [PATCH v2] Revert "fuse: Apply flags2 only when userspace set
 the FUSE_INIT_EXT"
From:   =?ISO-8859-1?Q?Andr=E9?= Draszik <andre.draszik@linaro.org>
To:     Bernd Schubert <bschubert@ddn.com>
Cc:     Miklos Szeredi <mszeredi@redhat.com>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Date:   Wed, 18 Oct 2023 15:26:01 +0100
In-Reply-To: <fa3510f3-d3cc-45d2-b38e-e8717e2a9f83@ddn.com>
References: <20230904133321.104584-1-git@andred.net>
         <20231018111508.3913860-1-git@andred.net>
         <717fd97a-6d14-4dc9-808c-d752d718fb80@ddn.com>
         <4b0b46f29955956916765d8d615f96849c8ce3f7.camel@linaro.org>
         <fa3510f3-d3cc-45d2-b38e-e8717e2a9f83@ddn.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4-1 
MIME-Version: 1.0
Precedence: bulk

On Wed, 2023-10-18 at 11:52 +0000, Bernd Schubert wrote:
> On 10/18/23 13:46, Andr=C3=A9 Draszik wrote:
> > On Wed, 2023-10-18 at 11:39 +0000, Bernd Schubert wrote:
> > > On 10/18/23 13:15, Andr=C3=A9 Draszik wrote:
> > > > From: Andr=C3=A9 Draszik <andre.draszik@linaro.org>
> > > >=20
> > > > This reverts commit 3066ff93476c35679cb07a97cce37d9bb07632ff.
> > > >=20
> > > > This patch breaks all existing userspace by requiring updates
> > > > as
> > > > mentioned in the commit message, which is not allowed.
> > > >=20
> > > > Revert to restore compatibility with existing userspace
> > > > implementations.
> > >=20
> > > Which fuse file system does it exactly break? In fact there
> > > haven't
> > > been
> > > added too many flags after - what exactly is broken?
> >=20
> > The original patch broke the existing kernel <-> user ABI by now
> > requiring user space applications to pass in an extra flag.
> > There are various side-effects of this, like unbootable systems,
> > just
> > because the kernel was updated.
> > Breaking the ABI is the one thing that is not allowed. This is not
> > specific to any particular fuse file system.
>=20
> How exactly did it break it?

At least in Android, creating new files, or reading existing files
returns -EFAULT

>  These are feature flags - is there really a=20
> file system that relies on these flag to the extend that it does not=20
> work anymore?

I don't know enough about the implementation details, but even outside
Android user space had to be updated as a prerequisite for this kernel
patch:
https://lore.kernel.org/all/YmUKZQKNAGimupv7@redhat.com/
https://github.com/libfuse/libfuse/pull/662

Which means any non-Android user space predating those changes isn't
working anymore either.


Cheers,
Andre