Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3843536rdg; Wed, 18 Oct 2023 07:38:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF+z+3aG05Dc2H8X+Pi6sGOc7aJwjQ3EHRNc51MJ1EzDFjaerfCbiyWPRq2/eNIOoOhzDr4 X-Received: by 2002:a05:6a20:3d8f:b0:151:577:32d1 with SMTP id s15-20020a056a203d8f00b00151057732d1mr6205172pzi.22.1697639891451; Wed, 18 Oct 2023 07:38:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697639891; cv=none; d=google.com; s=arc-20160816; b=kRujtTCsODb1q4ciUyNU9trVhguUqN9RWTshw0krDfs0KMSAq+Xbi27lQa/9uWUPrW blHV+k7j2vI3OOZxLRL9T0bmkfAzxC+941gWpAfeHJUpBIJlOiJWnLkUsWQWtWcl4jHN oXShxb0R60K/kHzWr3osTbDE92Pw7VrGYkhvjCj0LRbbGr4y+8x98HVvO0WN91zQtz2m 2Y0Hfs8igZTuGtvFeYqLtNniC4lCao03i/L1JbVKH5LaJnsjNheagumWXckBkZnY7433 E8C5CyKoXIdvLqAc3uH6eDBZpM6YkdWywtuwMQeAXCt0hxAX794IiiaPCLkkYi/Plyu2 DSng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=2MBHQrqw55UjZKvbwXO22BYYyiwvKly9qhomQTJhZaA=; fh=K4HQFaZZf9kbo1THYS+KC4BixXvd2pueqH3CKF3vOzQ=; b=gYCS/HpGZRgsDVf3Ow2EnxJ86XDEqlQfI5znlJsX9BYlJ19fvHfMtSjGZoJ5cJAUE5 sdPlB+IX03TNaCeHKytBvSWS63UGzxx3D0KdxDV5Rk4MIfjbXMAoiMoTUN5lE/pirZL5 PfAPyuhzHYl2v2s1CI5ZbNBAy50NTZlOv6cPvsUg/Jvmxay2yV5Klpl9B1RopQaQoN2t y66Rj9amW9Q9GK4XuyEFM92EXjVOuzHkF9mFxEBZLEIpjuxr/YG7k0R2uTJWZbO10yHr j0zAipLd7QmrqTYl/fhq3PubZBHYeSA63L8MGNUFNpahOGu+0HdfQGjS7bgZmXDGNAza lHlw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=LTMWXsZl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id f22-20020a633816000000b00577516d9a0bsi2229383pga.502.2023.10.18.07.38.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 07:38:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=LTMWXsZl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 62EB781DAAFE; Wed, 18 Oct 2023 07:38:08 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235309AbjJROiA (ORCPT + 99 others); Wed, 18 Oct 2023 10:38:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235304AbjJROhp (ORCPT ); Wed, 18 Oct 2023 10:37:45 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E7B619B1 for ; Wed, 18 Oct 2023 07:36:46 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-6b7f0170d7bso4304630b3a.2 for ; Wed, 18 Oct 2023 07:36:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697639805; x=1698244605; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2MBHQrqw55UjZKvbwXO22BYYyiwvKly9qhomQTJhZaA=; b=LTMWXsZl7ZntBnZCC20Xjrfk97Cer1rljgImGjSohvVcKcqOzpavBwYWbDUK/Z1pD8 GLcnCVSpUHFD216IF7rW2dyB5paHXnU3vFxaRW4b+izaVroXTCEeAQSmOqSJbvkhrM+h TkgcawNdYyafPNVBoWurEf3lsVP9zFYilePp2ByvmgzLJVgfUAIr8WBhkLJrOayqwzg7 AY6CO4x03493qQalC6nr3+J22fKNB6JAxlMvNLE6EbnpRZ7R14vjrgXaTVfEPkwdpWBk jBh0fVEoc5IqGa8WRf+JhNxoRmUbgCvQfVHnNglD/TMPRW76tyNxcJkRmM1TG7JQ7T/3 5y6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697639805; x=1698244605; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2MBHQrqw55UjZKvbwXO22BYYyiwvKly9qhomQTJhZaA=; b=hcTeDFnjRpsCuPi2Eit1LYYhwo7hWrYlYFPPKtNe/y29461YQX5J/bOlznK0zGZLje fzmOdhetIhim6Qxjc85rbVWQj4RhZ3O3vaeoN819afpfS9js6Ce+JoaS3yd4G+8hTh9g 7Xd1YvHjko3h0RgdZdH5WZtXVxcS7U2xv0SZXlBMyj3W1MKBN/DjImLQ5B0rxVLoGf+O RddvjhIp6FnD8GtNrfUWgHonhHTimxf3/vXg/Xvt99W1LSLLYlkIP+ODUIX76ibdRS+h Ux3JXnX66qfzfTN44U87fXwQLIMiZMC9L0aFI3XPAmNJDolAnqpjJkCw1ECDo9qAMMhH xqIQ== X-Gm-Message-State: AOJu0YxsAKTTw6911Adiak/1iC1XJHXeoR7lM0mAeIURSF52vYOx7rMF XUj/bmQzcxT3wypTf0KN484= X-Received: by 2002:a05:6a20:9155:b0:15f:faab:1be1 with SMTP id x21-20020a056a20915500b0015ffaab1be1mr5760804pzc.20.1697639805239; Wed, 18 Oct 2023 07:36:45 -0700 (PDT) Received: from [192.168.1.13] ([27.4.124.129]) by smtp.gmail.com with ESMTPSA id r13-20020a6560cd000000b005aa800c149bsm1604838pgv.39.2023.10.18.07.36.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Oct 2023 07:36:44 -0700 (PDT) Message-ID: Date: Wed, 18 Oct 2023 20:06:40 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/nouveau: Fixing indentation and adding License Identifier tag Content-Language: en-US To: kherbst@redhat.com, lyude@redhat.com, dakr@redhat.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20231008172751.21953-1-bragathemanick0908@gmail.com> From: Bragatheswaran Manickavel In-Reply-To: <20231008172751.21953-1-bragathemanick0908@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 18 Oct 2023 07:38:08 -0700 (PDT) On 08/10/23 22:57, Bragatheswaran Manickavel wrote: > On running checkpatch.pl to nouveau_drm.h identified > few warnings. Fixing them in this patch > > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 > +/* > > WARNING: space prohibited between function name and open parenthesis '(' > +#define DRM_IOCTL_NOUVEAU_CHANNEL_FREE DRM_IOW (DRM_COMMAND_BASE + > DRM_NOUVEAU_CHANNEL_FREE, struct drm_nouveau_channel_free) > > Signed-off-by: Bragatheswaran Manickavel > --- > include/uapi/drm/nouveau_drm.h | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/include/uapi/drm/nouveau_drm.h b/include/uapi/drm/nouveau_drm.h > index 8d7402c13e56..900ca4f1ebe5 100644 > --- a/include/uapi/drm/nouveau_drm.h > +++ b/include/uapi/drm/nouveau_drm.h > @@ -1,3 +1,4 @@ > +/* SPDX-License-Identifier: MIT */ > /* > * Copyright 2005 Stephane Marchesin. > * All Rights Reserved. > @@ -448,15 +449,15 @@ struct drm_nouveau_svm_bind { > > #define DRM_IOCTL_NOUVEAU_GETPARAM DRM_IOWR(DRM_COMMAND_BASE + DRM_NOUVEAU_GETPARAM, struct drm_nouveau_getparam) > #define DRM_IOCTL_NOUVEAU_CHANNEL_ALLOC DRM_IOWR(DRM_COMMAND_BASE + DRM_NOUVEAU_CHANNEL_ALLOC, struct drm_nouveau_channel_alloc) > -#define DRM_IOCTL_NOUVEAU_CHANNEL_FREE DRM_IOW (DRM_COMMAND_BASE + DRM_NOUVEAU_CHANNEL_FREE, struct drm_nouveau_channel_free) > +#define DRM_IOCTL_NOUVEAU_CHANNEL_FREE DRM_IOW(DRM_COMMAND_BASE + DRM_NOUVEAU_CHANNEL_FREE, struct drm_nouveau_channel_free) > > #define DRM_IOCTL_NOUVEAU_SVM_INIT DRM_IOWR(DRM_COMMAND_BASE + DRM_NOUVEAU_SVM_INIT, struct drm_nouveau_svm_init) > #define DRM_IOCTL_NOUVEAU_SVM_BIND DRM_IOWR(DRM_COMMAND_BASE + DRM_NOUVEAU_SVM_BIND, struct drm_nouveau_svm_bind) > > #define DRM_IOCTL_NOUVEAU_GEM_NEW DRM_IOWR(DRM_COMMAND_BASE + DRM_NOUVEAU_GEM_NEW, struct drm_nouveau_gem_new) > #define DRM_IOCTL_NOUVEAU_GEM_PUSHBUF DRM_IOWR(DRM_COMMAND_BASE + DRM_NOUVEAU_GEM_PUSHBUF, struct drm_nouveau_gem_pushbuf) > -#define DRM_IOCTL_NOUVEAU_GEM_CPU_PREP DRM_IOW (DRM_COMMAND_BASE + DRM_NOUVEAU_GEM_CPU_PREP, struct drm_nouveau_gem_cpu_prep) > -#define DRM_IOCTL_NOUVEAU_GEM_CPU_FINI DRM_IOW (DRM_COMMAND_BASE + DRM_NOUVEAU_GEM_CPU_FINI, struct drm_nouveau_gem_cpu_fini) > +#define DRM_IOCTL_NOUVEAU_GEM_CPU_PREP DRM_IOW(DRM_COMMAND_BASE + DRM_NOUVEAU_GEM_CPU_PREP, struct drm_nouveau_gem_cpu_prep) > +#define DRM_IOCTL_NOUVEAU_GEM_CPU_FINI DRM_IOW(DRM_COMMAND_BASE + DRM_NOUVEAU_GEM_CPU_FINI, struct drm_nouveau_gem_cpu_fini) > #define DRM_IOCTL_NOUVEAU_GEM_INFO DRM_IOWR(DRM_COMMAND_BASE + DRM_NOUVEAU_GEM_INFO, struct drm_nouveau_gem_info) > > #define DRM_IOCTL_NOUVEAU_VM_INIT DRM_IOWR(DRM_COMMAND_BASE + DRM_NOUVEAU_VM_INIT, struct drm_nouveau_vm_init) A Gentle remainder. Can someone please help in reviewing these changes ? Thanks, Bragathe