Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
From:   Francis Laniel <flaniel@linux.microsoft.com>
To:     Masami Hiramatsu <mhiramat@kernel.org>
Cc:     Steven Rostedt <rostedt@goodmis.org>, linux-kernel@vger.kernel.org,
        linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/1] tracing/kprobes: Return EADDRNOTAVAIL when func matches several symbols
Date:   Wed, 18 Oct 2023 17:43:36 +0300
Message-ID: <12305596.O9o76ZdvQC@pwmachine>
In-Reply-To: <20231018153020.fac28cf4381b57e179104b02@kernel.org>
References: <20230824160859.66113-1-flaniel@linux.microsoft.com> <2696412.mvXUDI8C0e@pwmachine> <20231018153020.fac28cf4381b57e179104b02@kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Precedence: bulk

Hi!

Le mercredi 18 octobre 2023, 09:30:20 EEST Masami Hiramatsu a =E9crit :
> Hi Francis,
>=20
> On Thu, 31 Aug 2023 09:14:55 +0200
>=20
> Francis Laniel <flaniel@linux.microsoft.com> wrote:
> > Hi.
> >=20
> > Le mercredi 30 ao=FBt 2023, 01:57:19 CEST Steven Rostedt a =E9crit :
> > > On Fri, 25 Aug 2023 22:13:21 +0900
> > >=20
> > > Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:
> > > > > Excellent catch! Thank you, I will apply this patch and send v4
> > > > > right
> > > > > after. Regarding test, do you think I can add a test for the
> > > > > EADDRNOTAVAIL case?>
> > > >=20
> > > > Hmm, in that case, you need to change something in tracefs/README so
> > > > that
> > > > we can identify the kernel has different behavior. Or we have to
> > > > change
> > > > this is a "Fix" for backporting.
> > >=20
> > > I prefer this to be a Fix and backported.
> >=20
> > This makes sense, I will send v5 to stable mailing list too!
>=20
> I missed this a while. did you send v5 ? I could not find in my mbox.

Sorry, I took a bit of time before sending the v5 as I wanted to wait for=20
Alessandro patchset to be merged first.
As it seems more work is needed on his contribution I think we can go with=
=20
this fix first.

> Thank you,
>=20
> > > Thanks,
> > >=20
> > > -- Steve
> >=20
> > Best regards.

Best regards.