Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3852368rdg; Wed, 18 Oct 2023 07:53:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGad6gPZrtfzxDWb2TXXoOeJJ4MJj54tEV+mdnIl6iKIosuLUoR3wCGQbVH9lMsOi9xB+70 X-Received: by 2002:a17:902:ec85:b0:1ca:2330:196a with SMTP id x5-20020a170902ec8500b001ca2330196amr5816790plg.6.1697640796307; Wed, 18 Oct 2023 07:53:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697640796; cv=none; d=google.com; s=arc-20160816; b=Cr3Fk0DDam8lVSS9GOhm+J+ZI8IJGloNPehyaZNftz40o3Te1G7CtzWIQUar9MGPUf a+nTlGf0UY/lHVEH9Xo4lRMUkaS6w1qJg8fHsIvpojnOtZzyU7ASMdPlCFrgGhqvwo75 C9mrm3MPo9kveGBouTN0iyiwCcD09KOkmSBpgQBd2xlqlsnwMJcEGG0P9WbZCd/52JvV juqwvT0f3xm0l1G23ynHKuuW/k1f07+OH1SVzKvIbeLX7w4IYMoHpt++ETGuQEcX1Fm7 BUmrRIeH7SDGRN3VNCy2opKk77Xpcl+rqxMZCO83XKWfGzuFL2kaHgizsEnD8LnffTRW OyYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Bit3kFkm+jLk5eI1I3JOyQopElM4NkmkcABnI6IrQKI=; fh=IXvcS/H2v3yKHYjzHAWBRvODOjUDwyELwrm27mTiXwA=; b=f1mdnHvnCzsc5ROkFsByY4zJz0cVkZTLdy8pWyUf3S/94gjCDkNFZ7MmGooBcYhUs3 qsyPrH2MaSWFve3+ahc2OGbCyK/9kAhXypYID3U3fKbPB6tjzWSm7N1nrsshEQL8el4I GU2MnZttnmqKUZqgOj8Px8EoQOZtWi5jSNyVCWXwhO3rXJYS0HdVYPftCXsoRdkvIMDX g2DAZ+Rz3yRC6kQ71tOL5qBHMdtZ7w9IxvDT9FtCQxRs2g05EgVQSqt0mwi7wEXgWF/E B+CsfNo1An5aM01ihTkcS7hVTlN3xCRqbG8WTbAyzVcS5sxw0ViUqFLtyvYNtc7La+hS oGQQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=red-soft.ru Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id p12-20020a170902bd0c00b001c20db2510asi32716pls.53.2023.10.18.07.53.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 07:53:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=red-soft.ru Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id CB730803BE93; Wed, 18 Oct 2023 07:53:12 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231970AbjJROxD (ORCPT + 99 others); Wed, 18 Oct 2023 10:53:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230267AbjJROxC (ORCPT ); Wed, 18 Oct 2023 10:53:02 -0400 Received: from gw.red-soft.ru (red-soft.ru [188.246.186.2]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 498DA95; Wed, 18 Oct 2023 07:52:56 -0700 (PDT) Received: from localhost.biz (unknown [10.81.81.211]) by gw.red-soft.ru (Postfix) with ESMTPA id 99E463E1DD0; Wed, 18 Oct 2023 17:52:48 +0300 (MSK) From: Artem Chernyshev To: Louis Peens Cc: Artem Chernyshev , Jakub Kicinski , "David S . Miller" , Eric Dumazet , Paolo Abeni , bpf@vger.kernel.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH] nfp: bpf: offload: Check prog before dereference Date: Wed, 18 Oct 2023 17:52:44 +0300 Message-Id: <20231018145244.591454-1-artem.chernyshev@red-soft.ru> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-KLMS-Rule-ID: 1 X-KLMS-Message-Action: clean X-KLMS-AntiSpam-Lua-Profiles: 180708 [Oct 18 2023] X-KLMS-AntiSpam-Version: 6.0.0.2 X-KLMS-AntiSpam-Envelope-From: artem.chernyshev@red-soft.ru X-KLMS-AntiSpam-Rate: 0 X-KLMS-AntiSpam-Status: not_detected X-KLMS-AntiSpam-Method: none X-KLMS-AntiSpam-Auth: dkim=none X-KLMS-AntiSpam-Info: LuaCore: 541 541 6f62a06a82e8ec968d29b8e7c7bba6aeceb34f57, {Tracking_from_domain_doesnt_match_to}, red-soft.ru:7.1.1;127.0.0.199:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;localhost.biz:7.1.1, FromAlignment: s X-MS-Exchange-Organization-SCL: -1 X-KLMS-AntiSpam-Interceptor-Info: scan successful X-KLMS-AntiPhishing: Clean, bases: 2023/10/18 12:41:00 X-KLMS-AntiVirus: Kaspersky Security for Linux Mail Server, version 8.0.3.30, bases: 2023/10/18 12:07:00 #22221112 X-KLMS-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 18 Oct 2023 07:53:13 -0700 (PDT) In nfp_net_bpf_offload() it is possible to dereference a NULL pointer. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Artem Chernyshev --- drivers/net/ethernet/netronome/nfp/bpf/offload.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/bpf/offload.c b/drivers/net/ethernet/netronome/nfp/bpf/offload.c index 9d97cd281f18..925862f7b7d6 100644 --- a/drivers/net/ethernet/netronome/nfp/bpf/offload.c +++ b/drivers/net/ethernet/netronome/nfp/bpf/offload.c @@ -598,8 +598,7 @@ int nfp_net_bpf_offload(struct nfp_net *nn, struct bpf_prog *prog, if (old_prog && !prog) return nfp_net_bpf_stop(nn); - err = nfp_net_bpf_load(nn, prog, extack); - if (err) + if (prog && (err = nfp_net_bpf_load(nn, prog, extack))) return err; if (!old_prog) -- 2.37.3