Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3870217rdg; Wed, 18 Oct 2023 08:17:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGU31nsi6eQTK4uwDoD1mSSEAUpswXMlPgUlbkjEAxWpUGi8cAszJGoiHiNXREm960w92Fz X-Received: by 2002:a17:902:d490:b0:1ca:1c89:9adb with SMTP id c16-20020a170902d49000b001ca1c899adbmr6056523plg.51.1697642240794; Wed, 18 Oct 2023 08:17:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697642240; cv=none; d=google.com; s=arc-20160816; b=GcCaxmujHDIVXIXhN9PjrWjVRsHLjrYYMSJ9YX0WixrqWll7vjHzG3ake9bGIrXK1R yHGMjGpDV+W8/MhZbi3f4fpqABHe2F1nuXQ4erBgj+Q90W0J0WPdWkiuMIvd6FKpNUk5 RgOqFg25eSztfT2MpeLotA4A7UH1o0vvmrUOKuhMO2OlYuRrhWDQtK1YgK1JH/Kfn/Cu bw58razCXQKpyNObd/mloYTvaxlWVEGEWPVR1QaoEKMriksZ4+qgo7Ico2/Kvr5oYKvY mWfzNHBEMfvo3D6OqZsEDVdPkrQWOckjeONtR/lGdr32wuDz4TZGAT3WnrKd2FJuqmHq M3hA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=Or5hWgFLifP+PKkrleQirWXW/sCnWbHkeszpaggjRag=; fh=UfcYDravxw3g4WIqShB1jMJ7HmLVzuIMaB5l0x7++dE=; b=HJNFsd4r8lO6NhqT/QS6xYw7MLFE5bdmmdBlLVZyDBW3RgH2I1Iv8TPmuV58nZWmlS TRr+GzBrp3yWOSRPi2t+zzrQvPKcxw0IAGkA4l1iD1jqWzXoAuOm//QLegOD+M8WHP+3 K4+gz0pXoTm5LJHLB1CyRMlxaNV7iycqwZsdT7yMmdgpiQLSA/QUIKAivWlPKjE8oAp3 tAT7EbYTYeB+JsCSVoZI5UApS7rp0hdUrSWNaNBXx0yKMBciVSKqkJi+Q8biJbkW62eS oBCmzzXti/OzgTE/QRnRDnGPiG406QzLjEEkT/XfvPeqJyqy1TiBGHdVz4uJ/W4KXPyc syhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eaaiYcn6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id p1-20020a170902e74100b001c62cfff798si63464plf.372.2023.10.18.08.17.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 08:17:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eaaiYcn6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 6DA2B818451F; Wed, 18 Oct 2023 08:17:18 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231960AbjJRPRI (ORCPT + 99 others); Wed, 18 Oct 2023 11:17:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235315AbjJRPRF (ORCPT ); Wed, 18 Oct 2023 11:17:05 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55C9998 for ; Wed, 18 Oct 2023 08:17:04 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8838DC433C9; Wed, 18 Oct 2023 15:17:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697642223; bh=tYDvOcQYMxY8m9SGQfhjrd9cWuqQEEGhyR4rDAfRaTE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=eaaiYcn6gSFfDUR4XbUsgIuZNCRef2tMCpBfqHEC/E5+oGAGB3ida/odELyAWoDjl b6xWex8Glgld6p82OZIh0Irwt6fPPmnUjYrKc3dp5C6L7wwEUUornJcOW99to2CvgW 49S45IDtHNnXtqLPM05RXzaVt1AXSTNUD6UeupynzD7smRsNChIkXNjmKn/tQ3XLYd z2Actt8+5SrIE+MWNywgJ45dpkMXJzJawDNLxz/CxLW0ME3W6xU+E321/evOfuphAo jfXtHaBkBQAz83ZesH5XZj8Ub9CnnQ3Q62uehbOtn9PvprhdzJsnvEObt30q7SFG46 d7upvMuv5C8Ng== Date: Wed, 18 Oct 2023 08:17:02 -0700 From: Jakub Kicinski To: Artem Chernyshev Cc: Louis Peens , "David S . Miller" , Eric Dumazet , Paolo Abeni , bpf@vger.kernel.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH] nfp: bpf: offload: Check prog before dereference Message-ID: <20231018081702.2e24ce32@kernel.org> In-Reply-To: <20231018145244.591454-1-artem.chernyshev@red-soft.ru> References: <20231018145244.591454-1-artem.chernyshev@red-soft.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 18 Oct 2023 08:17:18 -0700 (PDT) On Wed, 18 Oct 2023 17:52:44 +0300 Artem Chernyshev wrote: > In nfp_net_bpf_offload() it is possible to dereference a > NULL pointer. And who would call this function with prog = NULL if old_prog is also NULL, exactly? -- pw-bot: cr