Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
From:   Frank Li <Frank.Li@nxp.com>
To:     miquel.raynal@bootlin.com
Cc:     Frank.Li@nxp.com, alexandre.belloni@bootlin.com,
        conor.culhane@silvaco.com, imx@lists.linux.dev, joe@perches.com,
        linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 Resent 3/6] i3c: master: svc: fix ibi may not return mandatory data byte
Date:   Wed, 18 Oct 2023 11:59:23 -0400
Message-Id: <20231018155926.3305476-4-Frank.Li@nxp.com>
In-Reply-To: <20231018155926.3305476-1-Frank.Li@nxp.com>
References: <20231018155926.3305476-1-Frank.Li@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?z7xoQ2JldThzWaJKO6+pf7KdqgVsTvKDkjbj+pQjNDgxKvFtbpxHOnoVF0Kc?=
 =?us-ascii?Q?sgzlIix/hEW7ScyUtdpd2nArTDTU+tMT6NcYXdYSj4DCer1igSwt/ZXpcEl8?=
 =?us-ascii?Q?vq/SQYC56fXQJM5VhxQvf1WU2sNa6fzmYJZ/hHjgsK684KSl0b8gMwCYmdLM?=
 =?us-ascii?Q?2JMmMgxLbRD+dmW7zadu77toFC9IzxyYmOBrOYBrEjKxS6viSmvXLpzHE+4a?=
 =?us-ascii?Q?Zjdhpii6wi+Ttq1vk0SJu/NxmRnRc0836wH1gklr1hPTffuneaUy4x9Hrgbq?=
 =?us-ascii?Q?WJ3KRqIQKJ/ufXLeP1erd4gM1ICseduc/IEd0LwnTaZFtJYB8SJhLinbXxv7?=
 =?us-ascii?Q?i9WjEXaQWvdpAjlJ5yiwEyE0D6sSEdezqReVM7XCKznMU9QrUHG1lGkhG8ed?=
 =?us-ascii?Q?fpLFKq5eeoEj+Q0I48IAi6ZAQ+9Fi2aegZrjcuDN4onA5P6HZbL5yhHAyaSy?=
 =?us-ascii?Q?5tx/yUr/VaJdB4DB3AjAetFE9n9huFm03TtGbA8QEMnTKezbmVR28ulIhtIB?=
 =?us-ascii?Q?f+RlQZqCxvP0QwylV/GrsEAWeg36WmdP4BcpfamnwdKmG5ywxqCkbWQRSEjS?=
 =?us-ascii?Q?tDEO2C7A+L90o8mIIdHTg1Aiw1AdLEAi+aLEAGxmrmaTbDpjclEyfOjK/S+t?=
 =?us-ascii?Q?9HKGoiafJkovHRrNjpql0CpgekNs6kM8kvdfUyvDEZCbrBiqhXZkeL3EWXgp?=
 =?us-ascii?Q?5TzTaUfJhNLUQJEVflHr6QuYjmfNeBL5A5zgD6a5qPYoJCgSYjx8QyooIoIC?=
 =?us-ascii?Q?XjqNmw1nIAlO51dm8bC+S7Xj9yQNTjKOvqf+2hsnlCcLkvAeOrPBqc+yJoOf?=
 =?us-ascii?Q?kVezOrD2RDLcIQMLtVQQevp0MiEsPK2W09hrhzmu7Xux/H7nOoCLv8U3DdYh?=
 =?us-ascii?Q?inDQyxVu84AppI2u7lEA/LlF/P/2+9BOV6HwHT0h+eVBZbJVUro0k7LCekTn?=
 =?us-ascii?Q?1x5FflI/TLQMw73mevXeXkZ9RnfXGt0tcViD189GdfI70j7SNZ26I3Ynx+79?=
 =?us-ascii?Q?m/k2EYVqwGXPSOSjKY5dXQ3wispxb1DuzcMUHfct7CZdSJ4vBDFvogs0Aee4?=
 =?us-ascii?Q?Ku1qKNO3igZBmS/XeYxrwmGSS0IL4Jl98AsXjJRch5SZ3MBkgFQowvMkxqkK?=
 =?us-ascii?Q?CsDOoakPtIw7KQ0MH2BT5hpldUn3/GBZXM84RAKEgsz709iHRzXI5FFecYiY?=
 =?us-ascii?Q?PCX479xMwiBGL8N7sOYp3Z90aWgWE3O8I3WUnEKS5nriaLIdrf6gKCyYzCNP?=
 =?us-ascii?Q?BtFRlZI5cxcEucS8DrDOTv575Hw3VqAsuPfIXfXOheX2RUznX1DNg9WfBsDG?=
 =?us-ascii?Q?fID1YECPuNfTpslju91sx7vNARMeGBlMAzjk611n1QpjrgUqHZBNidPPAvEv?=
 =?us-ascii?Q?m9L4SGueBK1iyrurEtdqYMl28IJZGkW9ijG3kggGZYpu0yGxhIaM30ESpk81?=
 =?us-ascii?Q?0325UVhrCgVio08o1FgecZNGoskMgQ56KpKabADV4MbjuULLjGZyQkLOFJC6?=
 =?us-ascii?Q?hPhCffXIPBCGZ9gbrL3ZRCoyd01Kx9DIySPWXV5zk7OCZtbWmeIINKxSqbMU?=
 =?us-ascii?Q?JiRBFGQypgeqGkYFekPMvfHWqGA2wm1LUmbbz87E?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eb1691c1-0dc5-4a3e-90dd-08dbcff342c3
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 15:59:50.8903
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3W1EFH5QHzMVrocEcrtO3pulaVILJ0eWgdP/2M8bMLUw6gl+DbyKW+1fUHKcx/K4/6rD9BhjYHCrRT1UpMwj1g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6966
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 18 Oct 2023 09:00:29 -0700 (PDT)

MSTATUS[RXPEND] is only updated after the data transfer cycle started. This
creates an issue when the I3C clock is slow, and the CPU is running fast
enough that MSTATUS[RXPEND] may not be updated when the code reach checking
point. As a result, mandatory data are being missed.

Add a wait for MSTATUS[COMPLETE] to ensure that all mandatory data is
already in FIFO.

Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver")
Cc: stable@vger.kernel.org
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---

Notes:
    Change from v1 to v2
    - update commit message
      it also works without mandatory bytes

 drivers/i3c/master/svc-i3c-master.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index abebef666b2bb..dd06b7c9333f1 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -332,6 +332,7 @@ static int svc_i3c_master_handle_ibi(struct svc_i3c_master *master,
 	struct i3c_ibi_slot *slot;
 	unsigned int count;
 	u32 mdatactrl;
+	int ret, val;
 	u8 *buf;
 
 	slot = i3c_generic_ibi_get_free_slot(data->ibi_pool);
@@ -341,6 +342,13 @@ static int svc_i3c_master_handle_ibi(struct svc_i3c_master *master,
 	slot->len = 0;
 	buf = slot->data;
 
+	ret = readl_relaxed_poll_timeout(master->regs + SVC_I3C_MSTATUS, val,
+						SVC_I3C_MSTATUS_COMPLETE(val), 0, 1000);
+	if (ret) {
+		dev_err(master->dev, "Timeout when polling for COMPLETE\n");
+		return ret;
+	}
+
 	while (SVC_I3C_MSTATUS_RXPEND(readl(master->regs + SVC_I3C_MSTATUS))  &&
 	       slot->len < SVC_I3C_FIFO_SIZE) {
 		mdatactrl = readl(master->regs + SVC_I3C_MDATACTRL);
-- 
2.34.1