Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
From:   Frank Li <Frank.Li@nxp.com>
To:     miquel.raynal@bootlin.com
Cc:     Frank.Li@nxp.com, alexandre.belloni@bootlin.com,
        conor.culhane@silvaco.com, imx@lists.linux.dev, joe@perches.com,
        linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 Resent 6/6] i3c: master: svc: fix random hot join failure since timeout error
Date:   Wed, 18 Oct 2023 11:59:26 -0400
Message-Id: <20231018155926.3305476-7-Frank.Li@nxp.com>
In-Reply-To: <20231018155926.3305476-1-Frank.Li@nxp.com>
References: <20231018155926.3305476-1-Frank.Li@nxp.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RGYzVUdwSlJJUDFkVWw5VjB1a3RONUF2UCtYREFtdnpGS2RjS0tPK01jaEpI?=
 =?utf-8?B?c1djekpaWnBQZnZqNWlyY2NOdXJSL252WWxKaksyU1dReWxqaUxWY1E2dlVB?=
 =?utf-8?B?djJSMGlnM0ZCS2tSUHRsMWNyMHMraXA0anA4QWRXQ2RoaThVVlhKNTFMUUFX?=
 =?utf-8?B?REY4QXN3dVMvY1lHL2ZWUVp0N1RaUEt5YTU2NDgwcVN4SFNCcWFmY3U3REY3?=
 =?utf-8?B?MFR4OC9VVUY0TFJTSHJJNWFROG1VaC9OUmVaeFlVaWQ5Y3QrU21nUURrRVpy?=
 =?utf-8?B?Q3huQjR5TmdWSzRLTmFHQmt4NkZmZlVwRUZaUFZyL0xyZUg1WENTN2kwQndy?=
 =?utf-8?B?NUpoWHJmOEJDZVFJL3pKbTBpRk5yc0k2QnF5UHBjT3NHcGNSRGd4cUR0bHIx?=
 =?utf-8?B?a1MxMWNqT0NldTFxSG9pZXZvcFpuSFNLUzB6VkdCUU95SVFYTGM4Nms4TnJS?=
 =?utf-8?B?eEJydis1NzdXeVdnR0psN0dGQStkSlFQQUpHaHJUU0I4aVhDU3BtbmJCUEw5?=
 =?utf-8?B?am05WFNLbkJYU2ZwTWhZTUJMNzdDUnpZajBmbVVHRkpIY1gxR1hYT0xweWgr?=
 =?utf-8?B?ekpSdHVrZ2ZvdDhSMU1hMjhqT2cwNSs5bitqSEduMUtGNnBjdGZGdG1pRmFP?=
 =?utf-8?B?QnJBazZaYWoxem84UEREU1FIT1c1Q3YxdTZKbjlIL3l3bGV3N0g0L3ZRT0pV?=
 =?utf-8?B?dVRIdFNGZEZwLzZKNW12NU12dFZTRnozNHkzSEVXbk55amxESElmcy8ybytK?=
 =?utf-8?B?WnVoNzhQSnZsMTdtdVQxbUNDMXZMalduM0RRMlhsYVRmSXNLK09ERGN1UzA4?=
 =?utf-8?B?YUhiMHhySGdtUk56S0hSeEVoMUtKNURlcGQ2cml6NHc2VlJlNXFFTmM0aWRu?=
 =?utf-8?B?aDdQSU1ILzlBTDdrTUFlMFZkVlhtU2FqeEJBUmNabVR6d29FMUJUSHBSUzRo?=
 =?utf-8?B?Q3FkeGdQditKQUtUcXVOQXZvSUhuSS82SG1pL2piZmhuTmU5NnFTSDk0MXFh?=
 =?utf-8?B?TjBMYUtDTDVtOTNqTkp3NGpBWGJvNEtUV3E3ZlExdWFKcTc5SHlpNU1QWm4r?=
 =?utf-8?B?cnlsWEUxZ2d1eTlObXpLZVIycDBWTi8xOGRWaGdIT0ZHSWl6ZHhWUEJZZ3lJ?=
 =?utf-8?B?VTN3TGZZK2RHcGlZZEZNbE5NelhLbG8wM2ZxcTNESU9rcThtL25JWmZqSGRv?=
 =?utf-8?B?NEgxOEcrSGVKL2k0MmY2YVZlaG9HMXBVRGJUcjhBZlZJTFFHQldGOUVJSXA5?=
 =?utf-8?B?SnFUZnY5VEtNdUZCR2xQbXhzTmU0U1VJQzVaTDUxOE5pZ2tXYU9Qd0FuS3pp?=
 =?utf-8?B?YTl0RFViMmVuVE96VXYxS2hDTHViTlVMT3k4ZjdMQWRoQ3VvVUFESGY4TlJ4?=
 =?utf-8?B?U1JrRDBtdHlqNjV2bWE1UVVpRDF3SU85bjRoYzl3V3pudVpiWmFqdUFwcnV1?=
 =?utf-8?B?eFc4SysyWFBsNHd4OGxTQkdRbUZnKy9CSGs3a2RhZzFtQjZwcmd3b3pVb0Jv?=
 =?utf-8?B?UUJqcWhSY3BWTytoV1FsZVkyYTk1Y3JrRklhSTJtN3NrWHR5TldNZEh0cWtp?=
 =?utf-8?B?MXc2dVRDQUZLR0lwU0Juc2VCZGtkS0FNZ01WdTBRc2ZIbEZqN2tBQ0VDY2xC?=
 =?utf-8?B?Rkd6ZWFyRU9aRHRTMFRJY3pVekd1dXpOVGtscG9kRkIwZjBpMktidk5WemVZ?=
 =?utf-8?B?TnpSdWxKMW5KYmozdEtCaWQwcmFpcE9naXRlUnU1L0lKUkQxNVdZblVUNm04?=
 =?utf-8?B?RkRZa2s4RUtpUWtHUUIvQ3o3eURHd1FKcXZ0ZUlWelNmRFVJMXhEN09KWWpl?=
 =?utf-8?B?SlluMXlSNWFrdjZvd2pqd3FYTXU5OVpFQTdTclQxeHpPenJwQnVGVW9ENVBk?=
 =?utf-8?B?amFoZXI1MzNHZW10UUJxZXFNOVVsRmlzQjlKQ0VYY0JxV3k5VGFsc08zWnh1?=
 =?utf-8?B?OGxtR2NHbnFJc2ZoVWNYcm02Wlp6VVcyME80b2pMRGkvVGFvVllCMTdNcE5L?=
 =?utf-8?B?TVF6SExiaHdOdUtkc05FWTlGRXZXWkZvbmtmK3NZdW5iMVg4ZE9xeDdIVUcx?=
 =?utf-8?B?MFVJY3hDeExlM1JoR1BMTlBiazFGSG5LaUcyaFd6SU5SMGZpWDBQMyt4MThj?=
 =?utf-8?Q?GKqPKpgYhS11pSc+BGHyCDWml?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c2be9190-f7fc-45cd-6d61-08dbcff34751
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 15:59:58.5131
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4I63UuGnjXmXnwy8MxQis7lE52/x2VZWoraOOvtBb+ac2OVVWOFq1FgDitYaoM1rPLMYGh/QX9lhRt+GEq1sPQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6966
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 18 Oct 2023 09:00:41 -0700 (PDT)

master side report:
  silvaco-i3c-master 44330000.i3c-master: Error condition: MSTATUS 0x020090c7, MERRWARN 0x00100000

BIT 20: TIMEOUT error
  The module has stalled too long in a frame. This happens when:
  - The TX FIFO or RX FIFO is not handled and the bus is stuck in the
middle of a message,
  - No STOP was issued and between messages,
  - IBI manual is used and no decision was made.
  The maximum stall period is 10 KHz or 100 μs.

This is a just warning. System irq thread schedule latency is possible
bigger than 100us. Just omit this waring.

Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver")
Cc: stable@vger.kernel.org
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---

Notes:
    Change from v1 to v2
    -none

 drivers/i3c/master/svc-i3c-master.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index 1a57fdebaa26d..fedb31e0076c4 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -93,6 +93,7 @@
 #define SVC_I3C_MINTMASKED   0x098
 #define SVC_I3C_MERRWARN     0x09C
 #define   SVC_I3C_MERRWARN_NACK BIT(2)
+#define   SVC_I3C_MERRWARN_TIMEOUT BIT(20)
 #define SVC_I3C_MDMACTRL     0x0A0
 #define SVC_I3C_MDATACTRL    0x0AC
 #define   SVC_I3C_MDATACTRL_FLUSHTB BIT(0)
@@ -226,6 +227,11 @@ static bool svc_i3c_master_error(struct svc_i3c_master *master)
 	if (SVC_I3C_MSTATUS_ERRWARN(mstatus)) {
 		merrwarn = readl(master->regs + SVC_I3C_MERRWARN);
 		writel(merrwarn, master->regs + SVC_I3C_MERRWARN);
+
+		/* ignore timeout error */
+		if (merrwarn & SVC_I3C_MERRWARN_TIMEOUT)
+			return false;
+
 		dev_err(master->dev,
 			"Error condition: MSTATUS 0x%08x, MERRWARN 0x%08x\n",
 			mstatus, merrwarn);
-- 
2.34.1