Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
From:   Frank Li <Frank.Li@nxp.com>
To:     miquel.raynal@bootlin.com
Cc:     Frank.Li@nxp.com, alexandre.belloni@bootlin.com,
        conor.culhane@silvaco.com, imx@lists.linux.dev, joe@perches.com,
        linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 Resent 4/6] i3c: master: svc: fix check wrong status register in irq handler
Date:   Wed, 18 Oct 2023 11:59:24 -0400
Message-Id: <20231018155926.3305476-5-Frank.Li@nxp.com>
In-Reply-To: <20231018155926.3305476-1-Frank.Li@nxp.com>
References: <20231018155926.3305476-1-Frank.Li@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?h90RWPYZsEHs1ff8kqjfxPnbhINnOxCeSY332nStR/VX5ag39/snqoQidqGQ?=
 =?us-ascii?Q?fFQIoJu66AxPZnlc7kTOL4jNfcd9iWiWUe9vVQusFbKJBCBmvc7r5f6Y3cVF?=
 =?us-ascii?Q?PXO/R86DAQVpsxnNS+Ti+c1g1hCyBFmWYZN9LLzXUd+hVDMTpb4wg0y9D6c7?=
 =?us-ascii?Q?0EJRvx/4B7QEg0IbOcRlk11lmJTsAfZp1K9dgaNMGmgBOWEnpa/fi3O3Xm/7?=
 =?us-ascii?Q?BExA+wPTq0XQdalEi+bM7ysipCgvUkgWulMzxr9Ll1U7vlPi0/sEtRfdzD8p?=
 =?us-ascii?Q?wrnEDP8htgArNkTYOmZ4tbFhrcw0AOHsdeqxEtnUQ3QbCiaKQETj/iAJZ1Yi?=
 =?us-ascii?Q?rBhU6b/ZWzHicsUEEzEDFKOEmagUWI9RBySckoOO2hcp3XVpXHhSVqi3Mn2F?=
 =?us-ascii?Q?O/evGqHe/uZR93VcBwr2YSqyoNTiNnxJdZGRT80hjPzBPlI7h/0meuu6W4rz?=
 =?us-ascii?Q?V1s3jJTCXElchxIf9/Tr66sgT8SGLRb9rGlAHsWnEX9MpJhkEgU/gGtHWG5O?=
 =?us-ascii?Q?4afXS5hs1TeDZtetaeA567np2rJlY7QPy81BRJoaM1/WYvh9HA/Pka7TAg3+?=
 =?us-ascii?Q?UuxTDg1zB2vptUpDRxH4ekITX9GljvylEwL+N369NH+PcvRjgZ4Mn3seSuCW?=
 =?us-ascii?Q?fzrUjmJlmHsT0KgX/D4Hk7stkgB3r6gMZhfO49vY35dM0kw1naIYex5COj4M?=
 =?us-ascii?Q?VO25zG0kBvq5gBmoD4v8iqd0DXyNcDSbUmXfaVv1HVzh26OvOpUdBcGVeZcS?=
 =?us-ascii?Q?xAbC4gpYBd9O61YMk8P0RC9kI4+QylTPFDJ9KOKr5BjIRwc5xZS5R3Irhew6?=
 =?us-ascii?Q?ExIlfzbcGH5XuYj8VCAr7kjvhxunNkCCVLwVq7ipO+DqirkUYgkmY/MGTtPE?=
 =?us-ascii?Q?9ghsHNQS60htu7dj04nATx60QKff7MO4pYtp08NBRNYO1gc9Jh/RFZeleB4S?=
 =?us-ascii?Q?jaH885NgX5/Lf9xURk1PcZJJS7FWCYsSAGyjVJpQ5C/n6CcXjYYVgc5JCJzd?=
 =?us-ascii?Q?JAHgh8CiCzRgvI/6knK7VshuFSYivJv3kmzMQbcTDfq9frkCRw2Io3SNffbL?=
 =?us-ascii?Q?eAsHIbOn/fVmpHgTs/DkH3QhmR5mHaSc9bbATvzadIAVl+fo8cctUGD93ERC?=
 =?us-ascii?Q?Kg+CK2N0F30Irgrj3L6JqfWnH4zPW8MwsZLtzPYAn4URhJOT+cLDBhycaJGi?=
 =?us-ascii?Q?uL8mliC63o5es/MD4V7y5YvH4X3vt935nDoRz5HNDJr0kcKJjkfeD//bo0V+?=
 =?us-ascii?Q?77KIyggQ7uzseEEvVGsC9wiqoHfRZH1NjC6mRkoZqX3SqU77iM9/SxMus0zv?=
 =?us-ascii?Q?i3B2+dbYMGBga+1PQuDU5R7gHaGqLRD10N5ixb71+vUhvA1SqGmUqokCOhlB?=
 =?us-ascii?Q?8LZwQLpAeVOaTS5nT9wtD6NSnNTtdsDCLJ9Hes/ck2z3Kge3GtPY4M7RjFuc?=
 =?us-ascii?Q?ZVQEBTVIXDFynsqv8HO5VviDzgx0gHEVQeGtOPuDEJ4LphG3PtISW43/7Nxe?=
 =?us-ascii?Q?0qgItvDh27N786+2F7LXUdTnAq3E2wAOxP7Y0lRq5AAG4IMPnxsLJjQTYvzt?=
 =?us-ascii?Q?6W00SFhUlRFw8O5xC34HpCGQ8degTr4nKXLGPbbm?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e072b63-f091-45d3-ba7f-08dbcff34432
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 15:59:53.4539
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: duZdMaKarVguVUIRRqL/0gLXw2QgJ+bKMv4PdDEGBcDAaZZbZctCzUTZ9QG7jSWK/DUfqaV3aileL7rRYj++VA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6966
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 18 Oct 2023 09:00:45 -0700 (PDT)

svc_i3c_master_irq_handler() wrong check register SVC_I3C_MINTMASKED. It
should be SVC_I3C_MSTATUS.

Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver")
Cc: stable@vger.kernel.org
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---

Notes:
    Change from v1 to v2
    - Add Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

 drivers/i3c/master/svc-i3c-master.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index dd06b7c9333f1..b113460f059c3 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -476,7 +476,7 @@ static void svc_i3c_master_ibi_work(struct work_struct *work)
 static irqreturn_t svc_i3c_master_irq_handler(int irq, void *dev_id)
 {
 	struct svc_i3c_master *master = (struct svc_i3c_master *)dev_id;
-	u32 active = readl(master->regs + SVC_I3C_MINTMASKED);
+	u32 active = readl(master->regs + SVC_I3C_MSTATUS);
 
 	if (!SVC_I3C_MSTATUS_SLVSTART(active))
 		return IRQ_NONE;
-- 
2.34.1