Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
From:   Frank Li <Frank.Li@nxp.com>
To:     miquel.raynal@bootlin.com
Cc:     Frank.Li@nxp.com, alexandre.belloni@bootlin.com,
        conor.culhane@silvaco.com, imx@lists.linux.dev, joe@perches.com,
        linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 Resent 5/6] i3c: master: svc: fix SDA keep low when polling IBIWON timeout happen
Date:   Wed, 18 Oct 2023 11:59:25 -0400
Message-Id: <20231018155926.3305476-6-Frank.Li@nxp.com>
In-Reply-To: <20231018155926.3305476-1-Frank.Li@nxp.com>
References: <20231018155926.3305476-1-Frank.Li@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ydFHcasc5LkaRtZsorlH9V8tXLhyh5C0pkl3Ea4K1d52XeEi40BCZrzkMg3t?=
 =?us-ascii?Q?F0h50ulivUlvvHtm0A/qa4Zi/g43iwMBtSicz8nSpwO7jpTUGo9/jngU8PbB?=
 =?us-ascii?Q?mRZRl6N+cMMBTyLQCNN4ss7sF25vH/BtTYVd82oHGXwN5MKPc+jCwhjvmarQ?=
 =?us-ascii?Q?Rw9wAtl+KsASbQNJJvukOhdcnfXOSQKVtf7o/epo42MTaM3MdDsQRISnG3bj?=
 =?us-ascii?Q?zprMw7++irxeLUkBCvfXh87m/4NObN6tao3exOc0WirsyrDdIKKqdh12mWic?=
 =?us-ascii?Q?b9iNxkOYlBn4D6LH9WERyruXzw/7NHaul9PKRfVp4S9t+SizNsgPKHKlqMxD?=
 =?us-ascii?Q?fGhPKT5UWQwD7E6aV7MDbWxfmMPuYo9trHAJYVTpogsuIEk9USOn+zIsSx4G?=
 =?us-ascii?Q?6wy0nf08opPyIXXtzBmFvp42TX7BZttlAnqURE5g+OQwiUtFfIoAVeVwgvud?=
 =?us-ascii?Q?11+kbMqbvl1pZ2hUjRsoGSJSst5KWHn4Qutw1dOQuI93Nt6k/sPENU2QxTvP?=
 =?us-ascii?Q?mCq9vEdSTqXkprsuucRKb/WGe7QShL6A8EkpFIRYEq+18TpVECLCk9Obon3z?=
 =?us-ascii?Q?gBF8Yu41i7KjtMn+ygEt+siMoUSl8LHhol/21hbdB7G0RJvuP9jJ7HK4kfxo?=
 =?us-ascii?Q?QNVUIihcOnz+63KfLYqbhfC/n8/JsotLoDgslPKhCdHUQf0a0Vt7oFPf4TqL?=
 =?us-ascii?Q?gf7kUTJMnyoCpv7ABAa19F7OwVgO2WUP3XSDS9kCKhRHkzNuFrW+z553nNZV?=
 =?us-ascii?Q?Ud7HIkg8gtUUZ1onVwlH1EkbY7Ce8TZNHbf2CYe3Cfso1cfeOuXBQsM1A7VK?=
 =?us-ascii?Q?4DzoML10tHsWGlIWWHDoblPcEeZWrJYIXYNrgrMojCwbYOuhr6tYGT2h0GNE?=
 =?us-ascii?Q?pRxAWp2hqj0ojpQv6xJdMRc9p+qXGITY8Fh7qYm10ZuuXpyWQOe01D/a0YuP?=
 =?us-ascii?Q?QkGUkwtldRe2GNOe4T3V4zMW0fsrXmrgamMpzWCBjSNF0qlNmTbhKsDQ23ZA?=
 =?us-ascii?Q?nq2kqwOCWExwktoSYVvWAAS7Q6rKDoiS5YHGHGoHoc2XCuhCOojHnvUwRctF?=
 =?us-ascii?Q?Lerts9j/QZKSHt+28h9zsDKMq2f5XrB/GIup282wcAD2tg5IcdKr69D8Sxgf?=
 =?us-ascii?Q?YjmVdrs6mZBHfmIN4y+4xjtb2OWTsY991nbhLWv1r6IBlCOktFkPOkr7oIt4?=
 =?us-ascii?Q?ghi43gLgpGElQPZ3YY0dN22l+Wc0fM73rwVlTw5DcLGA1cp5XEGzwjB0S7D3?=
 =?us-ascii?Q?LbHBh+cpTGTUoHcjHN2yMnnBwl7Zr3CqXfN8x1lGAnKZunWeIDSEXCke1zRh?=
 =?us-ascii?Q?t0fr/RNvyJXapmYYHRjhraRdW73bawQlsQEfWe3tvCN5ReVNfCi+nOm4UNJd?=
 =?us-ascii?Q?AXyq75mqxWjKlnFdsKQ03DIs2spWSuTRgTTZxJEnQpJB3ausTYOO6SVdMCrx?=
 =?us-ascii?Q?8LQH4xMM7C/fZbScEAjd6010/BmWvQLa9eAteGO0jE8o9KXHuHINuLnh2MbQ?=
 =?us-ascii?Q?Q6IXPXh24/kOHUOeCA9DhQmkYb913lxSto5fcawqEGlICobyQMUMMcna9FTn?=
 =?us-ascii?Q?R5ZSZdFOU2pvYDMNGhjEU0LJCdYloAs8MFquLCli?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: be53f2c2-92ae-46d9-09d0-08dbcff345c8
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 15:59:56.1138
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zDJOlxiKPeawwY6QwaXrSwjINlntWoxxPVSVO7Nyz5rz3QjUEdkFE+4P+ujUoyJIJXj/2Vro+TmN4LRVJ7TANw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6966
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 18 Oct 2023 09:00:36 -0700 (PDT)

If IBIWON timeout happen, SDA line will always keep low because miss emit
stop.

Call svc_i3c_master_emit_stop() to let i3c bus come back to idle statue
when IBIWON timeout happen.

Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver")
Cc: stable@vger.kernel.org
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---

Notes:
    Change from v1 to v2
    - Update commite message

 drivers/i3c/master/svc-i3c-master.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index b113460f059c3..1a57fdebaa26d 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -404,6 +404,7 @@ static void svc_i3c_master_ibi_work(struct work_struct *work)
 					 SVC_I3C_MSTATUS_IBIWON(val), 0, 1000);
 	if (ret) {
 		dev_err(master->dev, "Timeout when polling for IBIWON\n");
+		svc_i3c_master_emit_stop(master);
 		goto reenable_ibis;
 	}
 
-- 
2.34.1