Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3921782rdg; Wed, 18 Oct 2023 09:34:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGrb4cUP0+9l0zqVTVGY4QXIBBHOXXEfLu4GUebfucDyL3KIQx+vOf6v73XtZ+IARFTwQCg X-Received: by 2002:a05:6a00:2d8d:b0:6be:11ac:98a5 with SMTP id fb13-20020a056a002d8d00b006be11ac98a5mr5362815pfb.27.1697646886142; Wed, 18 Oct 2023 09:34:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697646886; cv=none; d=google.com; s=arc-20160816; b=dcNW/BqOuIlmpzuFH2+oQxgaqLjvGeN/TdO+F95ItDZLXQKClXCsBl4gWtZy0xEb0w uzJA8Z/SENL1hPtBXW3kQpKNPWTT0nUGOToG0Ag0He//UkxAMSHipJrTnFn+Np41L3UO LVI50ar4Gru/dz6Mkkq5NfAJhygABLrvM3bFWtJScxFgwNxokAkPmP3brMrcJmKgSk+a XF3RKQ4XbMviGf7eSQml3ExTAzzgur2lT5PfLA0iLexQq2bOWeFO6bOVxu78ncupBYnf tovfzVUBNuUOKY4MUcNN6BsjjHf9i0fO7M6p95SwCldHtOk6PqMprlAkbpDQmGuDFRWP e/MQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=NWf1ItjjdTeasgY3BTezBUXWu2OBeZGGK4xV7fL7bhw=; fh=7lvNli58MKLqi850IEpqdvYvJAgvp84rNT3V0CoxsKM=; b=izp4U9SPQXUj7ciRHXxIC+Fh79dUfxVb5JXJ+B1xfhz2oRKmen38YaDjTexRnuNF3X Bx4Opg8zjDZyPG0v4iCqbRzw9jmxyDJQ3j1tJUZz12b2zwVsb3ixju+Mzx2ehhTuZdJ/ NqtQvFyj+Vjlv7ZNodWS9hucghZgEpI4e+1Pkyz4Dh6DfuWwksSiKLsqetcykGIx55Rl DLCBPD1OoelJuc9U00sQh/yqn1BCmgUZxSANKhY5y1Gv9tBB6FgjPuiY9ta6NrAXBw0c VcfbjuKos/fQ/3/pas1m6CkBNxGzq4djdo/aGOdGpCpW6v9fsfnvOcrHWo3YSlvjLTAu qKVA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id a2-20020a056a000c8200b0068e3f3c6250si4429976pfv.343.2023.10.18.09.34.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 09:34:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 036BB80F6942; Wed, 18 Oct 2023 09:34:39 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229794AbjJRQe2 (ORCPT + 99 others); Wed, 18 Oct 2023 12:34:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229853AbjJRQe1 (ORCPT ); Wed, 18 Oct 2023 12:34:27 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DAD95BD for ; Wed, 18 Oct 2023 09:34:25 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F75FC433C9; Wed, 18 Oct 2023 16:34:24 +0000 (UTC) Date: Wed, 18 Oct 2023 17:34:21 +0100 From: Catalin Marinas To: Andrew Morton Cc: Liu Shixin , Patrick Wang , Kefeng Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 5/7] mm: kmemleak: use mem_pool_free() to free object Message-ID: References: <20231018102952.3339837-1-liushixin2@huawei.com> <20231018102952.3339837-6-liushixin2@huawei.com> <20231018092253.a12815afa7db9049f95fc195@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231018092253.a12815afa7db9049f95fc195@linux-foundation.org> X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 18 Oct 2023 09:34:39 -0700 (PDT) On Wed, Oct 18, 2023 at 09:22:53AM -0700, Andrew Morton wrote: > On Wed, 18 Oct 2023 16:57:50 +0100 Catalin Marinas wrote: > > > Could you please reorder this patch before the previous one? If you > > > added a Fixes tag, we may want a cc stable as well (as for the other > > > patches with a Fixes tag) and it makes more sense to backport it on its > > > own without the __create_object() split. Otherwise: > > > > Ah, ignore this. If we want a cc stable, the whole thing needs > > backporting, including the split which is essential for the subsequent > > fix. > > Do we want a cc:stable? That tag wasn't originally included. > > If so, all seven patches? > > If "not all seven" then can we please have two series, one for the > backport patches, one for next merge window. I think we need all 7 if we are to backport them. But we don't need to cc stable explicitly, we can send them to stable@kernel.org separately once tested on those stable versions. So, for the mm tree, don't bother with cc stable. -- Catalin