Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Wed, 18 Oct 2023 19:14:41 +0200
From:   Oleksij Rempel <o.rempel@pengutronix.de>
To:     "David S. Miller" <davem@davemloft.net>,
        Andrew Lunn <andrew@lunn.ch>,
        Eric Dumazet <edumazet@google.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        Woojung Huh <woojung.huh@microchip.com>,
        Arun Ramadoss <arun.ramadoss@microchip.com>,
        Conor Dooley <conor+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>
Cc:     Florian Fainelli <florian.fainelli@broadcom.com>,
        kernel@pengutronix.de, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, UNGLinuxDriver@microchip.com,
        "Russell King (Oracle)" <linux@armlinux.org.uk>,
        devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v5 8/9] net: dsa: microchip: Refactor switch
 shutdown routine for WoL preparation
Message-ID: <20231018171441.GB3595737@pengutronix.de>
References: <20231018113913.3629151-1-o.rempel@pengutronix.de>
 <20231018113913.3629151-9-o.rempel@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20231018113913.3629151-9-o.rempel@pengutronix.de>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Wed, Oct 18, 2023 at 01:39:12PM +0200, Oleksij Rempel wrote:
> Centralize the switch shutdown routine in a dedicated function,
> ksz_switch_shutdown(), to enhance code maintainability and reduce
> redundancy. This change abstracts the common shutdown operations
> previously duplicated in ksz9477_i2c_shutdown() and ksz_spi_shutdown().
> 
> This refactoring is a preparatory step for an upcoming patch to avoid
> reset on shutdown if Wake-on-LAN (WoL) is enabled.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
> ---
...
>  EXPORT_SYMBOL(ksz_switch_alloc);
>  
> +/**
> + * ksz_switch_shutdown - Shutdown routine for the switch device.
> + * @dev: The switch device structure.
> + *
> + * This function is responsible for initiating a shutdown sequence for the
> + * switch device. It invokes the reset operation defined in the device
> + * operations, if available, to reset the switch. Subsequently, it calls the
> + * DSA framework's shutdown function to ensure a proper shutdown of the DSA
> + * switch.
> + */
> +void ksz_switch_shutdown(struct ksz_device *dev)
> +{
> +	if (dev->dev_ops->reset)
> +		dev->dev_ops->reset(dev);
> +
> +	dsa_switch_shutdown(dev->ds);
> +}

here is missing EXPORT_SYMBOL(ksz_switch_shutdown);
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |