Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3962167rdg; Wed, 18 Oct 2023 10:38:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEuzP6vBDLdjC9o+Y1nKJ/Wddkii8zg3xn0G2JkMPkIzcg6dE8kyqH5F1i0L49XAYFOctmc X-Received: by 2002:a92:dc4c:0:b0:34b:50c7:da55 with SMTP id x12-20020a92dc4c000000b0034b50c7da55mr59853ilq.7.1697650705162; Wed, 18 Oct 2023 10:38:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697650705; cv=none; d=google.com; s=arc-20160816; b=G6hAFQS6dNjNNuzM3aSutVh2pNT8h5BCTHxMhTxhwCVRNUD6VKoMcIOrhQodULrl32 g+fFPvVJRQ+a8MeohCZU3l1CphNEnieFnoKgpW8FEZES5I6+0DQpEkMZSz9H+g3oedb1 BPJnHPG+SSDgMU7KyvLBjLZgJgUxuyPTgRRROAUUUag9z9/cG0z0KqXMAkLGW63hT0oC pbHw2vh+uEB4hW5ypNx8/8QxD0Zt1r7zwCyHieCVXHhd3exC/Gsat0B5fzfWtQTOSasd zAy0u+/k1psYaRSl2xLYsiCbStgx+EU1PHjnSrkUX+2XOtrcpioqXmL15utFQ4XRB6hS X7lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=CdORHOZKIIst7Qtd7c7OcYKZKJ7FX1GB6/yge3JzlJM=; fh=HCtmUDdFbs0PY7ZjL+nUIhnLacPwC6lXm2gePxKVknA=; b=UeNzKDtwNC1sThQ56YikU/dtJ1wrkFa5G2sV8fBBd1v2Qyo275DVakh+ESc8Ga/UPR CL22bHo+VhYOnYuYF8kUi1h9rtLEb1/AAGDyAoAfzxZ+d3dWNbA08Su3YbTR0mb13EaF 7owsbfj0n4VvvU2h7A5SwV4nNqNx+G6bKa1gYv6o3kE6aicp/Jmw0TKSUZNPb0AciOlt he4PlAzPnWDLlN5rAVpMqQjpQC4FyGeE2GvC1C7drHKzZPG1ig8x05U5ZqNVy7Fjn2yn BXfNfAJLpbPOMYBmvGjb7RCOhof5c0Kwh6SaoERPt4+45dP/1OKW9srmsuU6HmNhJHRK 3TkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=Qt8PKnoZ; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id bv70-20020a632e49000000b005ae99bb5c03si2399551pgb.41.2023.10.18.10.38.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 10:38:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=Qt8PKnoZ; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 2AC3C8128022; Wed, 18 Oct 2023 10:38:22 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232146AbjJRRiN (ORCPT + 99 others); Wed, 18 Oct 2023 13:38:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232438AbjJRRhx (ORCPT ); Wed, 18 Oct 2023 13:37:53 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CE57D48 for ; Wed, 18 Oct 2023 10:37:40 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1697650658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CdORHOZKIIst7Qtd7c7OcYKZKJ7FX1GB6/yge3JzlJM=; b=Qt8PKnoZRQkppNeTu2PXqYTJGU3zOa2xwEzd9hU9UFSRJpi5LiltnWB22DZrA0tYTTuQGM uSevzKwA5g13RKLwCPqXNN005zB0+vH8Ae3OLmHIRStk8fgvGOa2+hvznqjeal7fa87S9K 4nA4D/Mh1DqeBKe1nA+bLF6yfHVNzRHYALatnQuBgZhjbzOVTSQjnaoQ2JB+hMfz3iw3XW 1kmn55GSab//8kykdHTtimR5h95aJIJX3zQPWFQ15mbj1mFTJCL+RhHg9JeEl+gGV267yT Cd5WGUBQfT4y6ZjPANJs9/mXzBuf3K8ldO8XrgopyWigjC2R6S2ercrXL4UH0w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1697650658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CdORHOZKIIst7Qtd7c7OcYKZKJ7FX1GB6/yge3JzlJM=; b=2hTP6c8HwaDwOr5Swco7wDaNMNxorROnHJ9jRfE/dCNtPhIkrkir2vXeCB4gt3pial/+0m asaTHEWVn3dBJuCQ== To: Al Viro , gus Gusenleitner Klaus Cc: lkml , Ingo Molnar , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "David S. Miller" , "dsahern@kernel.org" , "edumazet@google.com" , "kuba@kernel.org" , Paolo Abeni Subject: Re: [PATCH] amd64: Fix csum_partial_copy_generic() In-Reply-To: <20231018154205.GT800259@ZenIV> References: <20231018154205.GT800259@ZenIV> Date: Wed, 18 Oct 2023 19:37:37 +0200 Message-ID: <87edhr4yse.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 18 Oct 2023 10:38:22 -0700 (PDT) On Wed, Oct 18 2023 at 16:42, Al Viro wrote: > On Wed, Oct 18, 2023 at 06:18:05AM +0000, gus Gusenleitner Klaus wrote: >> The checksum calculation is wrong in case of an source buffer >> containing zero bytes only. The expected return value is 0, the >> actual return value is 0xfffffff. > > Expected where? The actual checksum is defined modulo 0xffff, so > 0 and 0xffffffff represent the same final value. Duh. I really should have read the RFC first :)