Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp3993046rdg; Wed, 18 Oct 2023 11:32:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHCAJDQrZRODp5idbbn2p2as5xDfiO0b/1Mm0SnlT23hzLIyIAjOg4J4+vekZNk/oYon/92 X-Received: by 2002:a05:6a00:1a86:b0:6bd:b7c5:f776 with SMTP id e6-20020a056a001a8600b006bdb7c5f776mr6581502pfv.8.1697653951557; Wed, 18 Oct 2023 11:32:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697653951; cv=none; d=google.com; s=arc-20160816; b=gmPt0wlnZSppu8mL5+JQgMEqsFy9VO185eCyClIHvwkoSyK9FHyWcGWFy+avlV/2s7 nec49YDGIS2eSRpgnGQfloemvPOK2ebyYyjbQdGB5U3v0CW1src21g2/rER1cl8APrY5 VKov5iF+b1UFl6D6cQgg0Lak1DAVXqbdNTkesKYde7VGoxiXHcborRyQduqc1WeZUvj/ 7r7q/35/02fKcmFsmpC/jDzIOfTxMUJbqHJy567FaunqdGKGA/Fefj9LkxwHQe605+eT tPR4msOUNsQlKKlmILN3gUTcYX0UcQHpRiU1R4lG1gkF2GGd0UwGDSHheXTKEgvfuh+2 T+hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=ah+JjlUw9kHMOLFmj8tNR1lTzVnl0AWHeAL+sLDLi4k=; fh=NWaaAAM/CwI4dd5Ijg1P4dpcr7h2ioTc7VpbPCmU7IY=; b=MNHMiNZbzBfMySOw9AiEfKaqGYIn/genFrTQeDDz2+mxyuwDsPjt0Vsayv4+kDwJYB oQqnpUPT/HSSqoMVLvIJjOFZ7BfwpOf9qvrnRKDMKI2xqAzMJjnP3uyhUo+LMwYaXAes 07pLazkebo7sC1eosZxJNPajKSVA0DTJE83ZdLqTICNpXFP09LB1loB3fkM2H0bbujKh sC8YGLWAOoujuChT1EhWVifXDAOK3kp6DuZ2BM1AoSOj8a8o9O54AZ0pEYb7znX8zVTR w0xe+Jx9yzWo5S3IMepc1wGUmpdZVuSAeHlnVBmWBxL08+SpY87DmoJeRsD9VTqzFz+u 4ctg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hEsrVwG2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id y16-20020a056a00191000b0069023e4bca8si4897475pfi.214.2023.10.18.11.32.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 11:32:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hEsrVwG2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 2F0048100DB4; Wed, 18 Oct 2023 11:32:26 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232144AbjJRScO (ORCPT + 99 others); Wed, 18 Oct 2023 14:32:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230483AbjJRScN (ORCPT ); Wed, 18 Oct 2023 14:32:13 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EC53119; Wed, 18 Oct 2023 11:32:11 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A1B8C433C7; Wed, 18 Oct 2023 18:32:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697653931; bh=tOqSoJfV6UaA+IPipuWQfTMZpKrjsZ4IKE5zi0uW75Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hEsrVwG26XgWeooyYzpdHRZizqpNkD/qWqR4Pm4qMBYXfVYDYvY3AjObVH9iTtBoP NdwFAX5OA1bWSK90CZ1tmYQ1jaN4XGZu2L3OKX+d36MpWX/qBRCUZ2NGYKm2Uu4mN5 zhXSPExIU/oB2I3iEKXFuQNfkAlqVuBrUd+lvlEUD7g2+rknHH1ZKKtkHEHYglGEwu ct1+4lmRuyhyj+RvXLEC4nmcRCTwLDwxJ4ruin67DLYjfIl33o+9lbwXe2YWnHiqeb MSehl76slfRpmBpSBNxNznHjg1cu02Ze2BlE2WzZO41GnAzD+yvH+S3IpIOGDBaofP vJCbmMVelOgLw== Date: Wed, 18 Oct 2023 19:32:30 +0100 From: Jonathan Cameron To: Ivan Mikhaylov Cc: Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v6 0/2] Add maxim max34408/34409 ADC driver and yaml Message-ID: <20231018193230.60736165@jic23-huawei> In-Reply-To: <20231014211254.16719-1-fr0st61te@gmail.com> References: <20231014211254.16719-1-fr0st61te@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 18 Oct 2023 11:32:26 -0700 (PDT) On Sun, 15 Oct 2023 00:12:52 +0300 Ivan Mikhaylov wrote: > Add Maxim max34408/34409 ADC driver and yaml for it. Until now it > supports only current monitioring function without overcurrent > threshold/delay, shutdown delay configuration, alert interrupt. > > Changes from v1: > - minor changes from Rob's comments for yaml > - add ena, shtdn and make 4 inputs for R sense from Jonathan's comments for yaml > - add _REG suffix and make prefix for bitmasks and statuses > - add SCALE/OFFSET instead of AVG/PROCESSED from Jonathan and > Lars-Peter comments > - add chip data from Jonathan and Lars-Peter comments > - minor changes from Lars-Peter and Jonathan comments for driver > > Changes from v2: > - add channels into hardware description into yaml > - add rsense property per channel > - rename pins for shtdn and ena pins > - make one array for input_rsense values > > Changes from v3: > - change *_34408_OCT3 and 4 to *_34409_OCT3 and 4 > - change of_property_read_u32 to fwnode family calls > - add i2c dev table > - change of_match_device to i2c_of_match_device > - change match->data to i2c_get_match_data > > Changes from v4: > - minor changes in yaml > > Changes from v5: > - name and minor changes to properties in yaml from Rob's comments > - shtdn-enable-gpios -> powerdown-status-gpios from Krzysztof and > Jonathan comments in yaml > - minor changes to driver > > Ivan Mikhaylov (2): > dt-bindings: adc: provide max34408/9 device tree binding document > iio: adc: Add driver support for MAX34408/9 > > .../bindings/iio/adc/maxim,max34408.yaml | 139 +++++++++ > drivers/iio/adc/Kconfig | 11 + > drivers/iio/adc/Makefile | 1 + > drivers/iio/adc/max34408.c | 276 ++++++++++++++++++ > 4 files changed, 427 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/maxim,max34408.yaml > create mode 100644 drivers/iio/adc/max34408.c > Series applied to the togreg branch of iio.git and pushed out as testing. We are very late in the cycle, so this is probably destined for 6.8 Jonathan