Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <c8d43894-7e66-4a01-88fc-10708dc53b6b@amd.com>
Date:   Wed, 18 Oct 2023 13:50:35 -0500
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To:     Hans de Goede <hdegoede@redhat.com>, kys@microsoft.com,
        tglx@linutronix.de, hpa@linux.intel.com
Cc:     x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
        "Petkov, Borislav" <Borislav.Petkov@amd.com>
From:   Mario Limonciello <mario.limonciello@amd.com>
Subject: PIC probing code from e179f6914152 failing
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?am1McTU3T2dKWEdDSDF0UTFRRmhMOU5pT1Y2Tk1WVWw2Yis5TTMvS1FzMFln?=
 =?utf-8?B?RDR0TVN5K2hNY1JCc1FYVVcrVUhzUXpQczV2ZkpIZURZczRQdEhacU4xelR3?=
 =?utf-8?B?Wm9OVkRwTmhmSDhDM09zUXJJTFh3eEFValFFWUsxWC9aUnRFRmp5anNLaktZ?=
 =?utf-8?B?OWl0bjMwbkI3NkVJNlM2dXFYOTU2bFZKbjgxcklWK3hpek5DQW9FMDA2cHlC?=
 =?utf-8?B?YU9wNG4vSk5XZkc1NU15OGF4VFQ3b1hZMERNQzhmTEdqenRmd3VOeEwwMEtH?=
 =?utf-8?B?S1ZsV3NoSHR0eVhyRjJCVnNmTkQ3U1JOM0VZTHBuWmlYdWxnTEJzVXRhZ0o1?=
 =?utf-8?B?YW9XN0MwN1o3ZzZOUzRaQ0RYWGlZQmhSOWl5eEQzZTR1ZWIvSVFrTG9KeGll?=
 =?utf-8?B?dFBER1ZuRUJ5MWdqNjBpcmFJR0NLeG5abjY3bkZyclBua3UwVFBlMG5zNDhW?=
 =?utf-8?B?U0UwdU4yWjhvVlV1SHlaZ2xlZ2dNU2I0VnlnTW9qV1VERXp4czcwUUExSWds?=
 =?utf-8?B?blpkTWpPSzBaQVZTc3NRT3FpWlVlZ2lKN3NyTUM0d2luZEZPelo4aExWTGwz?=
 =?utf-8?B?T0ZGM1pJTGRldE1aTmRya29renAyaDlJQnNWMTdtbWhlRVRJeDFHNjFvVVlV?=
 =?utf-8?B?d0JpeURTcUVuTytZcnNFaG9vNG9mdlNBNTN3aHVHVk9HSGtObFY1VnluNjRa?=
 =?utf-8?B?ZDZnU29NK1BjQnlxTkdoL3BudkNOb0I5KzREK2VNUk83bU94U1hZVkczNGlr?=
 =?utf-8?B?R2ZkSDl4RCtPb2UxY1poVTZKWDdUdXVZRlRLL2did1V1SGI0L24zcVBzbDlY?=
 =?utf-8?B?RVlRZGxtdk5LQjVUVU9CMmgwekhyYXhVMytyd1d2RUdIRUNmeDV2ZklGVkVN?=
 =?utf-8?B?Zld6YjRqRXFlVmVLVmpxWkJWeUE0cGw5bUQ0QkJGRUlOd0o0YjQ5bEsyZ3hD?=
 =?utf-8?B?ekdjSFJpaXhNN1hiVFg4cG5IZVM1TkdwL3krK1V5dHZKb1Z2UmFwRHZJblho?=
 =?utf-8?B?d2V3UERBL0o1ZWJKTURQWG5DR0E4UGQyK0hZTGVnZk1nY05lZm1Sazkva05a?=
 =?utf-8?B?RjhCWTJWTndJbHdZV3FUTUorSmE0TEFISmRRNnRXaUhIUTFtWjlmakpma2Fr?=
 =?utf-8?B?SDQ4UFp2SkphQkRYb0RmeHAzV3oyMHdlaW1ENUt3dFgxOWhjY0drTmVMQllK?=
 =?utf-8?B?SW8vS2QvVW8yZ2hWQzJKL2twK3NwS1JXYjlFQ1FVeVJDOFY1eGpOVDJXSjJ6?=
 =?utf-8?B?Y3htZXh0Qm4xRnhxQkM5bW5ZRUpveVpKREN3b3k2RzNoU2kvZE9LMXZYdWlH?=
 =?utf-8?B?YXZzRVJxV1h3djZuMCtsVnB0Mlo2UlhEM0FlYkdKOXZmbUZKWGlPc3hIbEFk?=
 =?utf-8?B?Si9yUXRkNnJWU2lmMFpWVVd4QmhlaHZWSzVoSWtlNjNQenJ4R25jU2tEUnNa?=
 =?utf-8?B?RDc2RzdBSStPQ1huL3BJV2dUUVR4TmJNUlh0UWxYTnd1N0F5bXBwNUt4aGVr?=
 =?utf-8?B?MFFDOFVqUmJ1ajFGL1FRSWF5cXlTdlBxSmI0ejVZNlIvTkVpTmVSRTNoWmg2?=
 =?utf-8?B?ODNscHJoSHZSQjgzZTNTTDNtdjNqMW82eWUzRDZqQ2pEV0tXVnl0NEgrTEZ6?=
 =?utf-8?B?Q0JORkwyR29udmRUd0FLTldCdjRsTnYxbVhLTVVUWjd5MG54aVVIVlR5Q1No?=
 =?utf-8?B?S2llR085QjYxdEduczJhVCs0VFIvNWZYbThMVmdoUy9YSU1JYU56YWgvY1Nq?=
 =?utf-8?B?eUVvOGlDQmlRdlJvb1hHcFg0YjRtM01PVXRzM09BS25lR0VFNEdRakFnMjZE?=
 =?utf-8?B?ZmFpb0NTUUw1M3FEVlZPK0NERENZODRFMzRFaVdvWC93NjgyWjI1UFdsb2dt?=
 =?utf-8?B?LzNJTXRsdnRUZVpjcWFyLy9ZblFnU1NQR1FVNmpWcEFqTTJiZFpqTmc4VXpR?=
 =?utf-8?B?d2hKckhmai82YS9VTDhRNmFDTnpBVUhxeDhxWVBSdXprcDlrb1hwK0VvK2tV?=
 =?utf-8?B?T08yUDdIazdEQmo4OUoyblV5bTJxVlppSDJxdTNOM1RTSDdiTkxQdUVZbTBy?=
 =?utf-8?B?TUtsbWNTeHZFTDhJOFMvUUJNZlpiTmRnR1h1cUl4LzlRMmMwWTZxR0c2emRa?=
 =?utf-8?Q?xR9jHlGhgZkMEZQU8AWDXKPjI?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: df8b697f-27fa-41f6-2196-08dbd00b1dee
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 18:50:36.9821
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RE4KOo8YoPGUvOZqNBv/UWeNzyG6njyFeL2dkl+Rql2bPF8nHC20q3RrvyXGlMTH2lJH6FdVaZPzKwPa05KGBg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR12MB8491
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 18 Oct 2023 11:50:55 -0700 (PDT)

Hi,

Recently an issue was reported to Bugzilla [1] that the Keyboard (IRQ 1) 
and GPIO controller (IRQ 7) weren't working properly on two separate 
Lenovo machines.  The issues are unique to Linux.

In digging through them, they happen because Lenovo didn't set up the 
PIC in the BIOS.
Specifically the PIC probing code introduced by e179f6914152 ("x86, irq, 
pic: Probe for legacy PIC and set legacy_pic appropriately") expects 
that the BIOS sets up the PIC and uses that assertion to let Linux set 
it up.

One of the reporters confirmed that reverting e179f6914152 fixes the 
issue.  Keyboard and GPIO controller both work properly.

I wanted to ask if we can please revert that and come up with a 
different solution for kexec with HyperV.
Can guests instead perhaps detect in early boot code they're running in 
an EFI based hypervisor and explicitly set 'legacy_pic = &null_legacy_pic;'?

[1] https://bugzilla.kernel.org/show_bug.cgi?id=218003

Thanks,