Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp4040865rdg; Wed, 18 Oct 2023 13:07:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEHn8pG6DvMGEcVEdYHehSI5AvMlGPuPRw3XYKb0u38UrjmPgq1KFPreiXomBmWTDWa+dZS X-Received: by 2002:a92:c68a:0:b0:34d:ea35:842b with SMTP id o10-20020a92c68a000000b0034dea35842bmr398029ilg.27.1697659652090; Wed, 18 Oct 2023 13:07:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697659652; cv=none; d=google.com; s=arc-20160816; b=EU2Ipgt0jDG2e5Wl+k/Du1bSrdczhivRAZ3hjO8jzNbGSucUnClNXUeETCSjSD3K95 YttwqDWPpV14uy29wg2gHYsmqTjdNC02KOreAiq+LQI0UfTNmTf/+1ogO7fTYtdz0oqj EAqqdRyCjBz+kq1JtbocOOO86xRRzaH0FITa8PvBbx+mR5ZYQYFiTz0V/mL4oul0i9Y6 DbXWUoYyGgl8oOxbWCmvVi4Yxqg0EuzZdzWVdrdXkMePUjt859tCgezXFZlMq7mUWuIJ OJtsL1ufY3wXvu4VKU3Px/6PnYjOLrxIJHa67weMQ+5Iurf7ikM4l8AVGjUhStIl31Il dosQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=sPhmrOEAGSKzMIjkwCvY5cv2O4ZSIOLkxAjWrHEja3w=; fh=Kspjops5NLWHnGTKD4MZ7PeLL8gCU7a4nLovNDucgQA=; b=k+DV3yw+85IdMHI0bSxvKCfeIzXHof9fDg2AAkoDwFQkFxniYLYFEwuidC2Ngf4ATw CJ5BrPO5Y0xtzk3A1tQQ9vbpYC3d+ji6eBL03KHHixXnWzuRbW2xT78ejWPFCzN2e9A0 qcEmu6gQzp0vWo5Vr4JO4iFPTprdpV1ciI0Aa1wo6T0BXhiBwrJKAOQScipzpyuVf1V6 wv3mVD13M1B8WyPQhgsyig3+WwxMAszCFrcJZuEr5v/syk8T6PYT6cEtZIizAs5dIkgu 6njhrlLmTWA40GsdBq7/wn5IlyVzlr5VX2/qz+TpGDzp58vHb4R8c3+N5/albE1JzzkD ym5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=qGImROqC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id p20-20020a056a000a1400b006be26499bbasi4950611pfh.278.2023.10.18.13.07.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 13:07:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=qGImROqC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 7F8248215C14; Wed, 18 Oct 2023 13:07:28 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231823AbjJRUHR (ORCPT + 99 others); Wed, 18 Oct 2023 16:07:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231753AbjJRUHQ (ORCPT ); Wed, 18 Oct 2023 16:07:16 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5997126 for ; Wed, 18 Oct 2023 13:07:10 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-40662119cd0so2185e9.1 for ; Wed, 18 Oct 2023 13:07:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697659629; x=1698264429; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sPhmrOEAGSKzMIjkwCvY5cv2O4ZSIOLkxAjWrHEja3w=; b=qGImROqCUOY96TrtmHXS+8iirCCu5lM5bTlxcKNGoO5ltnV79akvZdjA4NXuJSmJYR SOuLE/shapWsFPZEuLPAgpbs5LixNtCbhoy4iJsTScsT+0SBiUciFf5wQygrjXqZwP94 vwN5piFoZ+tRtCol6sSUuincCy323JUyYJFAAsLT9eKkQznXH1uFz6XGQzfvZ176sFy0 T8MpHNudCOx/W3ULIPInVnccro3vaMKwRzBv6mc4/nrmgnppykVP6zG/nejt3+syLbLM 7YFM9+qzk3AybTHrbTqskpT7ExW/jmKu7gqigiVVuheyUql05exeMorWQ/5B0u4wj4cx m+Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697659629; x=1698264429; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sPhmrOEAGSKzMIjkwCvY5cv2O4ZSIOLkxAjWrHEja3w=; b=AbBkS59t81E/jUuj3Gp0AV4Q5b6BsLaJfO8p5BcvH3NvQXN3e7WTVqvtACkf4ANC+k yDwBW/RzlfvkEZQmuBSo8Dbj7P094teNzKIKfaQV786Wk5VSNRCAsebRUMYQDw0gmeCC QF9QHb1u5KZEnnoL8S2OKDEfy845nzf6lDhsn7WtYYFGh5NzsCnQtTkRYEDlFcE1L70n unIRghVNLvK3Hs0Kb/SK0kwyzQMTs5Y3753IZ97ixG0Adu2apswioOSeESsJUYt4dkou IVNWShIiNSFBfbrFwdfw2Q0ipkVe4OzWW/58j7BFriK1L4TDkCPJDZHkT9SAI7eqO4aW cqyw== X-Gm-Message-State: AOJu0YwAqLbQjTEYsqqdEQ+PdN5JTK+xIJ946W0GReWqaSmrU/2wVAi8 tJTAbRZ/4a46RjgMHdSw+wTH07sst+Z9RtJdAYn5qw== X-Received: by 2002:a05:600c:1c1b:b0:405:320a:44f9 with SMTP id j27-20020a05600c1c1b00b00405320a44f9mr6026wms.5.1697659628765; Wed, 18 Oct 2023 13:07:08 -0700 (PDT) MIME-Version: 1.0 References: <20231016225617.3182108-2-rdbabiera@google.com> In-Reply-To: From: RD Babiera Date: Wed, 18 Oct 2023 13:06:57 -0700 Message-ID: Subject: Re: [PATCH v1] usb: typec: altmodes/displayport: verify compatible source/sink role combination To: Prashant Malani Cc: heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org, badhri@google.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 18 Oct 2023 13:07:28 -0700 (PDT) On Tue, Oct 17, 2023 at 2:33=E2=80=AFPM Prashant Malani wrote: > OTOH, perhaps you should just introduce a macro that performs this > bitwise operation for even better > readability. Something like > > #define DP_CAP_IS_DFP_D(_cap_) (!!(DP_CAP_CAPABILITY(_cap_) & > DP_CAP_DFP_D)) I'll take this approach, thanks for the feedback Prashant! --- Best, RD