Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Wed, 18 Oct 2023 16:18:18 -0400
From:   Frank Li <Frank.li@nxp.com>
To:     Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc:     alexandre.belloni@bootlin.com, miquel.raynal@bootlin.com,
        conor.culhane@silvaco.com, joe@perches.com,
        linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
        imx@lists.linux.dev
Subject: Re: [PATCH 4/5] i3c: master: svc return actual transfer data len
Message-ID: <ZTA9ir2zlFs7tC5D@lizhi-Precision-Tower-5810>
References: <20231016154632.2851957-1-Frank.Li@nxp.com>
 <20231016154632.2851957-5-Frank.Li@nxp.com>
 <af35a533-2126-4a61-a6cd-31ed1e615f2b@linux.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <af35a533-2126-4a61-a6cd-31ed1e615f2b@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bGNdrQpt3OwTvKwLLTTmIPo4K5zV7wRNQ3Fu7XCPip7C8OwIk4x1xD6KQlFp?=
 =?us-ascii?Q?j40zmvfSQ/sYMM1WGTLbq9cskw5k8Cs2/6Tv+UXXQ0aRgIDqnyMnbQFMk62i?=
 =?us-ascii?Q?XH2+gcqrY7HF36ZqhKbhzUdG8MB3vJFvOmlVcbwqkHjttifXRsUAt2/intc1?=
 =?us-ascii?Q?gtzYATofWwTPZtcflIYE2N7PcsHqjQd5Ps2gmYftoKW0KuTG61/QncMyrNKx?=
 =?us-ascii?Q?FLcgr55WiWmvNJCuVXqYqkPPT5/8TccNHHI/QgIawIijqaTkg7X8uaHyrVe6?=
 =?us-ascii?Q?NvkMBDDWEAJZpdEMd3zglxdwArdE/kzFnlRepBvURM8dIHZ9Z13A+PcL8zWa?=
 =?us-ascii?Q?b1dnrkwbq7ihfRKZfsOHnMF+/CcY1scVEsZAH9NILMfZT0L262cWlX/T1PWh?=
 =?us-ascii?Q?174OmCXjb3FxuqfuAhcoRmos6ym+Zd72nFH0St35AnoB/D/4dmUsaooGbP5X?=
 =?us-ascii?Q?Oajx7u+X2siMMTaZwK7WiqztlP0MeIUDDcMuKVrHWsSvG3oXsBuORVj2z/Ju?=
 =?us-ascii?Q?Pp52gt5/PM/ZvWc5Z5El0BR0m/G12O9reOQFUVzIXUyGYoc9I/L+8E2Oj7IH?=
 =?us-ascii?Q?SiylEjeODhnZ6eNicXgf3xvvBL6JEbKYF+qc9C/XH028/gEzriHd8V59IjBU?=
 =?us-ascii?Q?F8T23Y2tzEbbVNNHyUhNp3pszrjQ/Am68rc1YLrQVT5W7tS/qgfhkE5XWW7B?=
 =?us-ascii?Q?X1gUC7jlzPjba1RBEkJf4mKm7pIMtNudtrPE5oIBnpuQe5JTJfZUWg7Hjy6v?=
 =?us-ascii?Q?nTZzyxHiBPJNcbY8wBojvg5vuLl9y7deJLMhPYjYUkMCz6E4LcSlM608H20K?=
 =?us-ascii?Q?7LxMV5Or7S91k3Kg50YrYaU1kzUK3a5coEWOKwCamkRDTpRxhLaaHc/ioRPz?=
 =?us-ascii?Q?JOA0Ga/uoxVWDVRxxy6XhI+mdeYz81Kf2zQDMID5oLFE8WGlEdCBJqgMl7LD?=
 =?us-ascii?Q?CwIMAS2/7bdxQuqIrimSxv5pkrEBDdp0tLLBzy9RRUQKZXMkPZi3IBsk8qP3?=
 =?us-ascii?Q?4HzAr4NEPYSBLotdzx+ybaf5LhDHmsg87BNEcVZinaBsh+HzUfRXmXf47okO?=
 =?us-ascii?Q?CY7M37U/r+YByqpSDVzsBG8f90uPleU7o3bAyM3nWrsxJVB6c3xIVRKdOFmX?=
 =?us-ascii?Q?gHlIyMQb3N6Ph4uJmt59aTK68drVt9gtGJzwaofI41lLHFuGmLM4F/E6Wmdg?=
 =?us-ascii?Q?UFYCpOrz0kvT7pFVIZk00RR01SC2+RjxETgZ4TIK8DrfKbhZ5rTTAeG7L5fB?=
 =?us-ascii?Q?dVRUEWcwbqlUtTZDtBvOimponxEo7NxcSjdJsp/HdzuRizOY9i7vQQb25jEJ?=
 =?us-ascii?Q?9VXM3cByuu+Z6Txvn4zjzYHT6VDqID0AyJymsQ21gNz4UweAjiTDIZrTOtXD?=
 =?us-ascii?Q?Kqo77SvUwpENTYsBghfFPiw6u0/ezJMpErvqikBwHdMLeHyYjwr8WpuY0GcJ?=
 =?us-ascii?Q?EJEG9RM7ZAwrKEhuea1qnhEA8j+D0qpUJx3uzjpYLM7hrK7VE+m0fEHs9k5g?=
 =?us-ascii?Q?LQ3SSkTW1XLnHP/4UJl2cT/lewmZA2c0nbbL25cRgohoEB4GCHBV3u+Mm7NO?=
 =?us-ascii?Q?c+Fj7jSJEn/euozFtkA=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd7eac22-d6ee-4ea1-f428-08dbd0176232
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 20:18:25.4707
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: e+QK0DYw1F8N7p9zEQU0+7sCCkqZNnb4hi3uav4Iw+9oH1vz5LJ5zimARmyh1QLi3VquEmn8lLE8RXC6PELsBw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6978
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 18 Oct 2023 13:18:39 -0700 (PDT)

On Tue, Oct 17, 2023 at 11:33:34AM +0300, Jarkko Nikula wrote:
> Hi
> 
> On 10/16/23 18:46, Frank Li wrote:
> > I3C allow devices early terminate data transfer. So set "actual" to
> > indicate how much data get by i3c_priv_xfer.
> > 
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >   drivers/i3c/master/svc-i3c-master.c | 7 +++++++
> >   1 file changed, 7 insertions(+)
> > 
> > diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> > index 3570b709cf60..444825aafa6f 100644
> > --- a/drivers/i3c/master/svc-i3c-master.c
> > +++ b/drivers/i3c/master/svc-i3c-master.c
> > @@ -138,6 +138,7 @@ struct svc_i3c_cmd {
> >   	const void *out;
> >   	unsigned int len;
> >   	unsigned int actual_len;
> > +	struct i3c_priv_xfer *xfer;
> >   	bool continued;
> >   };
> I'm thinking would it make sense to combine this and previous patch by
> removing the read_len/actual_len variable from this structure and use the
> added one (by the patch 2/5) from "struct i3c_priv_xfer" directly?

Some I2C transfer and CCC use svc_i3c_cmd, in such case xfer is NULL. Keep
len/actual_len is more simple.

Frank