Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp4068874rdg; Wed, 18 Oct 2023 14:06:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHmkJrkJORW8VUwflzTPWE0GKU1hCCVJxe7fksecmP+PJ7wzaQGVkFNLbA4w4/kkQYG43Bo X-Received: by 2002:a05:6e02:1ba1:b0:357:47a3:adbd with SMTP id n1-20020a056e021ba100b0035747a3adbdmr607957ili.30.1697663187576; Wed, 18 Oct 2023 14:06:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697663187; cv=none; d=google.com; s=arc-20160816; b=JkrnapQhQsdUw9xdW8Modr/pwRYHDB8/ur6WLJ/p1n914pK6KGx2FLhWFPAfwzM1yI jzk2jLZffzJVDDxCCeTZTZ2IZJyXnUvPffjFV6o37vQP7CRRQ60Stcsa/vkGBlApLgYo /88fhNByIz3LVzL2x17RCe9V2u4JKLwNRDxjet676e8oYCm/VElxunJ5/vPHGrxYl7Eh XFaW3CBI1JrQ47fz/vtFuG2GEt9tgVtEgRjJi8MA+VNUYn3CqOb5n0KAG+1jvQWVLI+/ l79mPdiLAVbm4nF3km1EFLDQH8A+t+z6YxZCdO/7/9hIvgdp04fH7Kh3K1w4k3e+y3MX 5nNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :message-id:subject:cc:to:from:date:dkim-signature; bh=i6HDm3KEs8T2GQLsXLeqQWG6VZ3xY7h5jNpl5PQ0NMA=; fh=SlrGJFzqoiWa1CCjM7Xk2Tue5rqPH5l7fQgiL/JUGcM=; b=G2wc0KGwGSRAVxYT4NMKm5pvEMiL4VQCKI5Sdv7qr3kIWtqtwiomYj567l49gbJr3v HiDvwJV8U42/dfIS7rmki5/5fsKycFN+SVJZqbDr/yVmgqm4FMiD7350LPRKmjO4m0oQ 3VVjhYoCicf53ig8YrwxzhcIeT8w5gf58ilZVbf61r4hq5o7mkR3zR8usyERlnkKh4qp sNmKS/TiCYoetyK0j5Amptoz4/2bXXcq+aFuXc+clcNLXtrvhfyXvg9K+KiP2FqLzuKh FFw0xZdjeinpKU5Jsy0ZaaoDLc036o4vlHrWFKXB5ymqsUUFR+/vGg2Fp3avJzFh4MEB t7Pw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=twja5Mih; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id ka40-20020a056a0093a800b006be08015248si5066033pfb.294.2023.10.18.14.06.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 14:06:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=twja5Mih; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id EE3C0822A4BD; Wed, 18 Oct 2023 14:06:23 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231848AbjJRVGE (ORCPT + 99 others); Wed, 18 Oct 2023 17:06:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232111AbjJRVGA (ORCPT ); Wed, 18 Oct 2023 17:06:00 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 831D026B9; Wed, 18 Oct 2023 14:00:16 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9CC6FC433C8; Wed, 18 Oct 2023 21:00:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697662814; bh=+oTS7I7JNI/J+BTOhgsPn3eiiZsLYX0DDk0p+Z+nkIQ=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=twja5MihZhvKa4MTYlWZKHIUiXXeRMPTGvbNT6sC1ZKwv6fz+/BbsW/hhikmCDb/d 8L97wx09Tkmxh3rcM/sBj1CyNswnnqXiMQtHgULtiW406x49GCwDsJ5idV5tEbe8v7 isWBrPh7P7eWr7RLM4tayr4P/VskZfkDHGd2VxLwzs01hhscCGiwzlSU8HyzAd+/ye GCgyiRFSsyx0BnCK9C7rBjhMndMlx3DMMhVzmZ7xlOGLHq5EUTn7SV9niL3Pe7Q+KR YjKPGQWA/T3GSH/qWxps9zjGkbcTa3Nlx/Ufv7qB9PcGJz5DW86F9LZT+DYPuE2Ge0 FEpp6qsFAUMYw== Date: Wed, 18 Oct 2023 16:00:13 -0500 From: Bjorn Helgaas To: linux-pci@vger.kernel.org Cc: Ilpo =?utf-8?B?SsOkcnZpbmVu?= , Jonathan Cameron , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Lorenzo Pieralisi , linux-kernel@vger.kernel.org, Bjorn Helgaas Subject: Re: [PATCH 00/10] PCI: Use FIELD_GET() and FIELD_PREP() Message-ID: <20231018210013.GA1377253@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231010204436.1000644-1-helgaas@kernel.org> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 18 Oct 2023 14:06:24 -0700 (PDT) On Tue, Oct 10, 2023 at 03:44:26PM -0500, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > Use FIELD_GET() and FIELD_PREP() to avoid the need for shifting. > > These apply on top of the PCI patches from Ilpo's series: > https://lore.kernel.org/r/20230919125648.1920-1-ilpo.jarvinen@linux.intel.com > > Bjorn Helgaas (10): > PCI: Use FIELD_GET() > PCI: Use FIELD_GET() in Sapphire RX 5600 XT Pulse quirk > PCI/ASPM: Use FIELD_GET() > PCI/ATS: Show PASID Capability register width in bitmasks > PCI/ATS: Use FIELD_GET() > PCI/DPC: Use FIELD_GET() > PCI/PME: Use FIELD_GET() > PCI/PTM: Use FIELD_GET() > PCI/VC: Use FIELD_GET() > PCI/portdrv: Use FIELD_GET() > > drivers/pci/ats.c | 7 ++--- > drivers/pci/pci.c | 53 +++++++++++++++++------------------ > drivers/pci/pcie/aspm.c | 31 +++++++++++--------- > drivers/pci/pcie/dpc.c | 9 +++--- > drivers/pci/pcie/pme.c | 4 ++- > drivers/pci/pcie/portdrv.c | 7 +++-- > drivers/pci/pcie/ptm.c | 5 ++-- > drivers/pci/probe.c | 8 +++--- > drivers/pci/quirks.c | 2 +- > drivers/pci/vc.c | 9 +++--- > include/uapi/linux/pci_regs.h | 15 ++++++---- > 11 files changed, 81 insertions(+), 69 deletions(-) I applied these to pci/field-get for v6.7, thanks for all the reviews!