Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
MIME-Version: 1.0
References: <20231018013851.3303928-1-saravanak@google.com> <20231018104029.zairwt4nzub33ekr@pengutronix.de>
In-Reply-To: <20231018104029.zairwt4nzub33ekr@pengutronix.de>
From:   Saravana Kannan <saravanak@google.com>
Date:   Wed, 18 Oct 2023 15:25:59 -0700
Message-ID: <CAGETcx8uB6i2jt_9gvhcbzARNhy_r-byZxvdLp=mTywFEHNDbQ@mail.gmail.com>
Subject: Re: [PATCH v1] driver core: Release all resources during unbind
 before updating device links
To:     =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Yang Yingliang <yangyingliang@huawei.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Mark Brown <broonie@kernel.org>,
        Matti Vaittinen <mazziesaccount@gmail.com>,
        James Clark <james.clark@arm.com>, kernel-team@android.com,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Oct 18, 2023 at 3:40=E2=80=AFAM Uwe Kleine-K=C3=B6nig
<u.kleine-koenig@pengutronix.de> wrote:
>
> On Tue, Oct 17, 2023 at 06:38:50PM -0700, Saravana Kannan wrote:
> > This commit fixes a bug in commit 9ed9895370ae ("driver core: Functiona=
l
> > dependencies tracking support") where the device link status was
> > incorrectly updated in the driver unbind path before all the device's
> > resources were released.
> >
> > Fixes: 9ed9895370ae ("driver core: Functional dependencies tracking sup=
port")
> > Reported-by: "Uwe Kleine-K=C3=B6nig" <u.kleine-koenig@pengutronix.de>
> > Closes: https://lore.kernel.org/all/20231014161721.f4iqyroddkcyoefo@pen=
gutronix.de/
> > Signed-off-by: Saravana Kannan <saravanak@google.com>
> > Cc: Thierry Reding <thierry.reding@gmail.com>
> > Cc: Yang Yingliang <yangyingliang@huawei.com>
> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Cc: Mark Brown <broonie@kernel.org>
> > Cc: Matti Vaittinen <mazziesaccount@gmail.com>
> > Cc: James Clark <james.clark@arm.com>
> > ---
> >  drivers/base/dd.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> > index a528cec24264..0c3725c3eefa 100644
> > --- a/drivers/base/dd.c
> > +++ b/drivers/base/dd.c
> > @@ -1274,8 +1274,8 @@ static void __device_release_driver(struct device=
 *dev, struct device *parent)
> >               if (dev->bus && dev->bus->dma_cleanup)
> >                       dev->bus->dma_cleanup(dev);
> >
> > -             device_links_driver_cleanup(dev);
> >               device_unbind_cleanup(dev);
> > +             device_links_driver_cleanup(dev);
>
> Tested-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>
> Acked-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>
>
> This indeed fixes the crash I experinced before.

Thanks for the Tested-by!

-Saravana