Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp38350rdb; Wed, 18 Oct 2023 17:20:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEyPi1irzpE7BzyQKxeOVzFvhucBl4iICpFfv2e1zT34F1JhNVQEFSUVnYalYasYOhqxrka X-Received: by 2002:a05:6359:3015:b0:166:d11b:f94c with SMTP id rf21-20020a056359301500b00166d11bf94cmr506904rwb.15.1697674851229; Wed, 18 Oct 2023 17:20:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697674851; cv=none; d=google.com; s=arc-20160816; b=HvJ7j79uvwwshEFzDAlUn1UdSQg9gh32/qAR9QvEMO23sJiGEdmEBoNO3IVwJu+CKf x950yIN6QtiU1jk5VtN5FgqJwlhUnN+yyj/zDrgYJFlmVD4iQ1CVxLbfUc7uM3AKFbCX rqRVaX8kxoiptfkqH0AxtuESXce9sGI/F/kOg8eMjEUp5BQhoMIjj6eNj7LGxYNWyCZa d5oa17y4CxksdGXD1684KKhXyYWwqQFGN7m6TtgKETd2irSilJ0CQI4Hf+PA7/7B/e1J xbPbYyK51s09x9zFYgMgBOrPL2H9SFlYroL0v+yeKhdsEfmqLwWCrsoGE/Gi7W3TEbMn 1MEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=ba4xVdRKpwoMsjmusYne5kUzBB7KFSfDdeqkTqEkZcQ=; fh=dpc/RH+yb/BzzOInEYvSpWZCi0n1Brz3skmvA8va+5U=; b=ghPwXEEjLsP2I3yvwn0GA8ROapfRnuz686fKTPGtItQCQfrxYFdAAV3D6OHy14LB7G aQ/cMPWpsb5UIqBoEbGcqnhVu1IeYcpF/eNfEmFXTS695JgH1VaWr5bYYAZyDgTVMaNe pS9K5lq3QWoP1lb4lUDUEIPCRhPtZ+uvhoBd8+TbKY94wGZxdXSYhhcgORPNXUNmA0Sr 9RLneolgXB0/q3xJIXeiIDf8yBx6J+vYk9KzVTpdZoZwmwcmcK8Olz5i6IQbmOA587WA PHdtnQTmYEwU2M0CnFA49jaojECFdmTPK3GGm6yQAVdhzBHvKiyyPYpKuBE2fkbRG6BF j1PQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EtTjOL6T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id b30-20020a63715e000000b00565e0624182si3066386pgn.404.2023.10.18.17.20.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 17:20:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EtTjOL6T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 3186B807F4A3; Wed, 18 Oct 2023 17:20:24 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231441AbjJSAUJ (ORCPT + 99 others); Wed, 18 Oct 2023 20:20:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229632AbjJSAUI (ORCPT ); Wed, 18 Oct 2023 20:20:08 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA904FE; Wed, 18 Oct 2023 17:20:06 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1753FC433C8; Thu, 19 Oct 2023 00:20:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697674806; bh=dxFpRFGQyZYIt12hrHgMufWeqE05AdXR2afP4eEpMLU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EtTjOL6T7kpVGiMQBlY9JUSeIpRaurrIM4JwgzxgVfML6zjp89ZXotZhHt0JTWOk7 uDzhIRAcEWdRCHC/LLDwrIbj0fQKwQz1Vze+94phMo0XZbKViWkJie8TY89DF7gl4i aPjAd7qDPTPyI0RCzmsoPFesF9ZAZDFnC/NrQw7TAwp5E+KCe3IK3dB7Pwqij6bLlC BkF0xxU5lXKleXt6sJyC7zT71JpESUlIjVSiTGb2Jvejo35jb/ykViTcbOs9Gh3e/3 fnMDSMq5MgN/NFn4khDuhTqF4m38BINMJ6M7769H9qzcYxGKMudRLN8GPgylceOstA CdAZAkyJpbyaw== Date: Wed, 18 Oct 2023 17:20:05 -0700 From: Jakub Kicinski To: Breno Leitao Cc: sdf@google.com, axboe@kernel.dk, asml.silence@gmail.com, willemdebruijn.kernel@gmail.com, pabeni@redhat.com, martin.lau@linux.dev, krisman@suse.de, "David S. Miller" , Eric Dumazet , bpf@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, io-uring@vger.kernel.org, Willem de Bruijn Subject: Re: [PATCH v7 03/11] net/socket: Break down __sys_setsockopt Message-ID: <20231018172005.6c43c7ca@kernel.org> In-Reply-To: <20231016134750.1381153-4-leitao@debian.org> References: <20231016134750.1381153-1-leitao@debian.org> <20231016134750.1381153-4-leitao@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 18 Oct 2023 17:20:24 -0700 (PDT) On Mon, 16 Oct 2023 06:47:41 -0700 Breno Leitao wrote: > Split __sys_setsockopt() into two functions by removing the core > logic into a sub-function (do_sock_setsockopt()). This will avoid > code duplication when doing the same operation in other callers, for > instance. > > do_sock_setsockopt() will be called by io_uring setsockopt() command > operation in the following patch. Acked-by: Jakub Kicinski