Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp38475rdb; Wed, 18 Oct 2023 17:21:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFgEBWZzRsYlCOmudRjaWTSAkEHXdTDb3XIiQUA+gtnO10JqHVn9+W/YGTOkX5n6ixBLGbA X-Received: by 2002:a17:903:210d:b0:1c9:97b7:b3cc with SMTP id o13-20020a170903210d00b001c997b7b3ccmr720572ple.47.1697674872414; Wed, 18 Oct 2023 17:21:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697674872; cv=none; d=google.com; s=arc-20160816; b=C/OICbcBkJjgXQWrq7Wj72jhS9+pJzzSej2z8OOQepBDD0Y4jVNB/fXvBsKv2pFo5/ 8ugiVfQZyE94XiGopvGTyfjroYNu9P/CHUvP2XnQiVRndrY0DdsXotN0rrJ5dHvmvFFs 8HlTE/a0Myd8YX0mmD+aVGgoRLujr/32CLxcyZZeAjD/6Xy3qh5CGnt1Ephf5D3IxQwI V8N1IwkDYwpaNsFBMsR7gAflhAksSSATNzIat9A2fDicuAPhh/cJ8CLIgM/gtI0rnHDY S+0dK/efCWCzTePdTCkyDOcxzIDShroDDe+5L06XM3XOvmO3kwUoVFNnUq2f9blZNs1p 42bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=Y6nGRhaR9zVGBQcghlXh035lD7L6pJt2YNq7ExrznJ0=; fh=/J7beGSTUAFDqt0/dtD5T0c4taL//q4xb82FGc/u27A=; b=LItkL+dXujx5hLipxvp9pPv+EHOFbCIwxFD2UACiZhvPJDdsRwFgBhTDmZAFq/L7ck X88yDiwUGZ/J6y4KFEEtBFlC3c8dHYz8MfrB0rG7AOvQ7lQJP3dXalK+aObaqo+qKffH Q7iYlG96f62R8aCUFzKAuzBAMGGh53v4CFGT1RLTNyyjzGgKfMqMJu4oXsVmmNpxCLPg sF/ALg9HWO+8zjwXgpViqTXGUuexy8k8LEJPz0PRkgw9t1hCszxPy9Mn9n8tYYFJ5q4P MYHkiwDakq3GOaxHRzW2zltayeVRNXC9P0orY0xNpD7x5UxJulPw8SiyTKwmdT9oB08l RzzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oi1nzjBs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id c8-20020a170903234800b001bb6d711625si1132041plh.279.2023.10.18.17.21.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 17:21:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oi1nzjBs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 8FA4F8119053; Wed, 18 Oct 2023 17:21:08 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231199AbjJSAUs (ORCPT + 99 others); Wed, 18 Oct 2023 20:20:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229632AbjJSAUr (ORCPT ); Wed, 18 Oct 2023 20:20:47 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29356FE; Wed, 18 Oct 2023 17:20:46 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA7E5C433C7; Thu, 19 Oct 2023 00:20:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697674845; bh=6mkAdLVLxxj7Xv3eDlTxWghk2v1vUqjiipEg5azs62c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oi1nzjBsLq/buGnHUgogCnUHbtfYpxvg1o0LSse9LWwgv13hdLFVVu9aGGox2h4XW YNly5QO5nO3SivjfcEJ/VTeY/Ma/dodZxNG7w7knPmc0rdSUSCCmRrLKLxRnFiTVtD UIhe0o4KuM+2GtuNE5vtZX7/O0V35JLAEuYXyit0N2byQIDWYiCwH+9jOTv9Oluddr 8OpbNuvxLYXVx3Fiq+DHt6IEehmRu7sjZqX3o46MWrGbjvoGkssKp68P+cgo0VY8Q5 KwE8LFj0hXTRMkWDxO82S7abZbu4PS7hdxoZ+QcjVTByhhobpMY9B+PomZKoc9Qzgp 2VWb41EQeOC8w== Date: Wed, 18 Oct 2023 17:20:44 -0700 From: Jakub Kicinski To: Breno Leitao Cc: sdf@google.com, axboe@kernel.dk, asml.silence@gmail.com, willemdebruijn.kernel@gmail.com, pabeni@redhat.com, martin.lau@linux.dev, krisman@suse.de, Alexei Starovoitov , Daniel Borkmann , John Fastabend , Andrii Nakryiko , Song Liu , Yonghong Song , KP Singh , Hao Luo , Jiri Olsa , "David S. Miller" , Eric Dumazet , bpf@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, io-uring@vger.kernel.org, Kuniyuki Iwashima , Alexander Mikhalitsyn , David Howells Subject: Re: [PATCH v7 04/11] net/socket: Break down __sys_getsockopt Message-ID: <20231018172044.008dab81@kernel.org> In-Reply-To: <20231016134750.1381153-5-leitao@debian.org> References: <20231016134750.1381153-1-leitao@debian.org> <20231016134750.1381153-5-leitao@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 18 Oct 2023 17:21:08 -0700 (PDT) On Mon, 16 Oct 2023 06:47:42 -0700 Breno Leitao wrote: > Split __sys_getsockopt() into two functions by removing the core > logic into a sub-function (do_sock_getsockopt()). This will avoid > code duplication when doing the same operation in other callers, for > instance. > > do_sock_getsockopt() will be called by io_uring getsockopt() command > operation in the following patch. > > The same was done for the setsockopt pair. Acked-by: Jakub Kicinski