Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Message-ID: <13d7cf46270082855174414b691fb3be.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20230827023932.501102-1-sergio.paracuellos@gmail.com>
References: <20230827023932.501102-1-sergio.paracuellos@gmail.com>
Subject: Re: [PATCH v2] clk: ralink: mtmips: quiet unused variable warning
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     tsbogend@alpha.franken.de, mturquette@baylibre.com,
        linux-kernel@vger.kernel.org, ndesaulniers@google.com,
        arnd@kernel.org, yangshiji66@outlook.com,
        kernel test robot <lkp@intel.com>
To:     Sergio Paracuellos <sergio.paracuellos@gmail.com>,
        linux-clk@vger.kernel.org
Date:   Wed, 18 Oct 2023 17:32:02 -0700
User-Agent: alot/0.10
Precedence: bulk

Quoting Sergio Paracuellos (2023-08-26 19:39:32)
> When CONFIG_OF is disabled then the matching table is not referenced and
> the following warning appears:
>=20
> drivers/clk/ralink/clk-mtmips.c:821:34: warning: unused variable 'mtmips_=
of_match' [-Wunused-const-variable]
> 821 |   static const struct of_device_id mtmips_of_match[] =3D {
>     |                          ^
>=20
> There are two match tables in the driver: one for the clock driver and the
> other for the reset driver. The only difference between them is that the
> clock driver uses 'data' and does not have 'ralink,rt2880-reset' compatib=
le.
> Both just can be merged into a single one just by adding the compatible
> 'ralink,rt2880-reset' entry to 'mtmips_of_match[]', which will allow it to
> be used for 'mtmips_clk_driver' (which doesn't use the data) as well as f=
or
> 'mtmips_clk_init()' (which doesn't need get called for 'ralink,rt2880-res=
et').
>=20
> Doing in this way ensures that 'CONFIG_OF' is not disabled anymore so the
> above warning disapears.
>=20
> Fixes: 6f3b15586eef ("clk: ralink: add clock and reset driver for MTMIPS =
SoCs")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202307242310.CdOnd2py-lkp@i=
ntel.com/
> Suggested-by: Arnd Bergmann <arnd@kernel.org>
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> ---

Applied to clk-next