Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Thu, 19 Oct 2023 09:23:13 +0800
From:   kernel test robot <yujie.liu@intel.com>
To:     Frank Li <Frank.Li@nxp.com>, <miquel.raynal@bootlin.com>
CC:     <oe-kbuild-all@lists.linux.dev>, <Frank.Li@nxp.com>,
        <alexandre.belloni@bootlin.com>, <conor.culhane@silvaco.com>,
        <imx@lists.linux.dev>, <joe@perches.com>,
        <linux-i3c@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/6] i3c: master: svc: add hot join support
Message-ID: <202310190611.b14M4mH3-lkp@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231018205929.3435110-3-Frank.Li@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iRepuQAfEnmnoxqL0u+WyCYgx+eDLNUEAGkhzHA+y4/+HHQQilNKMcxnOhp3?=
 =?us-ascii?Q?8pkQt1K0sdGKnhBmQCulwcWRZsk0DpJ4r/gPkv80OA/PFdIqs9B7f8b/kI8h?=
 =?us-ascii?Q?DYu9a0z+ieTjeiMlfI1rANZ3X3fEoPGBMfh0377OsTbYBKcbNmkNwJLAKDlM?=
 =?us-ascii?Q?ggoSBuMm+t73oOkBfMGyCUZMYvgS1sjrilR0A7ukzpC8b0KVDd1z4u60GIu2?=
 =?us-ascii?Q?ua4XBeYDCW/FIIZbQK0toH/WshDwno3s2YXIC9dt1ocL6sD16Wjh5d6WwDwg?=
 =?us-ascii?Q?5PoWAk+ouBrHgKfVLtF64cKn1ZS8REJ4pOsh1Nc6CL4rewq9CXunMN3IqIii?=
 =?us-ascii?Q?oqRi5mbSDNIcF74W3D3bN53yWmh8EtqFN/xDwpkqJ7Vq/Vtlsk03lgT/++xp?=
 =?us-ascii?Q?S02tgLmvhjXNCWCm01j790rGDldDqvhdjEPNAYgBbV78bsEcmo06K4MecTrF?=
 =?us-ascii?Q?UZud1jMbTxLwOG4vip+2ClqVe+4Md9wxhsT4PBtm8o2Xfi4bFYxJqGjhn/36?=
 =?us-ascii?Q?18StJKmlQ6JOySiGuUavkGzGb/p6djlLVMcPUoeFy9hazfzoe2rnLMaXnHCn?=
 =?us-ascii?Q?jXt8pHuilHPgsrPgShB+7/L5VTrJJM3MQykuKnQhwdBLCVbMsfyQ5e7hTIXN?=
 =?us-ascii?Q?6+zaR77rj3jTt0lV5HDOu+VdTU51Crt9O4/A6/9ls9KegUyoDG8hp40aTjtw?=
 =?us-ascii?Q?Mj6spZYYRRuAsNo7sb5sWaT3k20yqioJy1LHezgxEDtbuhdko0d+trJpp+aa?=
 =?us-ascii?Q?RqFH0ZJL4N1L4clUQUNAPsljKVZxJNSNZtWINqnVwf5MxstezoenHVWpTYv6?=
 =?us-ascii?Q?ri8Stv8lwGwi8GCpsai4UeCeWis07fJQRTZkXGesYHuDa1hTevw6vDmc01zu?=
 =?us-ascii?Q?6WOOumoQa17V0dOnuMb0XdhHUgr8QCYNOkLbF4gygdUdRgvQqlgEb9zIDTM0?=
 =?us-ascii?Q?ievEVUdZO/IAz81f/yLBa8z85arqwUK8TWxsFDcdjXPcVd16v9fj+gp49LRk?=
 =?us-ascii?Q?mAtW6xUZ9nEYN/o/UJH4yu0hIp8FYt4XZ45rWBT9vi0K3WrZIklI9JrJyt5h?=
 =?us-ascii?Q?AXfTcJg7mVYNno0zYuk5pBRflu/8o15vXvXrwTyzhG7SSbR9QmbXSkekmSeM?=
 =?us-ascii?Q?4TnvwnJKJvgnf2LL1DfHEG+I2jhVursEtqUHzvcgf4uBZzMOI+FmsZXDc9q0?=
 =?us-ascii?Q?HUMfBm2XAEFMgIJumsqPLAgUFN21VsE3RHrg+f8FD4obrElZLvBhiqfQ8SNV?=
 =?us-ascii?Q?CYMT629jBhd0vEwiS7Cpm8CVTR5UJK9kJibuywJagLIOk/lgBAJOg1vXZzUD?=
 =?us-ascii?Q?uF33yiDYN8S9vmRYbJur7MmLJNU4ODIc01iCFyHQff+6mKPjL5O1bWe9OgML?=
 =?us-ascii?Q?xuvPUAbOKZvfaqzsHe8JsqwEuDNCpDc43aewzb/4OKIx3PMtPm9P0vQznZLc?=
 =?us-ascii?Q?KOmLf9KQ4BFfcolfdkimH83JTiXJPQYOLzyDtHwHiNgrw+QXAXu+FGmqfN6N?=
 =?us-ascii?Q?MEICN7dbkk7nPz4vcrwYH+zdM/g9KsmC1vU41f0Wb/FmRkkyvLEHXapno9HN?=
 =?us-ascii?Q?xJZN2fZJ+t//Q4QHiLbZAzr5YcAV19DUaj0/jkJU?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bfdb78da-de38-4dd7-887f-08dbd042a3f0
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6392.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2023 01:28:04.3066
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eg9ByuUwr2qaVE20cKeaRs2YSyqhbYd1z6xIBeq+oQ2yeMl74+jpGu5dBngN3KsSMJsD8kbheqEoJ6qgrJTZhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7514
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 18 Oct 2023 18:28:33 -0700 (PDT)

Hi Frank,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.6-rc6 next-20231018]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Frank-Li/i3c-master-add-enable-disable-hot-join-in-sys-entry/20231019-051444
base:   linus/master
patch link:    https://lore.kernel.org/r/20231018205929.3435110-3-Frank.Li%40nxp.com
patch subject: [PATCH v2 2/6] i3c: master: svc: add hot join support
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20231019/202310190611.b14M4mH3-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231019/202310190611.b14M4mH3-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <yujie.liu@intel.com>
| Closes: https://lore.kernel.org/r/202310190611.b14M4mH3-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/i3c/master/svc-i3c-master.c:212: warning: Function parameter or member 'lock' not described in 'svc_i3c_master'
>> drivers/i3c/master/svc-i3c-master.c:212: warning: Function parameter or member 'enabled_events' not described in 'svc_i3c_master'
   2 warnings as Errors


vim +212 drivers/i3c/master/svc-i3c-master.c

1c5ee2a77b1bac Clark Wang    2023-05-17  157  
dd3c52846d5954 Miquel Raynal 2021-01-21  158  /**
dd3c52846d5954 Miquel Raynal 2021-01-21  159   * struct svc_i3c_master - Silvaco I3C Master structure
dd3c52846d5954 Miquel Raynal 2021-01-21  160   * @base: I3C master controller
dd3c52846d5954 Miquel Raynal 2021-01-21  161   * @dev: Corresponding device
dd3c52846d5954 Miquel Raynal 2021-01-21  162   * @regs: Memory mapping
5496eac6ad7428 Miquel Raynal 2023-08-17  163   * @saved_regs: Volatile values for PM operations
dd3c52846d5954 Miquel Raynal 2021-01-21  164   * @free_slots: Bit array of available slots
dd3c52846d5954 Miquel Raynal 2021-01-21  165   * @addrs: Array containing the dynamic addresses of each attached device
dd3c52846d5954 Miquel Raynal 2021-01-21  166   * @descs: Array of descriptors, one per attached device
dd3c52846d5954 Miquel Raynal 2021-01-21  167   * @hj_work: Hot-join work
dd3c52846d5954 Miquel Raynal 2021-01-21  168   * @ibi_work: IBI work
dd3c52846d5954 Miquel Raynal 2021-01-21  169   * @irq: Main interrupt
dd3c52846d5954 Miquel Raynal 2021-01-21  170   * @pclk: System clock
dd3c52846d5954 Miquel Raynal 2021-01-21  171   * @fclk: Fast clock (bus)
dd3c52846d5954 Miquel Raynal 2021-01-21  172   * @sclk: Slow clock (other events)
dd3c52846d5954 Miquel Raynal 2021-01-21  173   * @xferqueue: Transfer queue structure
dd3c52846d5954 Miquel Raynal 2021-01-21  174   * @xferqueue.list: List member
dd3c52846d5954 Miquel Raynal 2021-01-21  175   * @xferqueue.cur: Current ongoing transfer
dd3c52846d5954 Miquel Raynal 2021-01-21  176   * @xferqueue.lock: Queue lock
dd3c52846d5954 Miquel Raynal 2021-01-21  177   * @ibi: IBI structure
dd3c52846d5954 Miquel Raynal 2021-01-21  178   * @ibi.num_slots: Number of slots available in @ibi.slots
dd3c52846d5954 Miquel Raynal 2021-01-21  179   * @ibi.slots: Available IBI slots
dd3c52846d5954 Miquel Raynal 2021-01-21  180   * @ibi.tbq_slot: To be queued IBI slot
dd3c52846d5954 Miquel Raynal 2021-01-21  181   * @ibi.lock: IBI lock

* @lock: <description>
* @enabled_events: <description>

dd3c52846d5954 Miquel Raynal 2021-01-21  182   */
dd3c52846d5954 Miquel Raynal 2021-01-21  183  struct svc_i3c_master {
dd3c52846d5954 Miquel Raynal 2021-01-21  184  	struct i3c_master_controller base;
dd3c52846d5954 Miquel Raynal 2021-01-21  185  	struct device *dev;
dd3c52846d5954 Miquel Raynal 2021-01-21  186  	void __iomem *regs;
1c5ee2a77b1bac Clark Wang    2023-05-17  187  	struct svc_i3c_regs_save saved_regs;
dd3c52846d5954 Miquel Raynal 2021-01-21  188  	u32 free_slots;
dd3c52846d5954 Miquel Raynal 2021-01-21  189  	u8 addrs[SVC_I3C_MAX_DEVS];
dd3c52846d5954 Miquel Raynal 2021-01-21  190  	struct i3c_dev_desc *descs[SVC_I3C_MAX_DEVS];
dd3c52846d5954 Miquel Raynal 2021-01-21  191  	struct work_struct hj_work;
dd3c52846d5954 Miquel Raynal 2021-01-21  192  	struct work_struct ibi_work;
dd3c52846d5954 Miquel Raynal 2021-01-21  193  	int irq;
dd3c52846d5954 Miquel Raynal 2021-01-21  194  	struct clk *pclk;
dd3c52846d5954 Miquel Raynal 2021-01-21  195  	struct clk *fclk;
dd3c52846d5954 Miquel Raynal 2021-01-21  196  	struct clk *sclk;
dd3c52846d5954 Miquel Raynal 2021-01-21  197  	struct {
dd3c52846d5954 Miquel Raynal 2021-01-21  198  		struct list_head list;
dd3c52846d5954 Miquel Raynal 2021-01-21  199  		struct svc_i3c_xfer *cur;
dd3c52846d5954 Miquel Raynal 2021-01-21  200  		/* Prevent races between transfers */
dd3c52846d5954 Miquel Raynal 2021-01-21  201  		spinlock_t lock;
dd3c52846d5954 Miquel Raynal 2021-01-21  202  	} xferqueue;
dd3c52846d5954 Miquel Raynal 2021-01-21  203  	struct {
dd3c52846d5954 Miquel Raynal 2021-01-21  204  		unsigned int num_slots;
dd3c52846d5954 Miquel Raynal 2021-01-21  205  		struct i3c_dev_desc **slots;
dd3c52846d5954 Miquel Raynal 2021-01-21  206  		struct i3c_ibi_slot *tbq_slot;
dd3c52846d5954 Miquel Raynal 2021-01-21  207  		/* Prevent races within IBI handlers */
dd3c52846d5954 Miquel Raynal 2021-01-21  208  		spinlock_t lock;
dd3c52846d5954 Miquel Raynal 2021-01-21  209  	} ibi;
85bebb554b09b1 Frank Li      2023-10-16  210  	struct mutex lock;
e00571e38f466c Frank Li      2023-10-18  211  	int enabled_events;
dd3c52846d5954 Miquel Raynal 2021-01-21 @212  };
dd3c52846d5954 Miquel Raynal 2021-01-21  213  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki