Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <b8dd0150-dcd4-4936-aa50-958fe8867911@vivo.com>
Date:   Thu, 19 Oct 2023 10:24:46 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/2] tracing: mm: multigen-lru: fix mglru trace
To:     Yu Zhao <yuzhao@google.com>, Jaewon Kim <jaewon31.kim@samsung.com>,
        Kalesh Singh <kaleshsingh@google.com>
Cc:     Steven Rostedt <rostedt@goodmis.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Suren Baghdasaryan <surenb@google.com>,
        Vlastimil Babka <vbabka@suse.cz>, linux-kernel@vger.kernel.org,
        linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org,
        bpf@vger.kernel.org, opensource.kernel@vivo.com
References: <20231018082104.3918770-1-link@vivo.com>
 <20231018082104.3918770-2-link@vivo.com>
 <CAOUHufbc9j-6yfcm_4h_qD5L1oq6KRVXxA1u+mx0dXBqtghjYQ@mail.gmail.com>
From:   Huan Yang <link@vivo.com>
In-Reply-To: <CAOUHufbc9j-6yfcm_4h_qD5L1oq6KRVXxA1u+mx0dXBqtghjYQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WDAxV1NIeG9MOXdqMmZWOU1YTXFGQW5OY29CMTRqWGJIT2xtUmJLck9kMVBs?=
 =?utf-8?B?QnQxcXRCcnE4TzJWZUhiNmdTKy9WRjdvd1lQa21hcGRZVFJRWkR5d0xlU2JI?=
 =?utf-8?B?eFBHMU92OEdoMmZuYkplZlBtRzhlcE5YMUdYeHMza3lvYVhiMUpwUkRRTWE3?=
 =?utf-8?B?K1Rpa2dxTFRmelNHRmVyMitTaUd4cWNWcmxqaHhTaWR4Yk1rRXJacUhTMUx4?=
 =?utf-8?B?YzVsS2xFeFEvZ0l1dVVOUVMyVktzcXVPNWRaV3hDS25lcTY3akNBYkd5M1JU?=
 =?utf-8?B?b1dnaVdzWGdaWXNrVHlON3VDRkx3SE5JdVFEM3NvWUU3ZGIzRUFERGlIdThU?=
 =?utf-8?B?MFVxUGhTeEcvS0dVdHhzQmhDZ09YSG9qdXpGb0NrRDd5alE5UlhyeDlnMnZS?=
 =?utf-8?B?bTg3eDVYenZpSms4cytRUmwwVFNod1d2UkxsNm40c09SRkhKdkUyc0Q4d2ov?=
 =?utf-8?B?VlRYUFRHM00rUjJKODVlQ25WaDJZRXZYU2tHUFhMejNvWHpTdEpzZCtnckx6?=
 =?utf-8?B?UFFHS1lLTkdCc0lBOXYxajRkd3hyZGkvL3FyRXpReTNLU29PVnZCSGU4OGQ1?=
 =?utf-8?B?QndjRFFaYkpoSXprQWQ2UmdwdFo3bmNDa1VJeUYyM2xQOXFjZkFoQnRxUDNm?=
 =?utf-8?B?R29FVTQrL0pRUzhLTTNIV0dxYXNsVHovT0JjVHV4VFZ3MzN4Znc4bVZJZGcw?=
 =?utf-8?B?UmNVKzdJWlZ6c0RIY2dreUtLbXcwUlhKSlErTmMzL0R1V1Q5TVZYNE0zTEMz?=
 =?utf-8?B?SnR3N1hDTVB4Y0J3dndWVk1kZWR6ZzlQcW8vWkptRXJLQjlqaXU4V200dkJV?=
 =?utf-8?B?M2hBblMvNVZNY0x0NWNXb245VDdnaWp2a1NJNm5hejBpTituOFJXU3kvYW5K?=
 =?utf-8?B?V1M1QkgyNWRtY1dGRXZsVW15TXk3S2tWM2M3R1RpRU50L3BFeTJuaVByMUF6?=
 =?utf-8?B?ZXkrYUUzQUptNC9ENzdhcDVIS3JlYkw5OEwxRkZxWjhMMlpBT1pqZVVOaWdk?=
 =?utf-8?B?bkh1dUtHc2JzN1A5Z3U0YW5kZW1VMkx6S2h4SWV4L3hCdXN4UVFYWkhYNmR2?=
 =?utf-8?B?UEJJWjNYZjEwNG1iVnZhRUJ3TlNvV1ZZM0Z5QXNsVDBwQjZJQjBSbkljeElI?=
 =?utf-8?B?dy84bUxuYXZ1b0NjUzRxYVdHeTBpNEx0Q1RCdWk0bUpxVzJlcTYzbDUxVWRZ?=
 =?utf-8?B?TE1VZERucVB6QTV3V1VrZFlBUkVuSFJya2NPMGxwdzA3UGxxczlqRzdGRitO?=
 =?utf-8?B?eUdyTXlSRjRVemJ6YjNEeEhEWTM0emlUdkkvWm5WQStleW5TNWFtTDhNdFJF?=
 =?utf-8?B?MS9qZWxKdFAvcWppK25BMllsR0psWUtxUmo0S3JIVWwwcmpEcU9yRzV4Y2dZ?=
 =?utf-8?B?ZnJQem5WY3h2S1FQbmhRTnhqWFdLd0tKUFpRTlZFTXFNelN5ZjZ6NXhsU3h3?=
 =?utf-8?B?QTFxM1RYZXIzOFJyMDd4K3dWUWZXVGRNRzMvTXl2UVBwdGJWV0VVTHJtWUZH?=
 =?utf-8?B?RjBMZVB0NXU2QmtXTExtdHlhTjArRUgyS3c3VDV2dEJVUkhZcmhOWFBkVWhO?=
 =?utf-8?B?SEtrMnoxNHh5d2F1V2NPeWhBOFJ0cThBdGpUR0pMckhGbXZjcDJ3cGgyZFRM?=
 =?utf-8?B?MXBYUk0vWmtsMFpKQmpLNGlCNzhqS04wNFBEV2RQNmRMVVdiNGlueWgwWW9a?=
 =?utf-8?B?T2RXUG9BUVUzNXZINU9EN2xuSVJMekszMDFVMWVnTkU5U0tneTJkeEt5emJD?=
 =?utf-8?B?a3graFBkUmFSeFpDSXN1bG5WeStRUGZXMHloZWRqeDZSeTBZeTlld1hsbjFL?=
 =?utf-8?B?UTQrN2tJUEZaWWx1dkloVEtDWXBYcktzVStxY1J0Slk0dElhRFF1eUw5SG8r?=
 =?utf-8?B?ODN2NXFrQlMrYjJabnlGbHpLS0crVktyNm5adEoybVI3dFhML1gwUjE4blZp?=
 =?utf-8?B?WVVNaTJtUnh6dXUwM3k5M3AyL3ozVy9TUy8rM1dXUDdNSFg2RUZ6blVNMFFS?=
 =?utf-8?B?cmJVclV1MlM1RFJGUGp2MGZ2VDRtVmUxNTFXU2dFbjB1UWZMdE1uNU9IZm1q?=
 =?utf-8?B?Y2dUOHRGc3lkNWU3dVgvU0dpT0pwVnFBZlJkdlJ0eWx2Nm0yd2dQeGdhbGNi?=
 =?utf-8?Q?usReNiaCOly1Zrpi6ij8yA83R?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a053b88-5890-48bf-7caf-08dbd04a9240
X-MS-Exchange-CrossTenant-AuthSource: PUZPR06MB5676.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2023 02:24:50.5695
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PzfHSZCXvRP55cEBe/rppNYzwHifA5COpkd10Z8xG7qAAWjMYouEl1t6KQwtKxeKdgokP8tN4WyTuy2yT+7lEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB6878
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 18 Oct 2023 19:25:19 -0700 (PDT)


在 2023/10/19 0:28, Yu Zhao 写道:
> On Wed, Oct 18, 2023 at 2:22 AM Huan Yang <link@vivo.com> wrote:
>> This patch add two reclaim stat:
>> nr_promote: nr_pages shrink before promote by folio_update_gen.
>> nr_demote: nr_pages NUMA demotion passed.
> The above isn't specific to MLGRU, so they should be in a separate patchset.

OK, nr_demote isn't MGLRU, separate is good, but, if this, nr_demote 
isn't need by
myself, I just add this when I see this code. :)
Please see nr_promote and nr_scanned fix  is MGLRU need?

>
>> And then, use correct nr_scanned which evict_folios passed into
>> trace_mm_vmscan_lru_shrink_inactive.
>>
>> Mistake info like this:
>> ```
>> kswapd0-89    [000]    64.887613: mm_vmscan_lru_shrink_inactive:
>> nid=0 nr_scanned=64 nr_reclaimed=0 nr_dirty=0 nr_writeback=0
>> nr_congested=0 nr_immediate=0 nr_activate_anon=0 nr_activate_file=0
>> nr_ref_keep=0 nr_unmap_fail=0 priority=4
>> flags=RECLAIM_WB_FILE|RECLAIM_WB_ASYNC
>> ```
>> Correct info like this:
>> ```
>>   <...>-9041  [006]    43.738481: mm_vmscan_lru_shrink_inactive:
>>   nid=0 nr_scanned=13 nr_reclaimed=0 nr_dirty=0 nr_writeback=0
>>   nr_congested=0 nr_immediate=0 nr_activate_anon=9 nr_activate_file=0
>>   nr_ref_keep=0 nr_unmap_fail=0 nr_promote=4 nr_demote=0 priority=12
>>   flags=RECLAIM_WB_ANON|RECLAIM_WB_ASYNC
>> ```
> Adding Jaewon & Kalesh to take a look.
Thanks, Huan