Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
MIME-Version: 1.0
References: <20230925131720.7672-1-mark-pk.tsai@mediatek.com> <7e68377e780a2f4312a69ce8afda0cda8ad84568.camel@mediatek.com>
In-Reply-To: <7e68377e780a2f4312a69ce8afda0cda8ad84568.camel@mediatek.com>
From:   Xuewen Yan <xuewen.yan94@gmail.com>
Date:   Thu, 19 Oct 2023 14:27:17 +0800
Message-ID: <CAB8ipk8ELiSYc7z-wyrnD68UnfF6uQe=XDG5BYsXYPDrR2Z08Q@mail.gmail.com>
Subject: Re: [PATCH v2] ARM: vfp: Add missing VFP instructions to neon_support_hook
To:     =?UTF-8?B?TWFyay1QSyBUc2FpICjolKHmspvliZsp?= 
        <Mark-PK.Tsai@mediatek.com>
Cc:     "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
        "matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
        "angelogioacchino.delregno@collabora.com" 
        <angelogioacchino.delregno@collabora.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "xuewen.yan@unisoc.com" <xuewen.yan@unisoc.com>,
        "linux-mediatek@lists.infradead.org" 
        <linux-mediatek@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        =?UTF-8?B?WUogQ2hpYW5nICjmsZ/oi7HmnbAp?= <yj.chiang@mediatek.com>,
        =?UTF-8?B?546L56eRIChLZSBXYW5nKQ==?= <Ke.Wang@unisoc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Oct 11, 2023 at 10:51=E2=80=AFAM Mark-PK Tsai (=E8=94=A1=E6=B2=9B=
=E5=89=9B)
<Mark-PK.Tsai@mediatek.com> wrote:
>
> On Mon, 2023-09-25 at 21:17 +0800, Mark-PK Tsai wrote:
> > Add the missing "Unconditional Advanced SIMD and floating-point
> > instructions" in [1] to the VFP undef hook.
> >
> > This commit addresses the issue reported in [2], where
> > executing the vudot instruction on a platform with FEAT_DotProd
> > support resulted in an undefined instruction error.
> >
> > Link:
> > https://developer.arm.com/documentation/ddi0597/2023-06/?lang=3Den [1]
> > Link:
> > https://lore.kernel.org/lkml/20230920083907.30479-1-mark-pk.tsai@mediat=
ek.com/
> >  [2]
> > Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
> > ---
> >  arch/arm/vfp/vfpmodule.c | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> >
> > diff --git a/arch/arm/vfp/vfpmodule.c b/arch/arm/vfp/vfpmodule.c
> > index 7e8773a2d99d..b68efe643a12 100644
> > --- a/arch/arm/vfp/vfpmodule.c
> > +++ b/arch/arm/vfp/vfpmodule.c
> > @@ -800,6 +800,24 @@ static struct undef_hook neon_support_hook[] =3D
> > {{
> >       .cpsr_mask      =3D PSR_T_BIT,
> >       .cpsr_val       =3D PSR_T_BIT,
> >       .fn             =3D vfp_support_entry,
> > +}, {
> > +     .instr_mask     =3D 0xff000800,
> > +     .instr_val      =3D 0xfc000800,
> > +     .cpsr_mask      =3D 0,
> > +     .cpsr_val       =3D 0,
> > +     .fn             =3D vfp_support_entry,
> > +}, {
> > +     .instr_mask     =3D 0xff000800,
> > +     .instr_val      =3D 0xfd000800,
> > +     .cpsr_mask      =3D 0,
> > +     .cpsr_val       =3D 0,
> > +     .fn             =3D vfp_support_entry,
> > +}, {
> > +     .instr_mask     =3D 0xff000800,
> > +     .instr_val      =3D 0xfe000800,
> > +     .cpsr_mask      =3D 0,
> > +     .cpsr_val       =3D 0,
> > +     .fn             =3D vfp_support_entry,
> >  }};
>
> Could someone please kindly review this patch?
> Thanks.

I tested on unisoc sharkl3 platform, and no problems occurred.

Tested-by: Xuewen Yan <xuewen.yan@unisoc.com>

Thanks!