Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp173325rdb; Thu, 19 Oct 2023 00:20:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF6icVGL2GtZUgS9jP7aDDYeEitN5S4UnjvPWJGvUuJitm0u1IIn4tcXLd2nbLSSbIfrQ0N X-Received: by 2002:a25:c5cb:0:b0:d9c:66fb:db9 with SMTP id v194-20020a25c5cb000000b00d9c66fb0db9mr1575574ybe.59.1697700057923; Thu, 19 Oct 2023 00:20:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697700057; cv=none; d=google.com; s=arc-20160816; b=0QoYZWYUykuFFfjaepWylZ6CEQDSKObjVv4hlu7RBZ6a5vbcRaiYXsTPtcyAmZOpsU Fp/N3mOpc/L/YWW++CtcCcjkSub76aPXnxOgX7/IaXMZ2I5/dmQ+I9efigb9g3/ipjW9 Oi1qfiIgtqBicqj1hXDQPPH94fXMBiNWl17chQmgSOpsgm9/X7bm+E1kO+xddSv0TyLa vBKbQaV+JW90wseOf+j5yysP5Mz7X6D4dae+Lah45pdjI+nn/sMBc3/uHHgV71kHnCie s1n8Vwt5z3xYK7w4v3oR0Y/JIQSjNDXkyksxKlVPAjF+qblFy5gpDnjdVASTGUdFmumh 1BIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=VJ8K0FN0Qpyz/8G/jYt1sKfnOsJUIjYOYEd3rSEKCTI=; fh=Rvt6yxM89GJZVLUpTccBmJHCEOcxxxpXjXDV6pVduHU=; b=e7kcvR0YX5SoWfa6ucofrbxq96YM4IlzAdeY8bNfV4kxD6tcNwPe3qBmBP8xKEkilS 7e0W6vzpwkBNwzKMlgz2upUoQnAJ4Ps8fEN/AnECdAOOil3/QksQ3mKt3sGctIyOEdYg rEw10yquOELs+utwvM0BdR0DU7ODsF9I3vHe5SY10augSxnwLLXwefKbJppuIidLnlR1 qzpdzjyrq4Izjvow3IXMdSzIqMI8Umnqp0LzlppxCOjaPRopTk54vKbzB+MSpcwG051g 8jGtpQ+kEt1YKQ1gG5YbyNczXdGJfsGHgOmS8cU2C2F1MzTR2cicIe9yv7ZU8y765gwz 3nwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Y36swdJG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id d3-20020a056a0024c300b006bd66ce21d9si5864603pfv.322.2023.10.19.00.20.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 00:20:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Y36swdJG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 5BE1B808599B; Thu, 19 Oct 2023 00:20:31 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232810AbjJSHUX (ORCPT + 99 others); Thu, 19 Oct 2023 03:20:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232788AbjJSHUW (ORCPT ); Thu, 19 Oct 2023 03:20:22 -0400 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E51C9123 for ; Thu, 19 Oct 2023 00:20:20 -0700 (PDT) Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1c9b1e3a809so53037235ad.2 for ; Thu, 19 Oct 2023 00:20:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697700020; x=1698304820; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VJ8K0FN0Qpyz/8G/jYt1sKfnOsJUIjYOYEd3rSEKCTI=; b=Y36swdJGa+L1dp1R0w3vn7LRz/SqYI249DQHo35SPXgRLm/ay8Js+FW1qO95qZrQDw gFsr7NgD30mXpEui62gLYrQiieak0OlR9oLUm5KCrZlG5GTIp1gv3baguAj24dQsS+1n pilmbkEMXtGxSZiTpzqUcTnZq5tV1IqVQf+dZa0LcmR3SesoRwsoafLySyWKEflOn7E9 qCXknOsSN0oNj9eUHuKVF02OaaQtuCBj5Lv3KRpOUHkn7L5GAsMlx2K2BzQZEHhZutBX WARBO6eVNKMHazzvBmRWEMOt4A00jStRQ5h6ld3jHskIdKDa7Je5J5rHS6Rwj2hubV3t FvzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697700020; x=1698304820; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VJ8K0FN0Qpyz/8G/jYt1sKfnOsJUIjYOYEd3rSEKCTI=; b=go+bXV6VIGbSv4E1oYkuJgaTJK0IJpDxq9+3PvePxLWqO9ggbrDhK43Ma7A93dByBE t1FPPWycIuvbSvp790TteBmA6bcwRNy5YW5UgF+h36dynsCG9g987Yo6/9xNLrh+I+Dp wobPrpUtl1/rdMCQifuBrdr3ea9JAgdou+WhE0SextsVV5z/6ZL2dlBTO6/CGPCSsOjE bkwOTWwkro2kJfKOfeKufrcHFdCECGdmDIE48eIRuv1rYnyx99bkewJ/bFLlvWDqAUsv KoEGMS8z0IuNNpDtG35eb5g9TlFG2necK5/kOMut9f9JCqmKT4VnbIGK9oxG7//0DDsN kDUA== X-Gm-Message-State: AOJu0YxzKMDCsofNZKNw5W0dVSIo4Wsi9aGuMPDVbfNikr4YIKnTSIWK NNcNwCAoTrnwvjNvokJxKEOqYx5AAMGnbQ== X-Received: by 2002:a17:902:da8d:b0:1c7:495c:87df with SMTP id j13-20020a170902da8d00b001c7495c87dfmr1971350plx.53.1697700020238; Thu, 19 Oct 2023 00:20:20 -0700 (PDT) Received: from Negi ([68.181.16.134]) by smtp.gmail.com with ESMTPSA id u17-20020a17090341d100b001c1f4edfb9csm1141686ple.173.2023.10.19.00.20.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 00:20:19 -0700 (PDT) From: Soumya Negi To: Martyn Welch , Manohar Vanga , Greg Kroah-Hartman , Andi Shyti , Julia Lawall Cc: outreachy@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Soumya Negi Subject: [PATCH v2 0/2] staging: vme_user: Replace printk's & clean up log messages Date: Thu, 19 Oct 2023 00:20:08 -0700 Message-ID: X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 19 Oct 2023 00:20:31 -0700 (PDT) Staging driver vme_user has a bunch of printk() calls in vme.c which triggers checkpatch warnings. Remove all printk's and change them to the appropriate logging mechanism i.e pr_err()/pr_warn(), or dev_err()/dev_warn(). Also, clean up the messages further by using __func__ in the string instead of function names. This patchset fixes all checkpatch warnings like: WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... & WARNING: Prefer using '"%s...", __func__' to using 'vme_lm_get', this function's name, in a string Patches must be applied in order. Changes in v2: 1. Correct "cleanup" to "clean up" in cover letter. (as per feedback from julia.lawall@inria.fr) 2. Patch 1: Change the pr_*() calls used to replace printk's in v1 to dev_*() wherever possible, as it adds more context to the messages. (as per feedback from julia.lawall@inria.fr & gregkh@linuxfoundation.org) Soumya Negi (2): staging: vme_user: Replace printk() with pr_*(),dev_*() staging: vme_user: Use __func__ instead of function name drivers/staging/vme_user/vme.c | 193 +++++++++++++++++++-------------- 1 file changed, 109 insertions(+), 84 deletions(-) -- 2.42.0