Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp201200rdb; Thu, 19 Oct 2023 01:34:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHqT27f8u1P8Ovo5MwnOyBCcNwPsKgzcyPus8EFFoIo5T5bA/KkQqgNC92s7y6Wl8qV/VVT X-Received: by 2002:a9d:7b4a:0:b0:6c4:9ca1:f13a with SMTP id f10-20020a9d7b4a000000b006c49ca1f13amr1424263oto.35.1697704492187; Thu, 19 Oct 2023 01:34:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697704492; cv=none; d=google.com; s=arc-20160816; b=nxgYCgGYGF9bkUTE7moSpkpGaYpZGJ5v1Vi3Aff5qC1r/LaRU2VCdBSTI3Ovb1BMzP p4XXxYLHYdwruGvW8dlBtMLm8fNMasiLprPMiJwIhNw8053YXqb2aGCS4laG5U0kphHQ 1gb8pPqtbcX+1lI70jn6cQGR4baGJHUEXRbESlOkg+n0XqLAxPua5xczaDjkkBBlGIQ0 I0I0auCiqyckrYB/ejrEQZ2it6Acph1V3Vd3FZ2fLGOXNIp6jPLCgQFb8Atb3jOET3jZ 1DZEsXIpUFqENP5pw+EcBKFPJbERlPYYcmE4SKLCVXfeuWLFGE28swbysheDcs33pZZW HGXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=7kv50cQs3UCG+fU2uiqIuBlCxBVTSQ6SSFeyrsQb75A=; fh=p8gyEH+SCWaVfiIH1yPgxTNMCj6x+b3FaoXznu5N3ro=; b=pD3qGAx324f0t3RlnbmbsVugBLrGhpYMVyc/uSywDZeSFiPfouuM3xtONPXg5lntiF y6cdX0FqRKPkZItO6GtS4PtxHM2AVVaVikzoh5OUND1GCSwzzkYOY2nr2zUnQKADoNaW VZJtK513Q1IcRpLQj0K1FwnNrCi6TMLcN+Zw2jQA54plFfQTx3fEnljaas3TZYJWWEh2 G8TlvO0m8fPb0SVBaxw1Qf4BCJLyeN8f0DekpCHiz3RdhGDQSn9s1Fd0oBvSxBvxt+Y2 9rl9wMeVBD4YB8ki3FMf2KKKIYtQ/PHsy+QA6PRKX0eRo8dMP1Hi38b6JSZcMLWpOeNn y8zA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id h65-20020a636c44000000b00578b487825asi3772000pgc.208.2023.10.19.01.34.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 01:34:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 48A55826E8D4; Thu, 19 Oct 2023 01:34:50 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232383AbjJSIeb (ORCPT + 99 others); Thu, 19 Oct 2023 04:34:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232850AbjJSIea (ORCPT ); Thu, 19 Oct 2023 04:34:30 -0400 Received: from mail.nfschina.com (unknown [42.101.60.195]) by lindbergh.monkeyblade.net (Postfix) with SMTP id 12F3BAB; Thu, 19 Oct 2023 01:34:27 -0700 (PDT) Received: from localhost.localdomain (unknown [180.167.10.98]) by mail.nfschina.com (Maildata Gateway V2.8.8) with ESMTPA id C9F696071E216; Thu, 19 Oct 2023 16:34:10 +0800 (CST) X-MD-Sfrom: suhui@nfschina.com X-MD-SrcIP: 180.167.10.98 From: Su Hui To: shannon.nelson@amd.com, brett.creeley@amd.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: Su Hui , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] pds_core: add an error code check in pdsc_dl_info_get Date: Thu, 19 Oct 2023 16:33:52 +0800 Message-Id: <20231019083351.1526484-1-suhui@nfschina.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 19 Oct 2023 01:34:50 -0700 (PDT) check the value of 'ret' after call 'devlink_info_version_stored_put'. Signed-off-by: Su Hui --- drivers/net/ethernet/amd/pds_core/devlink.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/amd/pds_core/devlink.c b/drivers/net/ethernet/amd/pds_core/devlink.c index d9607033bbf2..09041f7fccaf 100644 --- a/drivers/net/ethernet/amd/pds_core/devlink.c +++ b/drivers/net/ethernet/amd/pds_core/devlink.c @@ -124,6 +124,8 @@ int pdsc_dl_info_get(struct devlink *dl, struct devlink_info_req *req, snprintf(buf, sizeof(buf), "fw.slot_%d", i); err = devlink_info_version_stored_put(req, buf, fw_list.fw_names[i].fw_version); + if (err) + return err; } err = devlink_info_version_running_put(req, -- 2.30.2