Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
From:   Ming Qian <ming.qian@nxp.com>
To:     mchehab@kernel.org, mirela.rabulea@oss.nxp.com,
        hverkuil-cisco@xs4all.nl
Cc:     shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, xiahong.bao@nxp.com, eagle.zhou@nxp.com,
        tao.jiang_2@nxp.com, ming.qian@oss.nxp.com, linux-imx@nxp.com,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: [PATCH] media: imx-jpeg: Drop initial source change event if capture has been setup
Date:   Thu, 19 Oct 2023 16:36:36 +0800
Message-Id: <20231019083636.10762-1-ming.qian@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qlAO2V6SkQvSXZUbvvDTqNPUiPa6SNmgGTSU/pQ4gX6gjytGkQKrejD+xjWN?=
 =?us-ascii?Q?7fAscAVqm3DAWhzlrmQrwUQvZl4y2Y4SW+QqerMTzzENk0B9RgCYuQJevCsi?=
 =?us-ascii?Q?HkYb1k3lK8Tcm64n1XFKQBz+AezxVl3YswI5OAhJNSPZ3dDyyyS+/0pQ/iDR?=
 =?us-ascii?Q?CpxxF/fATBsSdzf8ZJpcFkTdWQRl0cPFqW3ylhFOsilfYBsJYF7D5BFaA06c?=
 =?us-ascii?Q?vbwuzeoyP4mUu6G9BqANU3OFcWm7L5NVaMnCgDaW9NV9RdwlWst8lmPMUzxD?=
 =?us-ascii?Q?ZXiP+OQwnpV3O06CBlR6kDHZvz9WrZS5RxdowTe/MIbsEjEr2Bnbd46l2lfr?=
 =?us-ascii?Q?W3j7Ls3EmUcnSq1s2lWmlFRJuLsRDCulUxd1YaQ4YA9xxJ6wEsM/FjYWPRzi?=
 =?us-ascii?Q?k510652hj26RTWkixhu7vXydB3LwCyS62rkcb3r70g6CrWpXWPiTmkuEZ6ra?=
 =?us-ascii?Q?4LrayloZDyTYV4LttyNd78HYhZGnHii/AVLFhPXcJhE/7Cvrb+g5zNzJVHaJ?=
 =?us-ascii?Q?NYP9WmDHSRjgNUAatAujMs4s+wggAuc2uiOeFi174PH5wbBX36sEXJSzaqvL?=
 =?us-ascii?Q?f/YCwE1X0pIUgaL1kF46j0WGk4WrpwtE4bB5DX2KtVHv/2El7EvWjw89i4q4?=
 =?us-ascii?Q?GuvtOe8AG5lfCHqwbJuYwHFhwp7EX0YpTHzzd4LYtIGuJ24A+fJXqdIO0x3Q?=
 =?us-ascii?Q?/76JPEvG5zVB3QrXJNECiqCJB1diGg3ul7l6WWx6vwxaDToeh5glbcZ3pr+K?=
 =?us-ascii?Q?21vonTilT+Y/ns6UNpq7HRwtpMic/6CY04fETDtKzDC2ZmMr7xBSZbE5p+jw?=
 =?us-ascii?Q?J6i81Wh4D89IMtMO2C661W9/YpM+IOlsWHI7czfNcR4I/St3GobXrxsGkC4c?=
 =?us-ascii?Q?IQp503BauZY5LxeczIw/igPR7Sfg+F5bpZlyzKEs4MWDoJbfE+0q0XuKSc/O?=
 =?us-ascii?Q?v37y7NuJ/PGRaxGTvl/9ZeFXePEqQ4fi2S+5ggp74CE5P/A32FQgs5DBQ2X/?=
 =?us-ascii?Q?QKDhUrdPHJqjCM4q7R5cNowbXwAq0Q4rCr9FW/qisbt83GhPi1rq+kBZU624?=
 =?us-ascii?Q?UgGYUx7UvfBJO4e8uXcRDqJOW85jT8l/iamkdLZBtCY2baO2SIC1W3Py3kee?=
 =?us-ascii?Q?8N93o87pBsYPZzcP1lQaUHUYIFhd6cZn4dwnGt8koa0qSgqk8G/hsigVbxNu?=
 =?us-ascii?Q?tx5CQ/zpwT99m/f8U1vmloL8sZMXo46OzLiyxsL4IqOXVhe9ADK+/mzafEuu?=
 =?us-ascii?Q?2MaaNszkW9HZ/RLz3OlyyN1pZcGfO70wqARu37mFXZfDifmLUTLJI1FQjkDX?=
 =?us-ascii?Q?8/Wtw62eB1icEmm8yYhtvY4xokK4uzbOY8/vzwfVVg+S5bKn+Oc4XQX3IpPK?=
 =?us-ascii?Q?SVJo05XxgZDYq/R8bhkm3Y87gsgBYfV4ABCwgdbk9PH1ZFzn069pf/SH/x6S?=
 =?us-ascii?Q?4jNbTM3rxCK1cwz8wygScV0QJ6fxFfrUM2uJXsd4LFjj7RIC/pjyLnwwBNhr?=
 =?us-ascii?Q?d31mK7f69xEmG0cIoBF5uIzM8pO7EpCmro1oNCHHDWHLqqGkru+hp5MBdf2I?=
 =?us-ascii?Q?5TndHjanRmsr12lvM9xJ8xy6Y5L0NwQoBYuTAaeA?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a08754e4-a84a-4bbc-c47a-08dbd07e87cc
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6341.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2023 08:36:46.7152
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lmGQZde6rzchfSql1nAhz2WNIdlgnAlsvoMyAk1Pesz4AkziGZTv5rCrnN8YJ5GOUF9I7bPuHJtrsgTS8MI/Iw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8724
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 19 Oct 2023 01:37:05 -0700 (PDT)

In section 4.5.1.5. Initialization, the step 4 may be skipped and
continue with the Capture Setup sequence, so if the capture has been
setup, there is no need to trigger the initial source change event, just
start decoding, and follow the dynamic resolution change flow if the
configured values do not match those parsed by the decoder.

And it won't fail the gstreamer pipeline.

Fixes: abf5d3c5bcbe ("media: imx-jpeg: notify source chagne event when the first picture parsed")
Signed-off-by: Ming Qian <ming.qian@nxp.com>
---
 drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
index c538440abe8d..c87603cb4a6f 100644
--- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
+++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
@@ -1632,6 +1632,9 @@ static int mxc_jpeg_start_streaming(struct vb2_queue *q, unsigned int count)
 	dev_dbg(ctx->mxc_jpeg->dev, "Start streaming ctx=%p", ctx);
 	q_data->sequence = 0;
 
+	if (V4L2_TYPE_IS_CAPTURE(q->type))
+		ctx->need_initial_source_change_evt = false;
+
 	ret = pm_runtime_resume_and_get(ctx->mxc_jpeg->dev);
 	if (ret < 0) {
 		dev_err(ctx->mxc_jpeg->dev, "Failed to power up jpeg\n");
-- 
2.38.1