Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <b8fa17a7-296e-4e17-9438-a8be04dbd476@quicinc.com>
Date:   Thu, 19 Oct 2023 14:07:20 +0530
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC 4/8] clk: qcom: gcc-sm8450: Keep usb30 prim gdsc on during
 runtime suspend
To:     Stephen Boyd <sboyd@kernel.org>, Andy Gross <agross@kernel.org>,
        "Bjorn Andersson" <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>
CC:     <linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <quic_ppratap@quicinc.com>,
        <quic_jackp@quicinc.com>,
        Udipto Goswami <quic_ugoswami@quicinc.com>
References: <20231017131944.8356-1-quic_kriskura@quicinc.com>
 <e38ae24c09ef321c224a6b6aeb97e73b.sboyd@kernel.org>
Content-Language: en-US
From:   Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>
In-Reply-To: <e38ae24c09ef321c224a6b6aeb97e73b.sboyd@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/19/2023 6:28 AM, Stephen Boyd wrote:
> Quoting Krishna Kurapati (2023-10-17 06:19:44)
>> When runtime suspend happens in host mode, if cable is removed at this
>> instant, it triggers a resume where a xhci register access is done when
>> gdsc is not on leading to a crash. Keep usb30 prim gdsc as on during
>> runtime suspend to avoid this crash.
>>
>> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
>> ---
>> Note: I am not sure if this is the right way or setting GDSC flags to
>> PWRSTS_RET_ON is the right approach. So for now made this change to
> 
> Does using PWRSTS_RET_ON work? Does the GDSC support being turned off or
> is the lowest power state retention?

I didn't see any issue when I put it as PWRSTS_RET_ON. If the GDSC is 
off, when we remove cable in host mode, we see a crash because of xhci 
register access. But when I try putting PWRSTS_RET_ON / 
CLK_RPM_ALWAYS_ON it doesn't crash.

Regard,
Krishna,