Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <aa593e44-2075-2261-6593-bd120d68be92@huawei.com>
Date:   Thu, 19 Oct 2023 16:47:11 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
CC:     <shaojijie@huawei.com>, <chenhao418@huawei.com>,
        <shenjian15@huawei.com>, <wangjie125@huawei.com>,
        <liuyonglong@huawei.com>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2 drivers/perf: hisi:] drivers/perf: hisi: use
 cpuhp_state_remove_instance_nocalls() for hns3 pmu uninit process
To:     Yicong Yang <yangyicong@huawei.com>, <will@kernel.org>,
        <jonathan.cameron@huawei.com>, <mark.rutland@arm.com>,
        <yangyicong@hisilicon.com>
References: <20231016105139.1436425-1-shaojijie@huawei.com>
 <46461fdf-575d-fa32-28b8-420bf0e54210@huawei.com>
From:   Jijie Shao <shaojijie@huawei.com>
In-Reply-To: <46461fdf-575d-fa32-28b8-420bf0e54210@huawei.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


on 2023/10/19 9:52, Yicong Yang wrote:
> On 2023/10/16 18:51, Jijie Shao wrote:
>> [27169.898241]  kthread+0x168/0x16c
>> [27169.904178]  ret_from_fork+0x10/0x18
>> [27169.911943] Code: 944beda1 aa1403e0 944bed9f f8460f5c (f9400394)
>>
>> And tested some other uncore pmu driver such as hisi pcie pmu and hisi uncore i3c pmu,
> It's l3c pmu, not i3c pmu. Please just use the driver name like hisi_pcie_pmu or
> hisi_uncore_l3c_pmu in the commit. So is below.
>
> Others looks good to me. With this fixed,
>
> Reviewed-by: Yicong Yang <yangyicong@hisilicon.com>
>
Thanks, I'll replace them in v3. Jijie