Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <668b7c50-bcd7-b99e-3438-eceff6594dd7@axentia.se>
Date:   Thu, 19 Oct 2023 11:25:35 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH 1/3] i2c: muxes: i2c-mux-pinctrl: Use
 of_get_i2c_adapter_by_node()
Content-Language: sv-SE
To:     Herve Codina <herve.codina@bootlin.com>,
        Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc:     linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
        Allan Nielsen <allan.nielsen@microchip.com>,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        Steen Hegelund <steen.hegelund@microchip.com>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>
References: <20231019073533.386563-1-herve.codina@bootlin.com>
 <20231019073533.386563-2-herve.codina@bootlin.com>
From:   Peter Rosin <peda@axentia.se>
In-Reply-To: <20231019073533.386563-2-herve.codina@bootlin.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MFJPV1FVWnk3RjdUZFZjdFR1R2JIeHIvZXJlU1pYcFNpWitkWEtiNHVObUNv?=
 =?utf-8?B?N01kSk5YNG0xWXo1RnBOMDZMWkRUL09OM3pwU05IR2RWdjVBN3NEemQxc0Q1?=
 =?utf-8?B?cWhmSStVeDJmZEJGejJxZk5ZUkJ5a3VwRko4U0Z0Qmd1Zmt2YmZ0OHZZT2E5?=
 =?utf-8?B?R2ZVQ3BhMmJSb2U5VmFkeDl2cHFLNVhYbGJVWnBDSGs3S0lFWXBPWG9JcVdX?=
 =?utf-8?B?SkxwVG9IdU9TQ0tYRmN0eXMzVXk0OXVHcXlrQUhmSnBXa3lsckx1T21qUU82?=
 =?utf-8?B?d2FpTHdQRTJ5cWtZYUozWWY0RGZpUk4xRndyK3NlYW1CMXZBbVYzMTRReTJB?=
 =?utf-8?B?cWRMUDlORHg5VzhRciszQWNMUi8zeHBVTzk5MEszZEZQaEdEc1NKQXd3TE9q?=
 =?utf-8?B?b2VuTSs1RnRlWjNINHhzZngyeU5nVDQ2SmcyMjNqTmZKYThpVUZCZW0weFZI?=
 =?utf-8?B?a21VZE1BMVpxMk5RNnhwNFpYUFhyc3hKa0tvQUpRRWlZb1FGTysxbmZGYmdr?=
 =?utf-8?B?MEtucFhuVVZUWFBkbWdpZWRHemdiNzNydkRFbUt4VjJ0V2tzN2NQaUZzSnlQ?=
 =?utf-8?B?OTB6MDcrNTVOSlR5MlQzL2k0bTdsVk9IMmFvUmE5S3dDdmxKakxTVkZhTHpE?=
 =?utf-8?B?WVVqMDNIY1BGUEl3VVNwRmFjbXI1UDVSbk5uN3ZMWlNuYWhJQ3FnKy9NdWJ2?=
 =?utf-8?B?a2E2WlprR1RaZHd5WU50WWJXSWRFRUtDd01aYnluQzh6SUZEUTRKbU14bHBy?=
 =?utf-8?B?eEN0My9ndlZtNW82SUFDU0tvcVNBSDIxZjdKajZoZDR6enlINWUvL3BhakNW?=
 =?utf-8?B?amtoUmduQThrUy9mK2p4ZmpDT2dUT3NQKzNTZ2doNzFUNlhoQVNyTHBNQnd2?=
 =?utf-8?B?RFBUaVpKL0wyYVk1aXMyVE5UaEFhU2RzaURMbi9acVFUUTVtVklrV0ZGV3dh?=
 =?utf-8?B?ZW1MS0pQd1JwdmZpZ2tjZ0JTRnVLV1dJc1ZMWk5rbTRrYityQnZ4ZGk4NVdF?=
 =?utf-8?B?WHJ4TER0WHpCMXBIMW94Nkk0Q21CTjhtbVhhbDVtSjdJd1NZQytrbVJDZkdJ?=
 =?utf-8?B?Vjh4QTZvenVXNjhnc2gxU056dytjSzJFeEZ4K3NVV2tZZFVyQmwvaTNpVHJE?=
 =?utf-8?B?bndWbjFkVjRWdms4a2QwQ1Y1T012TWF2TGthM0RNd1c3d0QxMEdSaDR5bk9J?=
 =?utf-8?B?cVNLWVUxZDNwbkFsMmZZOVFFSHdyRG9mdm9PM2tXTlVVNWprRlhmZC9uZSs0?=
 =?utf-8?B?U2QzWm1aYnBTbWZSQlJNYUVvNEw0RytLSEhVZ2dWQXorRWZtaGplUlRJdHJ0?=
 =?utf-8?B?TjRZdVJWR1VWMmU2TXBIOTI0U1k5aHUzZFZtZmtpVTZhTVJBZkRiOFYzNjBK?=
 =?utf-8?B?VXdXSGhXUmRvUTQxTVFIZmhMNDNHcU5JWjNYcC9wR2lqc09YbzE0TTNIb1B1?=
 =?utf-8?B?NTh4RWhRTFZXMDd5L01Fc1dwZ2xqSHNneGhqZ20vTDNtSFI1MDM3TVRFcFVo?=
 =?utf-8?B?VXhnK2RqYmVKa3NkS1ZmY3FYcGtTRWFHVWViZWdsUWZ2QWM2U2ZCSmNTWXpk?=
 =?utf-8?B?SVo1NmVmN2JNZHBhVE1PQm93TU0vSlJYWlpUTGNWT0VMSkFyN1hUdE9hNUNo?=
 =?utf-8?B?WTNCM2hvSEtGbitaUEF5bmlLRUFad0NVRzE3bUd2ZEdWaHhWbTZJVDdIV1lx?=
 =?utf-8?B?S2NlYVJTT0RBWGNIc0FRMGVRdEZDVjd4Z2RmZWtrY1hUVzZwS0tTR2xBTVd4?=
 =?utf-8?B?cUR3UjdmNHRDZUtMOFkxVUFuK2d2Y2VpRlRsMlFrSy9TMUJaWUFmQm8wVVpK?=
 =?utf-8?B?RnFTOEFRMEJQSjB6RkpSSlJjb1VQbGR2M3BONUlzTVovaWlVcmI3ZG9GdVdv?=
 =?utf-8?B?YVI5anZJZVhIdDBNWCtiMmpjZjVoaWJ1VGxCd2JiTTcxTkorVDhqTkNPSGtp?=
 =?utf-8?B?eGNnWXl3MytOcytCSjQ5Sm9HVVJRSXpFZ3B0UU1kZWNteXFvNFRCTDlJZGlh?=
 =?utf-8?B?OW5uY3RIeU1GRHdJY0tnSEhUL0xGanBNWlhDUmVVZG8vU0ZuUzV3UGN6SFor?=
 =?utf-8?B?Ym1YdGxHS0c4U1N4STU5OG1sODhTNDBIdWZJNG1PYy9wQVJFYWpVL2VmUUNh?=
 =?utf-8?Q?XiiPml2oWBXcJ/qnCmWncb7EW?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: f04f50ed-8281-4659-0a6d-08dbd0855a45
X-MS-Exchange-CrossTenant-AuthSource: AM0PR02MB4436.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2023 09:25:36.8759
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KTenXgC+j/Lm8P2y/zF0FK5kj3s1ihgUXaEVxTkUik0FHqe4GegfNHU4MjWc7PNc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR02MB10862
X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 19 Oct 2023 02:25:59 -0700 (PDT)

Hi!

2023-10-19 at 09:35, Herve Codina wrote:
> i2c-mux-pinctrl uses the pair of_find_i2c_adapter_by_node() /
> i2c_put_adapter(). These pair alone is not correct to properly lock the
> I2C parent adapter.
> 
> Indeed, i2c_put_adapter() decrements the module refcount while
> of_find_i2c_adapter_by_node() does not increment it. This leads to an
> overflow over zero of the parent adapter user counter.

Perhaps "... underflow of the parent module refcount."?

> 
> Use the dedicated function, of_get_i2c_adapter_by_node(), to handle
> correctly the module refcount.
> 
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>

Good find, and sorry about that!

Fixes: c4aee3e1b0de ("i2c: mux: pinctrl: remove platform_data")
Acked-by: Peter Rosin <peda@axentia.se>

Cheers,
Peter

> ---
>  drivers/i2c/muxes/i2c-mux-pinctrl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/muxes/i2c-mux-pinctrl.c b/drivers/i2c/muxes/i2c-mux-pinctrl.c
> index 18236b9fa14a..6ebca7bfd8a2 100644
> --- a/drivers/i2c/muxes/i2c-mux-pinctrl.c
> +++ b/drivers/i2c/muxes/i2c-mux-pinctrl.c
> @@ -62,7 +62,7 @@ static struct i2c_adapter *i2c_mux_pinctrl_parent_adapter(struct device *dev)
>  		dev_err(dev, "Cannot parse i2c-parent\n");
>  		return ERR_PTR(-ENODEV);
>  	}
> -	parent = of_find_i2c_adapter_by_node(parent_np);
> +	parent = of_get_i2c_adapter_by_node(parent_np);
>  	of_node_put(parent_np);
>  	if (!parent)
>  		return ERR_PTR(-EPROBE_DEFER);