Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp239678rdb; Thu, 19 Oct 2023 03:10:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG2zBK2+9NuLsfYQCqiHf86H4bh3RvSG4Dx/r+FGoOQU7T2XW2N/BcNS1oZ1QIwsmjZ0UDD X-Received: by 2002:a05:6808:1812:b0:3a7:2456:6af6 with SMTP id bh18-20020a056808181200b003a724566af6mr1978448oib.31.1697710200372; Thu, 19 Oct 2023 03:10:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697710200; cv=none; d=google.com; s=arc-20160816; b=OXwyQs6gDxMVfdSR5s21ASdTNgeHPtdzzxlObJ0BwqQsoLFR67fMhlbH4C2jpAC61U hz5Z684601LDlLz2qcBDbgch10XEq8qUbsA5qdm7GUZ9IT5bG6QnLf1SY0pz01w0FCQN lVeN6MnEw6u50b6Vn/IRsaYldmUknxKtxjeUiwCvv+pbi3RCG4ywxlOtspVgqP6q6dmS lkuYl/sjoSPCYPk2BE8F0LEzyRH9h6k3x0JInin/aewrgnyuw30rD5zrldRarHXBn5BU 5Vy0ua/sBhB/Fw8nVk6cTe8NhtHV4cXUcUpv4FiPR9QKCqC51bHfMpbfXwxTm2kJaRef mOIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=tkUOzd+vqXC9Gk9LtENIqmvEDih8D3cQD5X39rjRw90=; fh=OyvKLCIGIaNaHZl8Gdj3VKs53wNenJwp0vzEjW4OaB0=; b=I6tga3JQAKNQXHRKqwtA8C2jdN/bjy1jC/mj4wZKRwJvCnJaNNfRlcDWZUZ9dNiZjf ELkSbPDzC13X4VBVMFMZH3Hsk9DmWf0vxFYidkJbS+wxSoVX8nbR7jTCeps3cjTY2CdK AWVJguHKtMzDtorW1hB/265soA8Mcpj/vJ8ePixhWkZk+p/axh2mAVPFG7fuzSOU6Oh9 oqsBpF4SjA18EYUAvup3Nvs3ylkeVHVdkOD++W2OsaPWlZNyl4mCPJgUNs8cucq97U1R IrhUBo8dlzJ+NAPl9nRk3487Dpp2qchkb+hdmXPZ3j9lmiebcqQlJ1EC1rVqJL2SeKNw JL3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=J6xFZ6pL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id k1-20020a628401000000b006b7d62ed178si5763741pfd.5.2023.10.19.03.09.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 03:10:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=J6xFZ6pL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id E59F4811EDAB; Thu, 19 Oct 2023 03:09:57 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345238AbjJSKJp (ORCPT + 99 others); Thu, 19 Oct 2023 06:09:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345245AbjJSKJi (ORCPT ); Thu, 19 Oct 2023 06:09:38 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 818D518D for ; Thu, 19 Oct 2023 03:09:33 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-32dbbf3c782so341798f8f.1 for ; Thu, 19 Oct 2023 03:09:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697710172; x=1698314972; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tkUOzd+vqXC9Gk9LtENIqmvEDih8D3cQD5X39rjRw90=; b=J6xFZ6pLgEkgt2Py5t0CnQRnASsBWoALpqk+aE+UlkGfzIZk+wLyJKC5B/1+8yTgw1 OdSlqFiLs8ZYndaeN7JA01pYWmlExh2tLZOW9O6fBhHhYGuodVpq/3oRCg/NELq0P9UV NpBGAieXNXhGxUmXHC6mbq1XHnqn4QsSMrs7cjf1JyjDoeh9wbKhF5AQv4nIA+YXUC+o 4Q61fltjA0J9aIl9FWIEB/hFqQH2h4KIhnmPyJebK0jgOIp9lNgQTZSbndRbfgQ+0bJQ e8SD+y0qbl0kya/s6nR4kr7oc5btjUzZsyuuunMf3NXaHJ8+wTBPl6xtVAZndRNl07/2 j8Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697710172; x=1698314972; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tkUOzd+vqXC9Gk9LtENIqmvEDih8D3cQD5X39rjRw90=; b=b3o0H2KiFZ51Xtvxa7h7tUA4AkaJQHIk1tN/Tpg1T+RkhrbN/vCdCyY6oaiiluBw7+ E0ucxcjCLS3mUPiBzCFUU2niwRTpydBa5V0TFLO19QumlahLX/WSJHW4lgVw2YNZKCqo 3EiKciRBQtdQBpahGvBiUwQsppKvzH7ToYOo+Lf+3cxbivhn5gy7MjyeT6sSbrpa+8Lu HyZvGXFpBic7qLvc8r2zU30IBtUY9a2FxRpAuNcTSVRELQBOW651pIITUCUTljGfxTM8 3XpU+hSv+8FdmH3vaWioFYtkGrs9hAbxs+jthPazU/qTmE/PuvlbRCNNZGvU8bRpX9w7 5doQ== X-Gm-Message-State: AOJu0YwFsSkdXKA8HnjbcKstIu2QBe3X04s1qHaC3EbCYHIjPd4MLdvQ yMOJdGORKsdzFD8Iwdu/9SIhig== X-Received: by 2002:adf:f80a:0:b0:32d:888d:7598 with SMTP id s10-20020adff80a000000b0032d888d7598mr1448946wrp.4.1697710171905; Thu, 19 Oct 2023 03:09:31 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id n13-20020adffe0d000000b0031ad2f9269dsm4098708wrr.40.2023.10.19.03.09.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 03:09:31 -0700 (PDT) Date: Thu, 19 Oct 2023 13:09:27 +0300 From: Dan Carpenter To: Su Hui Cc: kartilak@cisco.com, sebaddel@cisco.com, jejb@linux.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] scsi: snici: Remove dead code in snic_dr_clean_pending_req Message-ID: <15081b01-2915-42a4-bcda-0d8243741baa@kadam.mountain> References: <20231019083026.1525366-1-suhui@nfschina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231019083026.1525366-1-suhui@nfschina.com> X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 19 Oct 2023 03:09:58 -0700 (PDT) On Thu, Oct 19, 2023 at 04:30:27PM +0800, Su Hui wrote: > Value stored to 'ret' is never read, remove it to save space. > > Signed-off-by: Su Hui Could you do this a bit more thouroughly and remove all the "ret = FAILED;" and "ret = 0;" assignments. Just "return FAILED;" and "return 0;" directly. regards, dan carpenter