Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp244879rdb; Thu, 19 Oct 2023 03:21:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGc00N9KU9H9PCFTKZJTFIBKhpg3kLE4Hy0Z4ac4C7SPHRbf1SMuybC9v3PBvF2v93lvoQS X-Received: by 2002:a17:902:d483:b0:1c8:9a60:387f with SMTP id c3-20020a170902d48300b001c89a60387fmr2018268plg.56.1697710882854; Thu, 19 Oct 2023 03:21:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697710882; cv=none; d=google.com; s=arc-20160816; b=HShzmrRn2nCwjhcZLg0IRj9NwQIViupAlGk5wzd7jbzdOoHXkIrWGoW0sm/5QkjOxe yk1FZyeP5nWmEJAVuM5VUrgFTDjZXh5gcpY4hJ6cO5ZxKxyf1ysAE7lVqIjfeGO/FMie +X/pSKO9wClBiiWMPMQMri+Y4UVUnAX2H7VRPi1suaFqHv92hXunSShuVG0ypHCgMWe2 i3Q+PXMdq5wHw3nuzTN7jODfW9reNeIbK+/HtFwY60vjX5M5UjT/Q67PGTlHHdXWeHb1 6czv3ySAOIisA1K1j/ewvjpH1oWDrny5RpjGtPdgrpzqsqzOVJewL8SKUa/go9zOnbpD mlRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=aITYjO+YGsm/lNyeL4Ki5aL7OoIQ+oAR9WJa4zw/g+U=; fh=5vrvL3E8mK/j49xjr9b1swz649uzaVc0rP2xek+Hd0M=; b=b4bIQeL6KsWzwcPcJf47ENkSASckLDyskeDJitEngpFICpPKlJgyISU8ESPHU+E37/ /ddEgkGtBbQseYqcPLEzErQNTWA2LfL6dY0Dq2RZqotpG4KRII3SzDV4Hb0ZZHD6T2VQ BXLM953NwtgvdnON5uaUu/CkGhTBmGOkkOFLXkSixIMxjHeTJJJvWAU+Xn8eTpJ2Qo9T lVhd4VcjfOxKqXpLlBhA8VMdrGaTmAtEwC2nCYURaymP7R4YJzrhm3G66QeGBOac/wRD pv9oYlut/AvdvK1u3xMr4FR3C0jh4fPflPQ+anqgQh/81TDbUu1+oB1NWsQZRTEKAovL sPOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QD3dLeYn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id u7-20020a170902e5c700b001c6285295absi2102537plf.514.2023.10.19.03.21.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 03:21:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QD3dLeYn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id BF910822CAF1; Thu, 19 Oct 2023 03:21:17 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345260AbjJSKVN (ORCPT + 99 others); Thu, 19 Oct 2023 06:21:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345259AbjJSKVL (ORCPT ); Thu, 19 Oct 2023 06:21:11 -0400 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 119D4126 for ; Thu, 19 Oct 2023 03:21:09 -0700 (PDT) Received: by mail-pj1-x102e.google.com with SMTP id 98e67ed59e1d1-27d0acd0903so5099311a91.1 for ; Thu, 19 Oct 2023 03:21:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697710868; x=1698315668; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=aITYjO+YGsm/lNyeL4Ki5aL7OoIQ+oAR9WJa4zw/g+U=; b=QD3dLeYn1zYUFh5L48gjx9aKO4LRmGJ9UcbzK6KUqsfivCjyPaIr5dBF4808V4rU3P P1d+FGljUeeKEq6KbGepHM5OvoqrAiprHmHdqQXWoOzSo9XHIRpjYVnbJSbwEwaQYy7N 09Zz6yv60wkqgwbFyQ8BESHNys/RHvJsE/io5Fb+4H6zcwBh5DA4H0VcnKiEvWlZQa+k fT88rqHKV+PC73rNE9wqNyjFHby7Dp0uiGXJf27A4TDuu/cfxz6GJAPPL87hohevwBG2 nTfWwZije3o0ENLUwUBmwmlbrWsGysFTyUwYj9Gs/X/5wOb7vG2le6yo3SaFsXnVb1P1 hvTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697710868; x=1698315668; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aITYjO+YGsm/lNyeL4Ki5aL7OoIQ+oAR9WJa4zw/g+U=; b=WfzTPc7PWVAVyMXeLmh5yHbNNr9gABT2cstOcZEEpXPwKXgYYXt17hqO+NrrJvuGeU ptsgkXYbxasaTDqQ9KlYe3nna+dq+OSJHeUr26oFwulugNDabSSYvl68YsXKBnvdvZpL VLbS7epfQIKDIS7eizYoGYOjz8UywEFzf3o2wh4VQmxEOM9LPucZY4YDaBgx25/snsvR VRdz7gMgbrhjrS1RqhUGfadQADrYe8EM7jHcCmMHcySkkQ1FP5q6bCL6nJCEIkQu6spM UCBDALhG9zYCagIxD/zwqEOudP9pv+q0RPEGlSNhFZNhI1o4q2fOB/VpX38IWgu40oI6 StRA== X-Gm-Message-State: AOJu0YzpskK/L4TynTo38gZWsgDFfyVH147WPxrrF3iTdU9ncTMMfNy6 crO0E+M+a9s9uPxoieY6hoKhnw== X-Received: by 2002:a17:90a:4381:b0:27d:1ea0:bc84 with SMTP id r1-20020a17090a438100b0027d1ea0bc84mr1562150pjg.34.1697710868475; Thu, 19 Oct 2023 03:21:08 -0700 (PDT) Received: from localhost ([122.172.80.14]) by smtp.gmail.com with ESMTPSA id i126-20020a639d84000000b005b83bc255fbsm1945847pgd.71.2023.10.19.03.21.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 03:21:07 -0700 (PDT) Date: Thu, 19 Oct 2023 15:51:05 +0530 From: Viresh Kumar To: Ulf Hansson Cc: Stephan Gerhold , Andy Gross , Bjorn Andersson , Konrad Dybcio , Ilia Lin , "Rafael J. Wysocki" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Stephan Gerhold , stable@vger.kernel.org Subject: Re: [PATCH v2 0/3] cpufreq: Add basic cpufreq scaling for Qualcomm MSM8909 Message-ID: <20231019102105.jewkue3gxonzy7kw@vireshk-i7> References: <20231018-msm8909-cpufreq-v2-0-0962df95f654@kernkonzept.com> <20231019061608.wjlf4orkdlpnv3a5@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 19 Oct 2023 03:21:17 -0700 (PDT) On 19-10-23, 12:19, Ulf Hansson wrote: > On Thu, 19 Oct 2023 at 08:16, Viresh Kumar wrote: > > > > On 18-10-23, 10:06, Stephan Gerhold wrote: > > > Add the necessary definitions to the qcom-cpufreq-nvmem driver to > > > support basic cpufreq scaling on the Qualcomm MSM8909 SoC. In practice > > > the necessary power domains vary depending on the actual PMIC the SoC > > > was combined with. With PM8909 the VDD_APC power domain is shared with > > > VDD_CX so the RPM firmware handles all voltage adjustments, while with > > > PM8916 and PM660 Linux is responsible to do adaptive voltage scaling > > > of a dedicated CPU regulator using CPR. > > > > > > Signed-off-by: Stephan Gerhold > > > > Applied patch 1 and 3. Thanks. > > I did spend quite some time reviewing the previous version. Please > allow me to have a look at this too before applying. My branch isn't immutable, I keep on changing it. Please provide your feedback :) -- viresh