Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp258963rdb; Thu, 19 Oct 2023 03:54:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGt4qO+gkzw5QpIet7eCE5okKsczhJyGPahRCZIbbjoMMGSjVS40uCiW3ayNk+wdQbFd7PN X-Received: by 2002:a17:903:32c8:b0:1c9:e85a:4296 with SMTP id i8-20020a17090332c800b001c9e85a4296mr2387975plr.6.1697712895189; Thu, 19 Oct 2023 03:54:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697712895; cv=none; d=google.com; s=arc-20160816; b=CF+uxPNSah2UPwufr3Asz+VTmDPDejnr/FiitnOumQDoo//G4rV52Q/gKXAThJ2BmX sfx3y25DUxJk0Rt2YMY87oWPZzCv5hrV/QlNhmbEvYrruQtPeahBwO+GDx0UsubU5/ef jIPcUkh3AbQN/ESmEX+v6GiZXFDdAuWFmTO6GT5ZG3L9YHSU4CVybp2q/Ot/Dm0XvvXR 0GMS6MIZY9NyNv6cAFkzWzlpCp5j7NRE5L8ZGYkBfKKKAbFdaTTboViBVYMkMUgxGkor KPz5GbD/MGdyMGt4BzCGuui1WWaPqhus+dFhadnA4NwYii8VPW8LTLMuYqFQg9hCI86E i7ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=Nfn+oO19d85iUPS1S8iB6FDJTxC6adkxUJsn+QXnNLE=; fh=CLNQ8kV04xDXSwrPayGWVcDQFrg/pFRXdQnsB0qrMpY=; b=W3olrAYsFQQpU/zWbXTqEpMOzbq4PiIYW+sof3HcvNHKiy3FhLMvZ17dEsl9IenknQ FW7j4aGssW3Tr+dUpYHPVk2fN86TDOjzqNPWVxByi746duUMlX20flS35kaIpDkc3Eaf +epnvjwHLSMXt38KYNPCoeAdd+lRSItkBInH3u6Yb2ZKEvhzZPHqpGvP7QWKYji7O2Is NgZpwWKLerukGQTK+29Y8Itw2KlZ+iNvDDavpNK4y45wkovE9IVvJYfyTP5+JDtYceov KdcWX5OY1DO04GMZ87ImtyuwO241cwGhS0O1v+VH3KzUmKGtBQKqTRIfzVlaI0ft9iby dz+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id s15-20020a170902ea0f00b001c0c79b3869si2127442plg.578.2023.10.19.03.54.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 03:54:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id ABF7C825CD2B; Thu, 19 Oct 2023 03:54:52 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344861AbjJSKyp (ORCPT + 99 others); Thu, 19 Oct 2023 06:54:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233027AbjJSKyo (ORCPT ); Thu, 19 Oct 2023 06:54:44 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13F40138; Thu, 19 Oct 2023 03:54:41 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id B00F121A98; Thu, 19 Oct 2023 10:54:39 +0000 (UTC) Received: from lion.mk-sys.cz (unknown [10.163.44.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 72A172C425; Thu, 19 Oct 2023 10:54:39 +0000 (UTC) Received: by lion.mk-sys.cz (Postfix, from userid 1000) id 7E8172016B; Thu, 19 Oct 2023 12:54:37 +0200 (CEST) Date: Thu, 19 Oct 2023 12:54:37 +0200 From: Michal Kubecek To: =?utf-8?B?S8O2cnk=?= Maincent Cc: Oleksij Rempel , "David S. Miller" , Andrew Lunn , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Paolo Abeni , Vladimir Oltean , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net v1 1/1] ethtool: fix clearing of WoL flags Message-ID: <20231019105437.xvmvfhluowvubp2y@lion.mk-sys.cz> References: <20231019070904.521718-1-o.rempel@pengutronix.de> <20231019090510.bbcmh7stzqqgchdd@lion.mk-sys.cz> <20231019095140.l6fffnszraeb6iiw@lion.mk-sys.cz> <20231019122114.5b4a13a9@kmaincent-XPS-13-7390> <20231019105048.l64jp2nd46fxjewt@lion.mk-sys.cz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qd7xmcbudbjiafui" Content-Disposition: inline In-Reply-To: <20231019105048.l64jp2nd46fxjewt@lion.mk-sys.cz> X-Spam-Level: Authentication-Results: smtp-out1.suse.de; dkim=none; dmarc=none; spf=softfail (smtp-out1.suse.de: 149.44.160.134 is neither permitted nor denied by domain of mkubecek@suse.cz) smtp.mailfrom=mkubecek@suse.cz X-Rspamd-Server: rspamd2 X-Spamd-Result: default: False [-1.09 / 50.00]; ARC_NA(0.00)[]; BAYES_HAM(-0.98)[86.89%]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; DMARC_NA(0.20)[suse.cz]; RWL_MAILSPIKE_GOOD(0.00)[149.44.160.134:from]; R_SPF_SOFTFAIL(0.60)[~all]; NEURAL_HAM_LONG(-3.00)[-1.000]; VIOLATED_DIRECT_SPF(3.50)[]; MX_GOOD(-0.01)[]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCPT_COUNT_TWELVE(0.00)[12]; SIGNED_PGP(-2.00)[]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.20)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_COUNT_TWO(0.00)[2]; FREEMAIL_CC(0.00)[pengutronix.de,davemloft.net,lunn.ch,google.com,gmail.com,kernel.org,redhat.com,vger.kernel.org]; SUSPICIOUS_RECIPS(1.50)[] X-Spam-Score: -1.09 X-Rspamd-Queue-Id: B00F121A98 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 19 Oct 2023 03:54:53 -0700 (PDT) --qd7xmcbudbjiafui Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 19, 2023 at 12:50:48PM +0200, Michal Kubecek wrote: [...] > @@ -490,6 +509,8 @@ ethnl_update_bitset32_verbose(u32 *bitmap, unsigned i= nt nbits, > *mod =3D true; > } > } > + if (saved_bitmap) > + *mod =3D ethnl_bitmap32_cmp(saved_bitmap, bitmap, nbits); > =20 > ret =3D 0; > out: Oops, this should be *mod =3D !ethnl_bitmap32_equal(saved_bitmap, bitmap, nbits); Michal --qd7xmcbudbjiafui Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEWN3j3bieVmp26mKO538sG/LRdpUFAmUxCukACgkQ538sG/LR dpX7Nwf/ZPBVh1GNjiLre1IZ0kaSby9BnLxSYnawYwanefVZKD7AjS64G/BQHCy/ hyJfBJ+/Yxvnr4YLUBXvbBA4tBV3aQhk6lkOnkQ+q/QNsv4NATjy/WB25p2vMCVb 4tAZHja+NYSWwvrec4YQRn3z/3VLb3mETAmpRIF79WGDKsSV/sv5HT7CSRHY2FCt NRqfdZ8uKNC/GUp5FrRMyuwwjUSA5Izbj35HMUoZKezQZu/fo4+Xil17hbO8QqeF rWKQsZX4SYf9nmI8zdRR8PhzkK3tXvrdMChU2a+jtPUn9/wFfbiiSyEWKYDO+dHx nmxGwfkvDmp9bypTFlNxRWIA8EJLlQ== =kP6F -----END PGP SIGNATURE----- --qd7xmcbudbjiafui--