Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <93a6d8b0-140c-983e-1b78-6f5a4e03e62e@intel.com>
Date:   Thu, 19 Oct 2023 12:55:11 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] staging: vc04_services: remove empty functions
Content-Language: en-US
To:     Calvince Otieno <calvncce@gmail.com>
CC:     <outreachy@lists.linux.dev>, <gustavo@embeddedor.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Florian Fainelli <florian.fainelli@broadcom.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>,
        <linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
References: <ZTD677iqMkRPxT27@lab-ubuntu>
From:   Karolina Stolarek <karolina.stolarek@intel.com>
Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298
 Gdansk - KRS 101882 - NIP 957-07-52-316
In-Reply-To: <ZTD677iqMkRPxT27@lab-ubuntu>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUtkV2JkRTQydFVtUWtsUFVZMXdmMHQyTk5wTEVndmcrU3NVNDU5clFwQkYx?=
 =?utf-8?B?ZVpUeVhvbmFyckUyZkMxd0lPNWNoZDBoR0I4MnZEdjNPMitvQ0dGQ0hvVG5w?=
 =?utf-8?B?aU5OU2Rub05YY2I4ZERWTDhFeFRXcXo5WUpOcDFTYXJjRjQ2UksvQ2I3NzFr?=
 =?utf-8?B?YnpQVENWcTYraEVCWnRub01BUzBNQlY5YVpISjdDNExjaFFuc28rRWJGY0Va?=
 =?utf-8?B?VVdtaStCMGNteW44M2o4N0FQL241VUplYnJhV3Rjb0JPVDI3bWI5TXBoeUxl?=
 =?utf-8?B?MEpFQWxXeVpVQzFBZC9HVG9XRUhrQWcvR3cwc2ZNL1dFdFIxamQ2Z0V3OURS?=
 =?utf-8?B?UGpCNzZoZTQ2ZWRDZUdQdlpzL2s2bE9ZaE16R2RoQW1LZURLNFRHT0FGdTJU?=
 =?utf-8?B?dlQ1V0FvVFQ1a2xpUE05a280cGVKNTE0RmUrNHhkSjYzSVVGcXhOaHcrcDdv?=
 =?utf-8?B?Um9VNUdENWRORDR2QTNzcGFqUkxwK3o0VHBQR2orSm1DeXptTWNSNmJKUlRi?=
 =?utf-8?B?emdmTE1ERnBhRERZLzVIb2JQR0RtRUdFcmJ3Q3lmWHdieWg3QTZvL0NkVmsv?=
 =?utf-8?B?cVBTWS80RFc3NzVKc2REblQ3ZW1aYjZLTHJjZHJhUEgrN0VTbTZSSVRZb3lN?=
 =?utf-8?B?SXR5QWp3NDRreXpTSEI1QWFKYzZsakNTL2x6YkJLSTZ1TUhxNDhqek9zRUZk?=
 =?utf-8?B?UVRnRE5UMnJzR2JzbzF5bVQzendEQUY0MzJNaDFzL3ZvUVd3WGNwa1g3LzRX?=
 =?utf-8?B?Q1J6RG1UbGVRcE9ZMGNDYmdGQys0N3dLZit2RFo5ZGdhVXlqOW1aMnFVT1g2?=
 =?utf-8?B?TG92a2hhOTZIU0lydU4xS0VSemFzc2J5SjQrS1I3L2NDM3VsU0hBQjdaTDc5?=
 =?utf-8?B?QngzT01DR1lzd0JRaC9RbGNMSlZqVU4vdjQ1ZEFGbS9nYitrTnlYcHZWZ2pV?=
 =?utf-8?B?c2YrT1FRTnhlNDdSMGgzd0psOWZLVzdFdEZZTFhyN1R0TTRQc0thNDVCdHhu?=
 =?utf-8?B?QnJrTnNOL0ZCN1BLV3orekhCUnJpaDVkWWtHSW1mWXl6WnFsb3I4cXMxOGZG?=
 =?utf-8?B?OE0yRW5MK2JRUXdWcjhpb0pZYm9WRTBHQlFRTTR2clp1NU1FbEFzYjdnbGs1?=
 =?utf-8?B?SUhmL3drOVUzQWEvenFjdmJaUFZNaERZSzI0TXEwS1BrTWk3cE9TakZyQ0ZG?=
 =?utf-8?B?eHl2K0kyUGU0UnhXeS9UUUs3YkdKZlplcUdIWG45MGZzNlFjS3pjVXoyTk41?=
 =?utf-8?B?QzdlVVg2TlhpMnVhdlhWendTaDZUWmFvUUhzbzV3UnhKSkVWWTZSY3hYRjVw?=
 =?utf-8?B?YUgwK3ZtSXg2emRmV3JBeGVRbm9ZbG8wVHJDVng3ZzQ2dENoRGFDY29oaUR0?=
 =?utf-8?B?VGxZWC93bUdRMW5ZZW1XTGdMQ0NYbTVEQ1lUQ3poUWU1a3cvTzhGVzlVdUFM?=
 =?utf-8?B?SmtnYlo1dkZYcXhXN2Q2R21KYUhhSHJYTE1XKzdkdW5peXJ6YnVQUGtiUXgv?=
 =?utf-8?B?R3RXUStJekowSld0RmxZemVrZjVjdUdQWk1PU1lxbzZZY3dWNm9OYTNhbmdC?=
 =?utf-8?B?QVc2WG1IeHIxckJQeThFT0hyRmhwdzNDSkpRQnlWWmdFNWx6MWdjM3p2TEJG?=
 =?utf-8?B?RWJPREYyWnNZUWIzbmdtZXpPWkM5VEFOajRkSnVmT25aVkVLc1ZXOUVZMmhS?=
 =?utf-8?B?dnVZdnJWOXFuOGx3azZQNUY1WlBxcUxNSGdCWDFET25pNkY3VG9nQWtmZnhr?=
 =?utf-8?B?UjJOZ1RsckIyNFlPWjdzRS9JQjE0QzZDejg2SVE0cmRSVCtvcDNRVUJOZzRl?=
 =?utf-8?B?b1R6ZUcvNURGelFyNjlmRjhQbUVEVmpKVWhrL2NKVmlCR0NwdlM3eTUrOWtu?=
 =?utf-8?B?cmZQN2ZPVnJpMDlaZE1Qd1luYzZtUWl0ell2a0s5S1p3d3lzdm9BM3d2c3Nk?=
 =?utf-8?B?b2pKZlZtaXY4Qm91TTQvYTZrdnJJSVRhLzdyL2o0dGNLWkNacHdWcmxtNThl?=
 =?utf-8?B?emJJZTJZcmpyTjhxTU82T0owU1d4ME16bG9EbnE4bEpTWjlnVG13dnhxOHpH?=
 =?utf-8?B?WktWQjdZM0NKeTFKWWRRYlFzMHJIZkNSR3piWmE4QzQ4Z2VhVzl2bzdFRVRO?=
 =?utf-8?B?TnA5WjJ3dlM1UlVkR2d3eDdCYzRjZFRhRUFCa2JWSVNITjA1SzJDc04xOElJ?=
 =?utf-8?B?VmRQRGxZMUhmWVUzeEtyUnJBZkYwRFdPTGF1R3NjakxmTFVXeEJ3OWpmWU9s?=
 =?utf-8?B?MGJaUHYvTEZKUFdUMUx4eld4eklRPT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 304830a2-4aa3-444e-8219-08dbd091e2be
X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4243.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2023 10:55:19.8686
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XtRRntWpnM2MertZzE/pu2GJiYUXHkwNgYF8vrm1NLrv0DD+nbKKI2BurOXAWfHGuYhxyqF8j9teeEuHi1d6IEohvKmwc36wGHiWDSgyh0U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7606
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 19 Oct 2023 03:55:51 -0700 (PDT)

On 19.10.2023 11:46, Calvince Otieno wrote:
> The functions vchiq_debugfs_init(), vchiq_debugfs_deinit(),
> vchiq_debugfs_add_instance(), and vchiq_debugfs_remove_instance()
> are declared and defined but contains no code or statements.
> They do nothing.
> 
> Signed-off-by: Calvince Otieno <calvncce@gmail.com>
> ---
>   .../interface/vchiq_arm/vchiq_arm.c              |  3 ---
>   .../interface/vchiq_arm/vchiq_debugfs.c          | 16 ----------------
>   .../interface/vchiq_arm/vchiq_debugfs.h          |  8 --------
>   .../interface/vchiq_arm/vchiq_dev.c              |  4 ----
>   4 files changed, 31 deletions(-)
> 
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> index eef9c8c06e66..b802d1ecc8f6 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> @@ -1806,8 +1806,6 @@ static int vchiq_probe(struct platform_device *pdev)
>   	if (err)
>   		goto failed_platform_init;
>   
> -	vchiq_debugfs_init();
> -
>   	vchiq_log_info(vchiq_arm_log_level,
>   		       "vchiq: platform initialised - version %d (min %d)",
>   		       VCHIQ_VERSION, VCHIQ_VERSION_MIN);
> @@ -1838,7 +1836,6 @@ static void vchiq_remove(struct platform_device *pdev)
>   {
>   	vchiq_device_unregister(bcm2835_audio);
>   	vchiq_device_unregister(bcm2835_camera);
> -	vchiq_debugfs_deinit();
>   	vchiq_deregister_chrdev();
>   }
>   
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.c
> index dc667afd1f8c..7e45076e5ebd 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.c
> @@ -228,20 +228,4 @@ void vchiq_debugfs_deinit(void)
>   
>   #else /* CONFIG_DEBUG_FS */
We need to have these definitions, so a kernel with no CONFIG_DEBUG_FS 
selected builds. Have you experimented with this config with your 
changes applied?

All the best,
Karolina

>   
> -void vchiq_debugfs_init(void)
> -{
> -}
> -
> -void vchiq_debugfs_deinit(void)
> -{
> -}
> -
> -void vchiq_debugfs_add_instance(struct vchiq_instance *instance)
> -{
> -}
> -
> -void vchiq_debugfs_remove_instance(struct vchiq_instance *instance)
> -{
> -}
> -
>   #endif /* CONFIG_DEBUG_FS */
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.h
> index e9bf055a4ca9..76424473c32b 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.h
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.h
> @@ -10,12 +10,4 @@ struct vchiq_debugfs_node {
>   	struct dentry *dentry;
>   };
>   
> -void vchiq_debugfs_init(void);
> -
> -void vchiq_debugfs_deinit(void);
> -
> -void vchiq_debugfs_add_instance(struct vchiq_instance *instance);
> -
> -void vchiq_debugfs_remove_instance(struct vchiq_instance *instance);
> -
>   #endif /* VCHIQ_DEBUGFS_H */
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c
> index 841e1a535642..953f39f537a8 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c
> @@ -1185,8 +1185,6 @@ static int vchiq_open(struct inode *inode, struct file *file)
>   	instance->state = state;
>   	instance->pid = current->tgid;
>   
> -	vchiq_debugfs_add_instance(instance);
> -
>   	init_completion(&instance->insert_event);
>   	init_completion(&instance->remove_event);
>   	mutex_init(&instance->completion_mutex);
> @@ -1297,8 +1295,6 @@ static int vchiq_release(struct inode *inode, struct file *file)
>   
>   	free_bulk_waiter(instance);
>   
> -	vchiq_debugfs_remove_instance(instance);
> -
>   	kfree(instance);
>   	file->private_data = NULL;
>