Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <f89a00c8-2ea2-4ef1-909e-2eaf7bc17cf9@rasmusvillemoes.dk>
Date:   Thu, 19 Oct 2023 13:51:45 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] lib/vsprintf: Remove redundant code
Content-Language: en-US, da
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, pmladek@suse.com
Cc:     rostedt@goodmis.org, andriy.shevchenko@linux.intel.com,
        senozhatsky@chromium.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
References: <20231018064817.86721-1-jiapeng.chong@linux.alibaba.com>
From:   Rasmus Villemoes <linux@rasmusvillemoes.dk>
In-Reply-To: <20231018064817.86721-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 18/10/2023 08.48, Jiapeng Chong wrote:
> When variable needcolon is assigned a value of false, it must be
> assigned a value of true later on, which is redundant code.

NAK on any patch modifying these things without first filling the blank
space in ip6() in lib/test_printf.c with tests for all the various ip6
printing modes.

Adding test cases there is much more useful than code-golfing, and would
help verify that these changes are actually ok. Or may reveal that the
current code is buggy.

Rasmus