Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754590AbXKSVdT (ORCPT ); Mon, 19 Nov 2007 16:33:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751518AbXKSVdJ (ORCPT ); Mon, 19 Nov 2007 16:33:09 -0500 Received: from ns.penguin.cz ([212.47.7.226]:58579 "EHLO ns.penguin.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751450AbXKSVdI (ORCPT ); Mon, 19 Nov 2007 16:33:08 -0500 Subject: [PATCH] fix CONFIG_MTD_SHARP_SL if CONFIG_MTD=m (try2) From: Stanislav Brabec To: kernel list Cc: linux-mtd@lists.infradead.org, Pavel Machek Content-Type: text/plain Date: Mon, 19 Nov 2007 22:33:02 +0100 Message-Id: <1195507983.29782.4.camel@utx.utx.cz> Mime-Version: 1.0 X-Mailer: Evolution 2.12.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1666 Lines: 45 Sharp Zaurus SL-C3200 with CONFIG_MTD=m and CONFIG_MTD_SHARP_SL=y (as it is bool) lost support for the ROM flash. With CONFIG_MTD=y it has no problems. It is caused by losing of compiled code of drivers/mtd/maps/sharpsl-flash.o. It was linked to drivers/mtd/maps/built-in.o and drivers/mtd/built-in.o, but lost and not linked to drivers/built-in.o (because CONFIG_MTD!=y). Patch below fixes this problem by creating sharpsl-flash.ko (and the code works correctly as a module). This is second try (first sent Nov 10 to linux-mtd@lists.infradead.org). Signed-off-by: Stanislav Brabec Index: linux-2.6.23/drivers/mtd/maps/Kconfig =================================================================== --- linux-2.6.23/drivers/mtd/maps/Kconfig +++ linux-2.6.23/drivers/mtd/maps/Kconfig @@ -600,7 +600,7 @@ default "4" config MTD_SHARP_SL - bool "ROM mapped on Sharp SL Series" + tristate "ROM mapped on Sharp SL Series" depends on ARCH_PXA help This enables access to the flash chip on the Sharp SL Series of PDAs. Command to ensure, that CONFIG_MTD_SHARP_SL is the only problematic part of MTD. for i in $(find -name Makefile | xargs grep CONFIG_MTD_ | sed 's/.*obj-\$(\([^)]*\).*/\1/') ; do grep -A1 -w "config ${i#CONFIG_}" $(find -name Kconfig) ; done | grep -B1 bool ________________________________________________________________________ Stanislav Brabec http://www.penguin.cz/~utx - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/