Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.117.161 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C
References: <20231019082138.18889-1-phaddad@nvidia.com>
 <20231019082138.18889-3-phaddad@nvidia.com>
User-agent: mu4e 1.8.11; emacs 28.3
From:   Petr Machata <petrm@nvidia.com>
To:     Patrisious Haddad <phaddad@nvidia.com>
CC:     <jgg@ziepe.ca>, <leon@kernel.org>, <dsahern@gmail.com>,
        <stephen@networkplumber.org>, <netdev@vger.kernel.org>,
        <linux-rdma@vger.kernel.org>, <linuxarm@huawei.com>,
        <linux-kernel@vger.kernel.org>, <huangjunxian6@hisilicon.com>,
        <michaelgur@nvidia.com>
Subject: Re: [PATCH iproute2-next 2/3] rdma: Add an option to set privileged
 QKEY parameter
Date:   Thu, 19 Oct 2023 12:38:10 +0200
In-Reply-To: <20231019082138.18889-3-phaddad@nvidia.com>
Message-ID: <87il72aiqm.fsf@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2023 12:40:20.9352
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d11392f9-e05e-4111-e6cc-08dbd0a08ec2
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A0FC.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7910
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 19 Oct 2023 05:40:30 -0700 (PDT)


Patrisious Haddad <phaddad@nvidia.com> writes:

> @@ -40,6 +45,22 @@ static int sys_show_parse_cb(const struct nlmsghdr *nlh, void *data)
>  				   mode_str);
>  	}
>  
> +	if (tb[RDMA_NLDEV_SYS_ATTR_PRIVILEGED_QKEY_MODE]) {
> +		const char *pqkey_str;
> +		uint8_t pqkey_mode;
> +
> +		pqkey_mode =
> +			mnl_attr_get_u8(tb[RDMA_NLDEV_SYS_ATTR_PRIVILEGED_QKEY_MODE]);
> +
> +		if (pqkey_mode < ARRAY_SIZE(privileged_qkey_str))
> +			pqkey_str = privileged_qkey_str[pqkey_mode];
> +		else
> +			pqkey_str = "unknown";
> +
> +		print_color_string(PRINT_ANY, COLOR_NONE, "privileged-qkey",
> +				   "privileged-qkey %s ", pqkey_str);
> +	}
> +

Elsewhere in the file, you just use print_color_on_off(), why not here?

>  	if (tb[RDMA_NLDEV_SYS_ATTR_COPY_ON_FORK])
>  		cof = mnl_attr_get_u8(tb[RDMA_NLDEV_SYS_ATTR_COPY_ON_FORK]);
>  

> @@ -111,10 +155,25 @@ static int sys_set_netns_args(struct rd *rd)
>  	return sys_set_netns_cmd(rd, cmd);
>  }
>  
> +static int sys_set_privileged_qkey_args(struct rd *rd)
> +{
> +	bool cmd;
> +
> +	if (rd_no_arg(rd) || !sys_valid_privileged_qkey_cmd(rd_argv(rd))) {
> +		pr_err("valid options are: { on | off }\n");
> +		return -EINVAL;
> +	}

This could use parse_on_off().

> +
> +	cmd = (strcmp(rd_argv(rd), "on") == 0) ? true : false;
> +
> +	return sys_set_privileged_qkey_cmd(rd, cmd);
> +}
> +
>  static int sys_set_help(struct rd *rd)
>  {
>  	pr_out("Usage: %s system set [PARAM] value\n", rd->filename);
>  	pr_out("            system set netns { shared | exclusive }\n");
> +	pr_out("            system set privileged-qkey { on | off }\n");
>  	return 0;
>  }
>  
> @@ -124,6 +183,7 @@ static int sys_set(struct rd *rd)
>  		{ NULL,			sys_set_help },
>  		{ "help",		sys_set_help },
>  		{ "netns",		sys_set_netns_args},
> +		{ "privileged-qkey",	sys_set_privileged_qkey_args},
>  		{ 0 }
>  	};

The rest of the code looks sane to me, but I'm not familiar with the
feature.