Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Thu, 19 Oct 2023 15:09:56 +0200
Message-ID: <87pm1alpwb.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc:     alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Cezary Rojewski <cezary.rojewski@intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Liam Girdwood <liam.r.girdwood@linux.intel.com>,
        Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>,
        Mark Brown <broonie@kernel.org>,
        Daniel Baluta <daniel.baluta@nxp.com>,
        linux-kernel@vger.kernel.org, sound-open-firmware@alsa-project.org
Subject: Re: [PATCH v7 01/13] ASoC: SOF: core: Ensure sof_ops_free() is still called when probe never ran.
In-Reply-To: <a581dd50-b3c0-4774-ad3e-0db5e4c47338@linux.intel.com>
References: <20231009115437.99976-1-maarten.lankhorst@linux.intel.com>
        <20231009115437.99976-2-maarten.lankhorst@linux.intel.com>
        <87il7aopcy.wl-tiwai@suse.de>
        <a581dd50-b3c0-4774-ad3e-0db5e4c47338@linux.intel.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 19 Oct 2023 12:02:55 +0200,
Maarten Lankhorst wrote:
> 
> Hey,
> 
> Den 2023-10-13 kl. 11:15, skrev Takashi Iwai:
> > On Mon, 09 Oct 2023 13:54:25 +0200,
> > Maarten Lankhorst wrote:
> >> In an effort to not call sof_ops_free twice, we stopped running it when
> >> probe was aborted.
> >> 
> >> Check the result of cancel_work_sync to see if this was the case.
> >> 
> >> Fixes: 31bb7bd9ffee ("ASoC: SOF: core: Only call sof_ops_free() on remove if the probe was successful")
> >> Cc: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
> >> Acked-by: Mark Brown <broonie@kernel.org>
> > Your Signed-off-by tag is missing.
> > 
> > Could you resubmit?
> > 
> > 
> > thanks,
> > 
> > Takashi
> 
> I missed this email apparently.
> 
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> 
> Is this enough for the tooling, or do you need an actual resubmit?

That's enough, and I applied the series to for-next branch now.


thanks,

Takashi