Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Thu, 19 Oct 2023 15:27:43 +0200
From:   =?UTF-8?B?S8O2cnk=?= Maincent <kory.maincent@bootlin.com>
To:     Michal Kubecek <mkubecek@suse.cz>
Cc:     Oleksij Rempel <o.rempel@pengutronix.de>,
        "David S. Miller" <davem@davemloft.net>,
        Andrew Lunn <andrew@lunn.ch>,
        Eric Dumazet <edumazet@google.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Vladimir Oltean <olteanv@gmail.com>, kernel@pengutronix.de,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net v1 1/1] ethtool: fix clearing of WoL flags
Message-ID: <20231019152743.09b28ef4@kmaincent-XPS-13-7390>
In-Reply-To: <20231019105048.l64jp2nd46fxjewt@lion.mk-sys.cz>
References: <20231019070904.521718-1-o.rempel@pengutronix.de>
        <20231019090510.bbcmh7stzqqgchdd@lion.mk-sys.cz>
        <20231019095140.l6fffnszraeb6iiw@lion.mk-sys.cz>
        <20231019122114.5b4a13a9@kmaincent-XPS-13-7390>
        <20231019105048.l64jp2nd46fxjewt@lion.mk-sys.cz>
Organization: bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, 19 Oct 2023 12:50:48 +0200
Michal Kubecek <mkubecek@suse.cz> wrote:

> On Thu, Oct 19, 2023 at 12:21:14PM +0200, K=C3=B6ry Maincent wrote:
> > On Thu, 19 Oct 2023 11:51:40 +0200 > Michal Kubecek <mkubecek@suse.cz>
> > wrote: =20
> > >=20
> > > The issue was indeed introduced by commit 108a36d07c01 ("ethtool: Fix
> > > mod state of verbose no_mask bitset"). The problem is that a "no mask"
> > > verbose bitset only contains bit attributes for bits to be set. This
> > > worked correctly before this commit because we were always updating
> > > a zero bitmap (since commit 6699170376ab ("ethtool: fix application of
> > > verbose no_mask bitset"), that is) so that the rest was left zero
> > > naturally. But now the 1->0 change (old_val is true, bit not present =
in
> > > netlink nest) no longer works. =20
> >=20
> > Doh I had not seen this issue! Thanks you for reporting it.
> > I will send the revert then and will update the fix for next merge-wind=
ow. =20
>=20
> Something like the diff below (against current mainline) might do the
> trick but it's just an idea, not even build tested.

Seems a good idea without adding too much complexity to the code.
Will try that and send it in next merge window.

K=C3=B6ry