Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Date:   Thu, 19 Oct 2023 16:34:37 +0300
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Rob Herring <robh@kernel.org>,
        Colin Foster <colin.foster@in-advantage.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Samuel Holland <samuel@sholland.org>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Woojung Huh <woojung.huh@microchip.com>,
        UNGLinuxDriver@microchip.com,
        Linus Walleij <linus.walleij@linaro.org>,
        Alvin =?utf-8?Q?=C5=A0ipraga?= <alsi@bang-olufsen.dk>,
        =?utf-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= <clement.leger@bootlin.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Magnus Damm <magnus.damm@gmail.com>,
        Maxime Ripard <mripard@kernel.org>,
        =?utf-8?B?bsOnIMOcTkFM?= <arinc.unal@arinc9.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Sean Wang <sean.wang@mediatek.com>,
        Daniel Golle <daniel@makrotopia.org>,
        John Crispin <john@phrozen.org>,
        Gerhard Engleder <gerhard@engleder-embedded.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Sergey Shtylyov <s.shtylyov@omp.ru>,
        Sergei Shtylyov <sergei.shtylyov@gmail.com>,
        Justin Chen <justin.chen@broadcom.com>,
        Florian Fainelli <florian.fainelli@broadcom.com>,
        Sekhar Nori <nsekhar@ti.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev,
        linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
        linux-renesas-soc@vger.kernel.org,
        bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH net-next 4/8] dt-bindings: net: ethernet-switch: Add
 missing 'ethernet-ports' level
Message-ID: <20231019133437.24p5sakrile4ceah@skbuf>
References: <20231016-dt-net-cleanups-v1-0-a525a090b444@kernel.org>
 <20231016-dt-net-cleanups-v1-4-a525a090b444@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231016-dt-net-cleanups-v1-4-a525a090b444@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+LfafpbwDlbpN74M6LEv1ugDc8jZRNS5F10A/9O31p0LsC1ZfQFRKvAp+tM0?=
 =?us-ascii?Q?WoZKmO+e+PUvmfKmzg41L1RAVGVRQxpZnY/tpPIPnNRzqGktJ+W16UzrQaGx?=
 =?us-ascii?Q?hGgI0Ml0psPY89+HCaz3Q5pn+6xefKYnF9Ar3goLpcLGS5Uv3TzI87TdD/Rq?=
 =?us-ascii?Q?qK0wn91jpKlTosEDQIoK+g/Bcd1aqlXY8qY0lunoLmIOdOBMLyrNkvEo8JdP?=
 =?us-ascii?Q?R1UnPAHjHcgROFUHLNeu3EGDYN3NuwcEFL6o1jaW77PjB3a52sbHgr+G+ELa?=
 =?us-ascii?Q?RZmex7GX/FP0yKH/q/juou9ZN2yeyHIz4xx1b58os7S7jDB25M/hGqnGGmyI?=
 =?us-ascii?Q?I2GXsNFxz78NtzkeTC2sgwcoheQ2EoBSWieX93hPhx9mVBejCyi3iYsHYUbm?=
 =?us-ascii?Q?F0h0z/kHvB9uo+MSJoWKVJymuXRvGuxgMXWtnenyV8ZuT8LDcccgc7AQXokr?=
 =?us-ascii?Q?8DT38NvkX7ttu/GiF30+Q9VEAiCaBeNt3230OatM+P0tpp9mdMNESNRi81GM?=
 =?us-ascii?Q?Mj0d1vtk8x58D7C2TGXoXsAnLIzB7mMe5UF88mHkSp0huPNZc6VoA8/iJzBg?=
 =?us-ascii?Q?z0+rDdUckdUCSp0ZlLGPQNTeqnjnj7eu49VUZ8iU5SONE8Jpf2iykIb7DlQC?=
 =?us-ascii?Q?54j9sW9U650B3vZvSSWhria5pJR288hwJR5cBOENzD79N/gfLvTxsAVhU4vu?=
 =?us-ascii?Q?Qt5GiGSnYL4SeWp8iCoxkSSYRDFtaIM4xfUKeAXytQHpovtxEaT5AoTHGgHJ?=
 =?us-ascii?Q?rI3jJIChmfQFcKdxyAyqKk36Kry5UOrwipZaHyq3PJ6sqs9TZIsPkkwsaG4h?=
 =?us-ascii?Q?amXc5stSkhRzHMUIsvtde0H8ciYNaX5N2DJNx6jMqom/wM91OAjIZRITu3D1?=
 =?us-ascii?Q?QhzOBLG86hW1Lu2DUDigj1e2hXSqtDdi9hZ5Mm7ai5ro8FhoTfOpymH/8yzt?=
 =?us-ascii?Q?EicE5rMZoiiwT+INk8OWj6owSg+d4MS+GdMJ3nNDi5OXR2VhrsCKDoToVTn8?=
 =?us-ascii?Q?BVJVe8LpBKh9Awdq6x+W1IqqCLCootrmuBh733OqD0c3bOFRMTJ6Dc2KeDae?=
 =?us-ascii?Q?fe7jKRL1lL5FRqD6Pu5V9Op6gA1/eJEZeKta+QJl3qUhu3Dlt/c4PLhNz/Nc?=
 =?us-ascii?Q?WZwLoa8IkfR5rn77n0drqjyuIYGLULg5XXajeMfWCsWyHDnECifbPSbRvwna?=
 =?us-ascii?Q?uKL/D4eO0nMVNxEdXLGkf78YrX6FQ5ODXo2TSbCNGl7RodfPqAin3uRujyg/?=
 =?us-ascii?Q?bpJkbv0jVPbpJu611WYkg9cKz9FAc62o+uj7t0cBcER/1YKKLtaPHA9Nhs9T?=
 =?us-ascii?Q?Wg+j1mHPYF6NVal6vvU+iYp9V68EJtp/2VeLPEmXoO1QxhHAWlaloSghSwq9?=
 =?us-ascii?Q?tDJyWFKW61gUhXudk5X88fPuIhI1J8fZ/5rz7Y0B1M4zppBYJFw8aAP4ECAZ?=
 =?us-ascii?Q?CU9ecSeEi7GwEXT8nLC/TwI3PbdADFPb6Xkr9xsSTlQXTdT4jRln/xkhibxg?=
 =?us-ascii?Q?spEA+q3I5rbHCdWnoTd20SC66eUjVULW2gJh0YpPzg6iTMFWrTWrxaUB9HfO?=
 =?us-ascii?Q?ACR1rRYcSIwgd/cMo5aFEx//NtNeBSzWn6/WSPBsIjg3aZyMDvpvlwsBVON/?=
 =?us-ascii?Q?vQ=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 46b3c85e-36d1-4705-14b6-08dbd0a82732
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2023 13:34:43.7193
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cdBlmn0RdBfHkXHCatIN6sa+9ifNN/1oGotmTm1+fKMw+OSsW51sUxhFT9G+8AVe+fN3d4YiNw8Ear2jymfhfA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7803
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 19 Oct 2023 06:34:55 -0700 (PDT)

On Mon, Oct 16, 2023 at 04:44:23PM -0500, Rob Herring wrote:
> The '$defs/ethernet-ports' schema is referenced by schemas defining a
> child node 'ethernet-ports', but this schema misses the
> 'ethernet-ports' node. It would work if referring schemas made a
> reference like this:
> 
> properties:
>   ethernet-ports:
>     $ref: ethernet-switch.yaml#/$defs/ethernet-ports
> 
> However, that would be different from how dsa.yaml works. For
> consistency, align the schema definition with dsa.yaml and add the
> missing level.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/net/ethernet-switch.yaml | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/ethernet-switch.yaml b/Documentation/devicetree/bindings/net/ethernet-switch.yaml
> index dcbffe19d71a..688938c2e261 100644
> --- a/Documentation/devicetree/bindings/net/ethernet-switch.yaml
> +++ b/Documentation/devicetree/bindings/net/ethernet-switch.yaml
> @@ -58,9 +58,11 @@ $defs:
>      $ref: '#'
>  
>      patternProperties:
> -      "^(ethernet-)?port@[0-9a-f]+$":
> -        description: Ethernet switch ports
> -        $ref: ethernet-switch-port.yaml#
> -        unevaluatedProperties: false
> +      "^(ethernet-)?ports$":
> +        patternProperties:
> +          "^(ethernet-)?port@[0-9a-f]+$":
> +            description: Ethernet switch ports
> +            $ref: ethernet-switch-port.yaml#
> +            unevaluatedProperties: false
>  
>  ...
> 
> -- 
> 2.42.0
>

Huh, interesting.

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>