Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Thu, 19 Oct 2023 15:56:03 +0200
From:   Michal Kubecek <mkubecek@suse.cz>
To:     Kory Maincent <kory.maincent@bootlin.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Richard Cochran <richardcochran@gmail.com>,
        Simon Horman <horms@kernel.org>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Maxime Chevallier <maxime.chevallier@bootlin.com>,
        stable@vger.kernel.org, Oleksij Rempel <linux@rempel-privat.de>
Subject: Re: [PATCH net] Revert "ethtool: Fix mod state of verbose no_mask
 bitset"
Message-ID: <20231019135603.5ujrcrryepo3fnxb@lion.mk-sys.cz>
References: <20231019-feature_ptp_bitset_fix-v1-1-70f3c429a221@bootlin.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="7eoyyk2q7bwdffce"
Content-Disposition: inline
In-Reply-To: <20231019-feature_ptp_bitset_fix-v1-1-70f3c429a221@bootlin.com>
Precedence: bulk


--7eoyyk2q7bwdffce
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Oct 19, 2023 at 03:16:41PM +0200, Kory Maincent wrote:
> This reverts commit 108a36d07c01edbc5942d27c92494d1c6e4d45a0.
>=20
> It was reported that this fix breaks the possibility to remove existing W=
oL
> flags. For example:
> ~$ ethtool lan2
> ...
>         Supports Wake-on: pg
>         Wake-on: d
> ...
> ~$ ethtool -s lan2 wol gp
> ~$ ethtool lan2
> ...
>         Wake-on: pg
> ...
> ~$ ethtool -s lan2 wol d
> ~$ ethtool lan2
> ...
>         Wake-on: pg
> ...
>=20
> This worked correctly before this commit because we were always updating
> a zero bitmap (since commit 6699170376ab ("ethtool: fix application of
> verbose no_mask bitset"), that is) so that the rest was left zero
> naturally. But now the 1->0 change (old_val is true, bit not present in
> netlink nest) no longer works.
>=20
> Reported-by: Oleksij Rempel <o.rempel@pengutronix.de>
> Reported-by: Michal Kubecek <mkubecek@suse.cz>
> Closes: https://lore.kernel.org/netdev/20231019095140.l6fffnszraeb6iiw@li=
on.mk-sys.cz/
> Cc: stable@vger.kernel.org
> Fixes: 108a36d07c01 ("ethtool: Fix mod state of verbose no_mask bitset")
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>

Reviewed-by: Michal Kubecek <mkubecek@suse.cz>

> ---
>=20
> This patch is reverted for now as we are approaching the end of the
> merge-window. The real fix that fix the mod value will be sent later
> on the next merge-window.
> ---

For the record, the term "merge window" is used for the 2-week interval
between a final and following rc1, not for the whole interval between
two final releases.=20

Michal

--7eoyyk2q7bwdffce
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEWN3j3bieVmp26mKO538sG/LRdpUFAmUxNW0ACgkQ538sG/LR
dpXpzAgAhkLiE6HP1Juk2CV218cbvVeNjzEnX6NKoha+PydKxaIzpb6QsnLQHZXt
gNdLVB/C3vemWW1HiqWGJd4bf5/i9SIvS88KG/GpapU2mL2tE0RWrJZorUy4OPaP
cOMJr2pUBXlgeBZeVZCQ50w1/yhMihq9YrAMaSByIsCiswyKLSXBxybud2nt399i
nnBUY9+glEvWnifL9gh0beV2iuUKPo7NanV6BbT+9RxFdHrezF2rghWEQsebhxsj
OL9XlMNlhcyuONUGbDtMIYMEaKErQz9WXfrgbBnhTBEWv71OZ5k9CTsYV91YoMqW
IT3oflnMb6nOjxoOB7veoq2jWDIWwg==
=NLYO
-----END PGP SIGNATURE-----

--7eoyyk2q7bwdffce--