Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Received-SPF: Pass (protection.outlook.com: domain of duagon.com designates
 194.38.86.34 as permitted sender) receiver=protection.outlook.com;
 client-ip=194.38.86.34; helo=securemail.duagon.com; pr=C
Received-SPF: Pass (protection.outlook.com: domain of duagon.com designates
 20.79.222.204 as permitted sender) receiver=protection.outlook.com;
 client-ip=20.79.222.204; helo=de2-emailsignatures-cloud.codetwo.com; pr=C
From:   =?iso-8859-1?Q?Sanju=E1n_Garc=EDa=2C_Jorge?= 
        <Jorge.SanjuanGarcia@duagon.com>
To:     "morbidrsa@gmail.com" <morbidrsa@gmail.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "jth@kernel.org" <jth@kernel.org>,
        =?iso-8859-1?Q?Rodr=EDguez_Barbarin=2C_Jos=E9_Javier?= 
        <josejavier.rodriguez@duagon.com>,
        =?iso-8859-1?Q?Sanju=E1n_Garc=EDa=2C_Jorge?= 
        <Jorge.SanjuanGarcia@duagon.com>
Subject: [RESEND PATCH] mcb: mcb-pci: detect IO mapped devices before
 requesting resources
Thread-Topic: [RESEND PATCH] mcb: mcb-pci: detect IO mapped devices before
 requesting resources
Thread-Index: AQHaApcsEOIlC6gSJkudMMweS8mFww==
Date:   Thu, 19 Oct 2023 14:18:47 +0000
Message-ID: <20231019141832.58288-1-jorge.sanjuangarcia@duagon.com>
Accept-Language: es-ES, en-US
Content-Language: en-US
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=duagon.com;
X-Microsoft-Antispam-Message-Info-Original: VxmwqFI/hObJP5IPanyD0X08CVP13oEz9hUP7hvGN7i5qPJeEYVIc4MJsrD2rGlaPph5XXNvDFSM5zcCvkVNCfBKDaPKxApbHEloVmy42L5YZlSUwAO5BIpyfM2jgT+/OYCoJbthYkQyHWiaOaTLYnNgqQnDGlVv3NKAenELmljjFHPlPEjTc2Xj3JPvcvuIDGcmL1ORkOdruFOHMNillgCOam12nVLG7u1OReP/vDdLJYbkfyRAd9lbHGK7Yd0uj54mAs8Sb4XaEgOb0H9TBzM3M+oBKuysir1tmAmU+n9J7DJvVlNPadIYb7E1TFkI5qkrsIAvIr07V6bRFpuP/SqfEO8yVqVFzNFWmSqDEXY0l1P3lBEQrCpogz63ZzMP9um4UaaD83absWLxcRogS9vC+uIk3Rg6gkXMcPF6u4BZreXYEhIm0jvFO3Gz52cVF9GEZnaCnQ//7CR581lghuKO58JKb4BylAMU2x7m5jXPMl6I8pNAMxumoqm44CJ1hfKI32LurBtvThoN1S5hh6F3viQbfJc1bZAmX4nB75Jd/jW+7winpd1KkbKLHKy9qIz1krUFNwvDWz6gIWnx62iUh47hJScnMfQTx6Xycf9OUqi7ZesGL6aVpkdMmpxO
X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV0P278MB0516.CHEP278.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(39850400004)(396003)(136003)(376002)(346002)(366004)(230922051799003)(451199024)(64100799003)(186009)(1800799009)(478600001)(6486002)(71200400001)(91956017)(66946007)(66476007)(66446008)(66556008)(64756008)(54906003)(76116006)(6916009)(38070700005)(86362001)(122000001)(38100700002)(316002)(5660300002)(36756003)(41300700001)(8676002)(2906002)(8936002)(4326008)(26005)(6512007)(83380400001)(1076003)(2616005)(107886003)(6506007);DIR:OUT;SFP:1102;
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVAP278MB0038
X-CodeTwo-MessageID: 266c0561-9fb4-4353-bec3-ec8b8c429821.20231019141849@de2-emailsignatures-cloud.codetwo.com
X-CodeTwoProcessed: true
X-EOPAttributedMessage: 1
X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM2PEPF0001C70E.eurprd05.prod.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs: e088365e-06f1-41db-7719-08dbd0ae4f44
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original: QEK/ACQQSlYNUWmCLr4wYRWY8Dr8xWkk/7aHMu2MnQXX9Z5h5369SCOcq6nu3EZLKi2TGg4Fx4phPTEMiJrzz9jOis57/EOgdOtM2aZRFVX7NrFiEmjR7vMdr4hDJJakqdoeaV9/avBkJwRTzVtmTYvEPmSoNZ3mi+OfFNSat+RDKHFrWq/BlNQgBTjcf2J+BYjHCfNYleU9s/rFXL5FYQuWee+GVr1+XyLosJmTBJhZsaPI7avFRqjlQv7jscLjNTjuLDxuXTNxazhNS/LrX4NqhT4DiLve8BJHIJOMIYJcyOgJSr+P4012jU+ABvHb+MOF80Z793XjXD+1eqjSYnjqQPcI4HWs+tXbtNzEfolyVwEs0sWjui2Fik1OAUP+AfAOE8xx96a6piE+HTVCcn22OOLId6BWgcxAr2akg0tAuHjEpz659ShPWu4+xug09pbiElaCqMOq6ddWDddbLrvtLsEozXF3i/dDQDslr+hT2VqVIZq7NwUlbiq2+0y0e/D9L0V/LSf+1N/7ZuswUlKomswGohJ3zqzzlQcPiNoBM6KbPyibPYGJCN+cHgoOyhmYxmB0xB4ZtAs3ipf1lWbNzNsLnJSPw9chrWS+3CR3NwChdfaBIEwfCNqEXQ50HE4JHzqRVyVTTZkxxjrc+JnxjgPxNVBzivItIMyncIaNiCXchlQ3Fn6eqi3Cilmmkj2sB8rBhMy8ndxXwajOFw==
X-Forefront-Antispam-Report-Untrusted: CIP:20.79.222.204;CTRY:DE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:de2-emailsignatures-cloud.codetwo.com;PTR:de2-emailsignatures-cloud.codetwo.com;CAT:NONE;SFS:(13230031)(346002)(136003)(39850400004)(396003)(376002)(230922051799003)(64100799003)(186009)(82310400011)(1800799009)(451199024)(46966006)(36840700001)(47076005)(36860700001)(83380400001)(336012)(8936002)(1076003)(107886003)(6506007)(2616005)(6512007)(82740400003)(6486002)(478600001)(7596003)(70206006)(70586007)(7636003)(26005)(54906003)(356005)(6916009)(8676002)(316002)(4326008)(86362001)(5660300002)(36756003)(41300700001)(2906002)(40480700001);DIR:OUT;SFP:1102;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV0P278MB0036
X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM4PEPF00027A69.eurprd04.prod.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs: 49753fed-372c-45b8-0067-08dbd0ae5133
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ea2c40oT3CqJj2P2xYPbihOahfwD4TDnpNFozYP8pj10c13Yd27sJFAEvVgWzweKlGzSpp2POmTg0YEiGf/nozccBxvfYtAGXQ+IJqZksXFzasGNlZLSdW2M0OlJjhM1+cpjaZexqvPKwnE6mbZrc4swSEG+AXbhbVOTDKwoZbqPArTkdK8qzo3Q62eYZpBZ9QmxOPxJri1VrY/1te4nGVapUI9vpds78G0OL7WavNw1/bziRZMoni/P8WWqAabV5ALj2/VelcDSHTdwSa+NYgLwY1TAT7HD8IIde/gLYsFqNYU4m8S2uHWaf9DEkjM0GvjjZO7ajiaFcCy8Eez0G7Vv1b/7kqqI5/Yx5pWBUN63gZvJD6yteKUa8YvpzAJEJZ3qvdXSZpu9bZwR5WdJmy3uBRbQ/yy8F3ITM/rC2eZT/SDFj0KoMUMJzPjU8hOcOpI3RYgt3qJXac1dPO73vEgTQDlfKUWPw0RBhKvQo1qNBQlNiBd7rxqFf08w1nZ/hFiBbguJiZLSbKSqEfMS1weqhR6gKbjnSOg56k0lIvHarSCukSJJFCjgCtOR6/v7WK7K60MieVzbqixz92phkNmPVKcTZpj7N7ugPUbn2Ax0OoimtgnzRMNnpf+A6ef7PbBLNk1xgJ8XlcnoyLibtFd9mgeyIE2CLxnJsrUOTkMbK+hw4GYsIHEn4limTAuc9+tYaoAE9lZe9QUunkYV5u7cDuW6UmgcyNXyRrp4PF3xoOqGN5xseb3yot3/e8fvhtyl0QVrI5t6Dd2rdjTWmw==
X-Forefront-Antispam-Report: CIP:194.38.86.34;CTRY:CH;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:securemail.duagon.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(39850400004)(346002)(136003)(396003)(376002)(230922051799003)(1800799009)(186009)(64100799003)(82310400011)(451199024)(46966006)(40470700004)(36840700001)(47076005)(36860700001)(83380400001)(6916009)(1076003)(2616005)(81166007)(6506007)(336012)(82740400003)(107886003)(6512007)(316002)(6486002)(478600001)(70206006)(8936002)(70586007)(26005)(54906003)(4326008)(8676002)(86362001)(5660300002)(36756003)(41300700001)(2906002)(40460700003)(40480700001)(36900700001);DIR:OUT;SFP:1102;
X-OriginatorOrg: duagon.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2023 14:18:54.4026
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 46e35cee-4141-47ea-d00b-08dbd0ae5378
X-MS-Exchange-CrossTenant-Id: e5e7e96e-8a28-45d6-9093-a40dd5b51a57
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5e7e96e-8a28-45d6-9093-a40dd5b51a57;Ip=[194.38.86.34];Helo=[securemail.duagon.com]
X-MS-Exchange-CrossTenant-AuthSource: AM4PEPF00027A69.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV0P278MB1126
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 19 Oct 2023 07:19:20 -0700 (PDT)

If the memory region is requested with devm_request_mem_region()
for an IO mapped device it will return an error and mcb-pci will
incorrectly report it with EBUSY code.

Make sure we identify if the reosure is IO mapped and fail early
with a correct ENOTSUPP code.

Reviewed-by: Jose Javier Rodriguez Barbarin <JoseJavier.Rodriguez@duagon.co=
m>
Signed-off-by: Jorge Sanjuan Garcia <jorge.sanjuangarcia@duagon.com>
---
 drivers/mcb/mcb-pci.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/mcb/mcb-pci.c b/drivers/mcb/mcb-pci.c
index 53d9202ff9a7..3b634ea318c7 100644
--- a/drivers/mcb/mcb-pci.c
+++ b/drivers/mcb/mcb-pci.c
@@ -45,6 +45,14 @@ static int mcb_pci_probe(struct pci_dev *pdev, const str=
uct pci_device_id *id)
 	}
 	pci_set_master(pdev);
=20
+	flags =3D pci_resource_flags(pdev, 0);
+	if (flags & IORESOURCE_IO) {
+		ret =3D -ENOTSUPP;
+		dev_err(&pdev->dev,
+			"IO mapped PCI devices are not supported\n");
+		goto out_disable;
+	}
+
 	priv->mapbase =3D pci_resource_start(pdev, 0);
 	if (!priv->mapbase) {
 		dev_err(&pdev->dev, "No PCI resource\n");
@@ -68,14 +76,6 @@ static int mcb_pci_probe(struct pci_dev *pdev, const str=
uct pci_device_id *id)
 		goto out_disable;
 	}
=20
-	flags =3D pci_resource_flags(pdev, 0);
-	if (flags & IORESOURCE_IO) {
-		ret =3D -ENOTSUPP;
-		dev_err(&pdev->dev,
-			"IO mapped PCI devices are not supported\n");
-		goto out_disable;
-	}
-
 	pci_set_drvdata(pdev, priv);
=20
 	priv->bus =3D mcb_alloc_bus(&pdev->dev);
--=20
2.34.1